typhoon: memory corruptor on big-endian if TSO is enabled txlo_dma_addr should be host-endian; we pass it to typhoon_tso_fill(), which does arithmetics on it, converts to l-e and passes it to card. Unfortunately, we forgot le32_to_cpu() when initializing it from face->txLoAddr, which sits in shared memory and is little-endian. Signed-off-by: Al Viro <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 501abe3..2550d4c 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c
@@ -1320,7 +1320,7 @@ tp->txLoRing.writeRegister = TYPHOON_REG_TX_LO_READY; tp->txHiRing.writeRegister = TYPHOON_REG_TX_HI_READY; - tp->txlo_dma_addr = iface->txLoAddr; + tp->txlo_dma_addr = le32_to_cpu(iface->txLoAddr); tp->card_state = Sleeping; smp_wmb();