scripts/checkpatch.pl: add check for declaration of pci_device_id Signed-off-by: Joe Perches <[email protected]> Cc: Andy Whitcroft <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2ec5fc6..90b54d4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl
@@ -1881,6 +1881,11 @@ $herecurr); } +# check for declarations of struct pci_device_id + if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) { + WARN("Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr); + } + # check for new typedefs, only function parameters and sparse annotations # make sense. if ($line =~ /\btypedef\s/ &&