| commit | facf3f0621b2e11957af1aae9085730ea78ccf85 | [log] [tgz] |
|---|---|---|
| author | Arnaldo Carvalho de Melo <[email protected]> | Mon May 25 15:30:09 2015 -0300 |
| committer | Arnaldo Carvalho de Melo <[email protected]> | Wed May 27 20:27:16 2015 -0300 |
| tree | d898cea7cc764ce699c7da383310ed9c28b0bf3b | |
| parent | 6a2ffcddad22ead7ce75c5773e87895b91e7cca7 [diff] [blame] |
perf tools: Check if a map is still in use when deleting it I.e. match RB_CLEAR_NODE() with RB_EMPTY_NODE(), to check that it isn't in a rb tree at the time of its deletion. Cc: Adrian Hunter <[email protected]> Cc: Borislav Petkov <[email protected]> Cc: David Ahern <[email protected]> Cc: Don Zickus <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Stephane Eranian <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index b57a027..c434e12 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c
@@ -59,6 +59,10 @@ (al->sym == NULL || strcmp(ann->sym_hist_filter, al->sym->name) != 0)) { /* We're only interested in a symbol named sym_hist_filter */ + /* + * FIXME: why isn't this done in the symbol_filter when loading + * the DSO? + */ if (al->sym != NULL) { rb_erase(&al->sym->rb_node, &al->map->dso->symbols[al->map->type]);