tree 0e56c0dcf4a60a1a17be2a73d5b36c9b025149e8
parent 6bc514f935f8fe39becb3ca915695caa4604de62
author Pietro Borrello <borrello@diag.uniroma1.it> 1676160104 +0000
committer Wilson Sung <wilsonsung@google.com> 1683197559 +0000

UPSTREAM: hid: bigben_probe(): validate report count

[ Upstream commit b94335f899542a0da5fafc38af8edcaf90195843 ]

bigben_probe() does not validate that the output report has the
needed report values in the first field.
A malicious device registering a report with one field and a single
value causes an head OOB write in bigben_worker() when
accessing report_field->value[1] to report_field->value[7].
Use hid_validate_values() which takes care of all the needed checks.

Bug: 268589017
Fixes: 256a90ed9e46 ("HID: hid-bigbenff: driver for BigBen Interactive PS3OFMINIPAD gamepad")
Bug: 280751063
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230211-bigben-oob-v1-1-d2849688594c@diag.uniroma1.it
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Lee Jones <joneslee@google.com>
Signed-off-by: Wilson Sung <wilsonsung@google.com>
Change-Id: I575c5d4c8a63a2065752a45c47b23cf725cc57ae