| commit | bf1bc247eeeca3a2cbc964b85ef1a0977ce1e1b8 | [log] [tgz] |
|---|---|---|
| author | Alexander Potapenko <[email protected]> | Wed May 27 22:20:52 2020 -0700 |
| committer | Todd Kjos <[email protected]> | Mon Dec 21 13:39:08 2020 -0800 |
| tree | c920f4d851a9e73a3af717cb64989e496dc23ab6 | |
| parent | 2a851e182322c1a8137428e1016eccd07a7f5efd [diff] |
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info() [ Upstream commit 1d605416fb7175e1adf094251466caa52093b413 ] KMSAN reported uninitialized data being written to disk when dumping core. As a result, several kilobytes of kmalloc memory may be written to the core file and then read by a non-privileged user. Reported-by: sam <[email protected]> Signed-off-by: Alexander Potapenko <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Acked-by: Kees Cook <[email protected]> Cc: Al Viro <[email protected]> Cc: Alexey Dobriyan <[email protected]> Cc: <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Link: https://github.com/google/kmsan/issues/76 Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Lee Jones <[email protected]> Change-Id: I247cd20b7d51612ed27d79424db0fa9318769bf6
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index e39fe28..80b647865 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c
@@ -1555,7 +1555,7 @@ (!regset->active || regset->active(t->task, regset))) { int ret; size_t size = regset->n * regset->size; - void *data = kmalloc(size, GFP_KERNEL); + void *data = kzalloc(size, GFP_KERNEL); if (unlikely(!data)) return 0; ret = regset->get(t->task, regset,