commit 9a0af6745d89355811b365aade3f797f4006e9b5
author AleX Pelosi <apelosi@google.com> Thu Apr 01 16:04:56 2021 -0700
committer AleX Pelosi <apelosi@google.com> Mon Apr 05 12:56:53 2021 -0700
tree b4f126838cdfe06c668d44f06978e8ea54dc160b
parent 27284413154174f08e3a0f1270ab367668e92188

max1720x_battery: check argumets on GPL functions

Return an error when the parameters passed to public functions are invalid.

Bug: 184308977
Signed-off-by: AleX Pelosi <apelosi@google.com>
Change-Id: I29558b82abc3c9f61567d6820c1d8d3f0fa6360c

max1720x_battery.c

diff --git a/max1720x_battery.c b/max1720x_battery.c
index 8609132..9a0721a 100644
--- a/max1720x_battery.c
+++ b/max1720x_battery.c
@@ -984,10 +984,14 @@
 
 int max1720x_get_capacity(struct i2c_client *client, int *iic_raw)
 {
-	struct max1720x_chip *chip = i2c_get_clientdata(client);
+	struct max1720x_chip *chip;
 	u16 temp;
 	int ret;
 
+	if (!client || !iic_raw)
+		return -EINVAL;
+
+	chip = i2c_get_clientdata(client);
 	if (!chip)
 		return -ENODEV;
 
@@ -1006,6 +1010,9 @@
 	u16 temp;
 	int ret;
 
+	if (!client || !volt)
+		return -EINVAL;
+
 	chip = i2c_get_clientdata(client);
 	if (!chip)
 		return -ENODEV;