max_m5: enhanced model loading process
Add more conditions to check for plausible data.
Prevent loading incorrect values from causing inaccurate calculation results
Bug: 275009537
Change-Id: I02a656a1ace1f582cac9295651e7aec7f37f5df8
Signed-off-by: Jenny Ho <[email protected]>
diff --git a/max_m5.c b/max_m5.c
index 02d8279..4532e8c 100644
--- a/max_m5.c
+++ b/max_m5.c
@@ -591,9 +591,13 @@
return same;
}
-static int max_m5_check_state_data(struct model_state_save *state)
+/* TODO: make it adjustable, set 10% tolerance here */
+#define MAX_M5_CAP_MAX_RATIO 110
+static int max_m5_check_state_data(struct model_state_save *state,
+ struct max_m5_custom_parameters *ini)
{
bool bad_residual, empty;
+ int max_cap = ini->designcap * MAX_M5_CAP_MAX_RATIO / 100;
empty = memtst(state, 0xff, sizeof(*state));
if (empty)
@@ -613,6 +617,12 @@
if (bad_residual)
return -EINVAL;
+ if (state->fullcaprep > max_cap)
+ return -ERANGE;
+
+ if (state->fullcapnom > max_cap)
+ return -ERANGE;
+
return 0;
}
@@ -661,7 +671,7 @@
return ret;
}
- ret = max_m5_check_state_data(&m5_data->model_save);
+ ret = max_m5_check_state_data(&m5_data->model_save, cp);
if (ret < 0)
return ret;
