commit 16c0a50cc87997fb6dd3cd7aa4b9cef3ca6bc7dd
author Dan Shi <dshi@chromium.org> Tue Jul 14 17:29:48 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Wed Jul 15 05:12:28 2015 +0000
tree 9edaf500566600eaadf5e11428cf6c54a7e70a5b
parent 22220c0acc18892a46a63b944c5bb35265e8f529

[autotest] Upgrade setuptools and make errors more visible

setuptools is too old, upgrade it to latest.
Allow _build_and_install to return a tuple of success, error_message.
Then build_externals can print the error at the end as well.

BUG=chromium:510143
TEST=local test

Change-Id: Ia750fd333e6d0d9d137a68b49fafc441094f07bc
Reviewed-on: https://chromium-review.googlesource.com/285646
Tested-by: Dan Shi <dshi@chromium.org>
Reviewed-by: Fang Deng <fdeng@chromium.org>
Commit-Queue: Fang Deng <fdeng@chromium.org>

utils/build_externals.py

diff --git a/utils/build_externals.py b/utils/build_externals.py
index b404b6e..ccd102a 100755
--- a/utils/build_externals.py
+++ b/utils/build_externals.py
@@ -12,8 +12,7 @@
     utils/build_externals.py
 """
 
-import compileall, logging, os, shutil, sys, tempfile, time, urllib2
-import subprocess, re
+import compileall, logging, os, sys
 import common
 from autotest_lib.client.common_lib import logging_config, logging_manager
 from autotest_lib.client.common_lib import utils
@@ -136,8 +135,16 @@
     """
     errors = []
     for package in packages:
-        if not package.build_and_install(install_dir):
-            msg = 'Unable to build and install %s' % package.name
+        result = package.build_and_install(install_dir)
+        if isinstance(result, bool):
+            success = result
+            message = None
+        else:
+            success = result[0]
+            message = result[1]
+        if not success:
+            msg = ('Unable to build and install %s.\nError: %s' %
+                   (package.name, message))
             logging.error(msg)
             errors.append(msg)
     return errors