I ran PyLint on our client/bin/ files and looked at only the errors.
All of these changes are to lines that were obviously broken or are
new imports. I'm pretty confident this can't break anything and will
fix things. Most of the problems seem to have come from when we
removed import *'s from the code base.
Signed-off-by: Jeremy Orlow <[email protected]>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1688 592f7852-d20e-0410-864c-8624ca9c26a4
diff --git a/client/bin/autotest_utils.py b/client/bin/autotest_utils.py
index c9b572d..25b7e49 100755
--- a/client/bin/autotest_utils.py
+++ b/client/bin/autotest_utils.py
@@ -103,7 +103,7 @@
cachedir = os.path.realpath(cachedir)
if not os.path.isdir(cachedir):
try:
- system('mkdir -p ' + cachedir)
+ utils.system('mkdir -p ' + cachedir)
except:
raise ValueError('Could not create cache directory %s' % cachedir)
file_from_url = os.path.basename(url)
@@ -122,6 +122,7 @@
return utils.unmap_url(cachedir, src, cachedir)
+# TODO: replace all instances with os.path.basename
def basename(path):
i = path.rfind('/');
return path[i+1:]
