[moblab] Fix bug in moblab run suite RPC.
If the RPC is called with no suite_args the code path is incorrect
and results in no tests running / error message being recieved.
BUG=chromium:728846
TEST=Unit test passes, local testing on moblab.
Change-Id: Ibc83a38c0cb232ea15c126fdafc4e2fb3d2ffb0c
Reviewed-on: https://chromium-review.googlesource.com/521754
Commit-Ready: Keith Haddow <[email protected]>
Tested-by: Keith Haddow <[email protected]>
Reviewed-by: Jinsong Mu <[email protected]>
Reviewed-by: Keith Haddow <[email protected]>
Reviewed-by: Michael Tang <[email protected]>
Reviewed-by: Dan Shi <[email protected]>
diff --git a/frontend/afe/moblab_rpc_interface.py b/frontend/afe/moblab_rpc_interface.py
index 04e835c..37b9ef3 100644
--- a/frontend/afe/moblab_rpc_interface.py
+++ b/frontend/afe/moblab_rpc_interface.py
@@ -742,7 +742,10 @@
builds['fwrw-version'] = rw_firmware
if ro_firmware:
builds['fwro-version'] = ro_firmware
- list_suite_args = map(lambda s: s.strip(), suite_args.split(','))
+ if suite_args:
+ list_suite_args = map(lambda s: s.strip(), suite_args.split(','))
+ else:
+ list_suite_args = None
afe = frontend.AFE(user='moblab')
afe.run('create_suite_job', board=board, builds=builds, name=suite,
pool=pool, run_prod_code=False, test_source_build=build,
