[autotest] Delete support for parameterized jobs.
This deletes the `create_parameterized_job()` RPC endpoint and the
associated (unused!) "parameterized_jobs" config setting. It also
garbage collects code made unreferenced by these deletions.
BUG=chromium:679903
TEST=unit tests, and run push_to_prod suite in a local instance
Change-Id: I0c02db8dcd4e8b0a8ac9649723eefffd31c95d82
Reviewed-on: https://chromium-review.googlesource.com/451838
Commit-Ready: Richard Barnette <[email protected]>
Tested-by: Richard Barnette <[email protected]>
Reviewed-by: Dan Shi <[email protected]>
diff --git a/frontend/afe/rpc_interface_unittest.py b/frontend/afe/rpc_interface_unittest.py
index 85d8ee4..87a8cdc 100755
--- a/frontend/afe/rpc_interface_unittest.py
+++ b/frontend/afe/rpc_interface_unittest.py
@@ -1,5 +1,5 @@
#!/usr/bin/python
-#pylint: disable-msg=C0111
+# pylint: disable=missing-docstring
import datetime
import mox
@@ -14,7 +14,6 @@
from autotest_lib.client.common_lib.test_utils import mock
from autotest_lib.frontend import setup_django_environment
from autotest_lib.frontend.afe import frontend_test_utils
-from autotest_lib.frontend.afe import model_attributes
from autotest_lib.frontend.afe import model_logic
from autotest_lib.frontend.afe import models
from autotest_lib.frontend.afe import rpc_interface
@@ -374,56 +373,6 @@
self.assertEquals(task['requested_by'], 'autotest_system')
- def test_parameterized_job(self):
- global_config.global_config.override_config_value(
- 'AUTOTEST_WEB', 'parameterized_jobs', 'True')
-
- string_type = model_attributes.ParameterTypes.STRING
-
- test = models.Test.objects.create(
- name='test', test_type=control_data.CONTROL_TYPE.SERVER)
- test_parameter = test.testparameter_set.create(name='key')
- profiler = models.Profiler.objects.create(name='profiler')
-
- kernels = ({'version': 'version', 'cmdline': 'cmdline'},)
- profilers = ('profiler',)
- profiler_parameters = {'profiler': {'key': ('value', string_type)}}
- job_parameters = {'key': ('value', string_type)}
-
- job_id = rpc_interface.create_parameterized_job(
- name='job', priority=priorities.Priority.DEFAULT, test='test',
- parameters=job_parameters, kernel=kernels, label='label1',
- profilers=profilers, profiler_parameters=profiler_parameters,
- profile_only=False, hosts=('host1',))
- parameterized_job = models.Job.smart_get(job_id).parameterized_job
-
- self.assertEqual(parameterized_job.test, test)
- self.assertEqual(parameterized_job.label, self.labels[0])
- self.assertEqual(parameterized_job.kernels.count(), 1)
- self.assertEqual(parameterized_job.profilers.count(), 1)
-
- kernel = models.Kernel.objects.get(**kernels[0])
- self.assertEqual(parameterized_job.kernels.all()[0], kernel)
- self.assertEqual(parameterized_job.profilers.all()[0], profiler)
-
- parameterized_profiler = models.ParameterizedJobProfiler.objects.get(
- parameterized_job=parameterized_job, profiler=profiler)
- profiler_parameters_obj = (
- models.ParameterizedJobProfilerParameter.objects.get(
- parameterized_job_profiler=parameterized_profiler))
- self.assertEqual(profiler_parameters_obj.parameter_name, 'key')
- self.assertEqual(profiler_parameters_obj.parameter_value, 'value')
- self.assertEqual(profiler_parameters_obj.parameter_type, string_type)
-
- self.assertEqual(
- parameterized_job.parameterizedjobparameter_set.count(), 1)
- parameters_obj = (
- parameterized_job.parameterizedjobparameter_set.all()[0])
- self.assertEqual(parameters_obj.test_parameter, test_parameter)
- self.assertEqual(parameters_obj.parameter_value, 'value')
- self.assertEqual(parameters_obj.parameter_type, string_type)
-
-
def _modify_host_helper(self, on_shard=False, host_on_shard=False):
shard_hostname = 'shard1'
if on_shard:
@@ -617,21 +566,6 @@
self.god.check_playback()
- def test_get_image_for_job_parameterized(self):
- test = models.Test.objects.create(
- name='name', author='author', test_class='class',
- test_category='category',
- test_type=control_data.CONTROL_TYPE.SERVER, path='path')
- parameterized_job = models.ParameterizedJob.objects.create(test=test)
- job = self._create_job(hosts=[1])
- job.parameterized_job = parameterized_job
- self.god.stub_function_to_return(rpc_interface,
- 'get_parameterized_autoupdate_image_url', 'cool-image')
- image = rpc_interface._get_image_for_job(job, True)
- self.assertEquals('cool-image', image)
- self.god.check_playback()
-
-
def test_get_image_for_job_with_keyval_build(self):
keyval_dict = {'build': 'cool-image'}
job_id = rpc_interface.create_job(name='test',
