| commit | cf1431934151b3a93e0b3286eb6798ca08ea3770 | [log] [tgz] |
|---|---|---|
| author | Christopher Taylor <[email protected]> | Thu Nov 21 13:21:11 2024 +0100 |
| committer | Sean Liao <[email protected]> | Wed Apr 30 08:42:02 2025 -0700 |
| tree | e883f630882e0136436a183597dd46356bb61c00 | |
| parent | 32d34ef364e670a650fe59267b92301ff7ed08f1 [diff] |
oauth2: fix expiration time window check Before CL 68017, the test verified that tokens expire exactly one day after they are issued, within the time that Exchange() takes to execute. A refactoring in the CL extended this time window to a whole day, making the check much more lenient. See: https://go-review.googlesource.com/c/oauth2/+/168017 Change-Id: I479db429f64b25a711624817c13f068b4675163e Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/630495 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Junyang Shao <[email protected]> Reviewed-by: Sean Liao <[email protected]> Auto-Submit: Sean Liao <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
diff --git a/oauth2_test.go b/oauth2_test.go index 1cc14c6..5db78f2 100644 --- a/oauth2_test.go +++ b/oauth2_test.go
@@ -300,7 +300,7 @@ conf := newConf(ts.URL) t1 := time.Now().Add(day) tok, err := conf.Exchange(context.Background(), "exchange-code") - t2 := t1.Add(day) + t2 := time.Now().Add(day) if got := (err == nil); got != want { if want {