tree db838fe6bafd1d8a0f042df75a5c5d0d6efbd7f8
parent f865b31f5fb4d30327481e184b042ef0194a140a
author Eric Anderson <ejona@google.com> 1520022677 -0800
committer Eric Anderson <ejona@google.com> 1520026506 -0800

Partially revert "core: change serverimpl,servercallimpl's internalclose to cancel stream (#4038)"

This partially reverts commit 48ca4527c14a95914f9cb7f58ec72997cb96899a.
It leaves the changes to ServerCallImpl and test.

This also partially reverts "Lint fixes" commit
3002a23a0ff9f72cc29c81b3be456d2ee1fa6bc4 which removed unused variables
which are now necessary again.

This is reverted for the combined result of two issues:
* Some users are testing that they get UNKNOWN when the service throws.
  That's not unreasonable given the behavior was well-publicised when it
  changed in v1.5. We should probably keep the UNKNOWN in some common
  cases (like the service threw immediately, before sending anything).
* The client could see CANCELLED instead of INTERNAL as had been
  intended. It's unclear as to why (I didn't investigate heavily). This
  behavior is visible in MoreInProcessTest and was overlooked during
  review.