commit 28aba780c4035cc85a31b778db0f5553c896dd6a
author Ebrahim Byagowi <ebrahim@gnu.org> Fri Aug 23 16:47:15 2019 +0430
committer Ebrahim Byagowi <ebrahim@gnu.org> Sat Aug 24 16:11:21 2019 +0430
tree 2b5545470090607c1e3bfc75b748f49fe911b8e6
parent 541f3c2d7dcae47eb55650082e372286369d4a55

[subset] Fix blob leak of _subset2 when returns early

Fixes https://crbug.com/oss-fuzz/16639

src/hb-subset.cc

diff --git a/src/hb-subset.cc b/src/hb-subset.cc
index 6235a5b..c0752ac 100644
--- a/src/hb-subset.cc
+++ b/src/hb-subset.cc
@@ -82,6 +82,7 @@
     if (unlikely (!buf.alloc (buf_size)))
     {
       DEBUG_MSG(SUBSET, nullptr, "OT::%c%c%c%c failed to allocate %u bytes.", HB_UNTAG (tag), buf_size);
+      hb_blob_destroy (source_blob);
       return false;
     }
   retry:
@@ -96,6 +97,7 @@
       if (unlikely (!buf.alloc (buf_size)))
       {
 	DEBUG_MSG(SUBSET, nullptr, "OT::%c%c%c%c failed to reallocate %u bytes.", HB_UNTAG (tag), buf_size);
+	hb_blob_destroy (source_blob);
 	return false;
       }
       goto retry;