| commit | 896ff15ae60a4a4b94c62946e69196b877839bb5 | [log] [tgz] |
|---|---|---|
| author | Behdad Esfahbod <[email protected]> | Tue Jul 31 22:51:38 2018 -0700 |
| committer | Behdad Esfahbod <[email protected]> | Tue Jul 31 22:51:38 2018 -0700 |
| tree | 252469ac832988695603870ae48c68db59b0a6a4 | |
| parent | d7a15799d40dac1f9521674a82c3293a7cb42ee4 [diff] |
[atomic] Fix get() impl Originally, glib's atomic_get was implemented as "memory_barrier; load". I copied this into cairo, fontconfig, and harfbuzz. However, that's wrong. Correct way is "load; memory_barrier". The details are long and hard to fully grasp. Best to read: https://www.kernel.org/doc/Documentation/memory-barriers.txt Also see my report against GNOME: https://gitlab.gnome.org/GNOME/glib/issues/1449 Note that this is irrelevant if C++11-like atomic ops are available.