)]}' { "log": [ { "commit": "97b2985fc32281226783f5215eb7bcb67e6f9000", "tree": "96234bb31600be42be2f761c8625cfc2cf45532c", "parents": [ "d122dd25e60de6b44c61320c7409fa7b19fa6816" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Wed Feb 28 12:22:23 2024 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Wed Feb 28 13:43:08 2024 +0000" }, "message": "libabigail: replace remaining metadata files with a README tombstone\n\nBug: 228843807\nBug: 240260681\nChange-Id: Ib5e2a58717ab8e4110f3102a91b6c04476ade465\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "d122dd25e60de6b44c61320c7409fa7b19fa6816", "tree": "229af530bcaf5d3105fbd4022efec027b325df25", "parents": [ "cb5f500fd5c840d4d143a8cacaa3f58562c924df" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Feb 27 12:39:45 2024 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Feb 27 12:39:45 2024 +0000" }, "message": "libabigail: gut project prior to removal\n\nBug: 228843807\nBug: 240260681\nChange-Id: I6071704329d97ac7d3c6736b0c73c31b9dfce2bf\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "cb5f500fd5c840d4d143a8cacaa3f58562c924df", "tree": "cda7ae2da18bccf0632c7f06af48f9f103aab43f", "parents": [ "0a2b2bba9d1da6ab751a1c25e6c1a738145fc41a" ], "author": { "name": "Matthias Maennich", "email": "maennich@google.com", "time": "Tue Jun 06 09:51:34 2023 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 12:02:43 2023 +0000" }, "message": "symtab reader: fix symtab iterator to support C++20\n\nInheriting from std::vector::iterator causes the type to advertise\nitself as a contiguous iterator. This causes a compilation error in\nnewer versions of libc++ that try to use contiguous-iterator-specific\noptimizations in those situations. Fixed thus by explicitly specifying\nthe interator_concept tag.\n\n\t* abg-symtab-reader.h (symtab_iterator): Specify\n\t iterator_concept as forward_iterator to support C++20 compilation.\n\nChange-Id: I51b76a97bf8aa1158f73eb6252d8669c84e0b5c3\nSigned-off-by: Matthias Maennich \u003cmaennich@google.com\u003e\n" }, { "commit": "0a2b2bba9d1da6ab751a1c25e6c1a738145fc41a", "tree": "e59daa2ee6b2ea31ec70f9423bd9a1df7e570608", "parents": [ "e28c02f1a6213eef294b06a9d9183e1890ca69de" ], "author": { "name": "Matthias Maennich", "email": "maennich@google.com", "time": "Tue Jun 06 09:51:33 2023 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 12:02:36 2023 +0000" }, "message": "symtab reader: use C++11 `using` syntax instead of typedefs\n\nThat is to increase readability and to incrementally modernize the code base.\n\n\t* abg-symtab-reader.h: replace typedefs by corresponding using\n\t declarations.\n\nChange-Id: Iafb1e83e0ca8b6d27ade94b3cd7ebb8c2540393a\nSigned-off-by: Matthias Maennich \u003cmaennich@google.com\u003e\n" }, { "commit": "e28c02f1a6213eef294b06a9d9183e1890ca69de", "tree": "61fa3ddcfc2d9f85838ec01515624c2b74e8aa75", "parents": [ "ab90424119637248436158c491c15056dd94c411" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Aug 31 16:59:15 2023 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 12:02:30 2023 +0000" }, "message": "operator!\u003d fixes for C++-20\n\nWithout these changes, more recent versions of Clang will start to\nemit diagnostics:\n\nsrc/abg-ir.cc:15407:13: error: member \u0027operator!\u003d\u0027 found in multiple base classes of different types\n 15407 | return *l \u003d\u003d *r;\n | ^\nsrc/abg-ir.cc:14123:12: note: member found by ambiguous name lookup\n 14123 | type_base::operator!\u003d(const type_base\u0026 other) const\n | ^\nsrc/abg-ir.cc:5162:12: note: member found by ambiguous name lookup\n 5162 | decl_base::operator!\u003d(const decl_base\u0026 other) const\n | ^\n\nThis fix was contributed by Ilya Biryukov.\n\n\t* include/abg-ir.h\n\t(qualified_typedef): Add definition of operator!\u003d.\n\t(pointer_type_def): Likewise.\n\t(reference_type_def): Likewise.\n\t(class_or_union): Likewise.\n\nBug: 295399968\nReported-by: Ilya Biryukov \u003cibiryukov@google.com\u003e\nChange-Id: Ic86fcb51866f4f86fcc8e7181e3b7577adbf918d\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\nSigned-off-by: Dodji Seketeli \u003cdodji@redhat.com\u003e\n" }, { "commit": "ab90424119637248436158c491c15056dd94c411", "tree": "2e1871d35ecac6bb0ea5a7813eb6535bc143c8d8", "parents": [ "190664937e4b3270192691557597656f0fde44f7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 11:54:56 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 12:01:54 2023 +0000" }, "message": "Revert \"abg-ir.h: add some operator!\u003d definitions\"\n\nThis reverts commit 190664937e4b3270192691557597656f0fde44f7.\n\nReason for revert: Replace with upstream commit\n\nBug: 295399968\nChange-Id: I105f03a6c2b59dee55193d23b48c7d07cd04a333\n" }, { "commit": "190664937e4b3270192691557597656f0fde44f7", "tree": "9715b198c679355afbfe08c4043f2677bb66089f", "parents": [ "354f728db665a9d34263c53b0a89d1ab5dc73cd6" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 10:32:07 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 10:52:58 2023 +0000" }, "message": "abg-ir.h: add some operator!\u003d definitions\n\nThis prevents ambiguous lookup failures with more recent compiler /\nlanguage versions.\n\n\t* include/abg-ir.h: (qualified_type_def) Add operator!\u003d.\n\t(pointer_type_def): Likewise.\n\t(reference_type_def): Likewise.\n\t(class_or_union): Likewise.\n\nBug: 295399968\nChange-Id: I9019e4469ee159a9f6d927512d2639386102cd70\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "354f728db665a9d34263c53b0a89d1ab5dc73cd6", "tree": "2e1871d35ecac6bb0ea5a7813eb6535bc143c8d8", "parents": [ "3497ec85c0360e8eb32369c37b92ebd2fa889e4f" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 10:05:46 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Nov 14 10:13:41 2023 +0000" }, "message": "remove abitidy\n\nIts watch has ended.\n\nBug: 279931086\nChange-Id: I8eb59f25a0356c6292c322d0c3c621a7cd5b35cd\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "3497ec85c0360e8eb32369c37b92ebd2fa889e4f", "tree": "2c9c65e6300ffbeabfdf6b9533845d32a5e112b3", "parents": [ "c0d418081e5cab43d5266ca2e01e6e876b641be3", "523589819d85e45573323d93708cb677185f2480" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu May 04 11:55:42 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu May 04 11:55:42 2023 +0000" }, "message": "abitidy: fix data member deduplication element filter am: 523589819d\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2575831\n\nChange-Id: I09ba9039a606c10fa93571272827abbe225e9123\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "523589819d85e45573323d93708cb677185f2480", "tree": "2c9c65e6300ffbeabfdf6b9533845d32a5e112b3", "parents": [ "9f2d66a4e204b7ba5452d030ade601f238f62f0e" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue May 02 13:45:51 2023 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue May 02 13:49:46 2023 +0100" }, "message": "abitidy: fix data member deduplication element filter\n\nThe code now restricts its attention to `class-decl` and `union-decl`\nelements, as originally intended, instead of checking every element.\n\nBug: 266148118\nChange-Id: Ib8b9d0bc83996eadf38b2aacf734238913d04590\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "c0d418081e5cab43d5266ca2e01e6e876b641be3", "tree": "662b5df887b632bdb085e4dd12bdb02c462285b0", "parents": [ "52b1d2bebb6329357f6dc4c8417456e94a8f9200", "9f2d66a4e204b7ba5452d030ade601f238f62f0e" ], "author": { "name": "Matthias Männich", "email": "maennich@google.com", "time": "Wed Feb 22 01:21:25 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Feb 22 01:21:25 2023 +0000" }, "message": "Revert \"strip_useless_const_qualification: leave const void alone\" am: 51c86db89d am: 9f2d66a4e2\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2446225\n\nChange-Id: I105ddc2145efc40c3ebe8fab7a0889873e006928\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "9f2d66a4e204b7ba5452d030ade601f238f62f0e", "tree": "662b5df887b632bdb085e4dd12bdb02c462285b0", "parents": [ "49631017a6ab6b17b351c6e4566cf717f1dae42d", "51c86db89dd38e39a72dbb80414f08e2c8daf1b7" ], "author": { "name": "Matthias Männich", "email": "maennich@google.com", "time": "Tue Feb 21 23:00:48 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Feb 21 23:00:48 2023 +0000" }, "message": "Revert \"strip_useless_const_qualification: leave const void alone\" am: 51c86db89d\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2446225\n\nChange-Id: I50480d2d967ec1b906fd43d7d8d7be51ec3c11d8\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "51c86db89dd38e39a72dbb80414f08e2c8daf1b7", "tree": "662b5df887b632bdb085e4dd12bdb02c462285b0", "parents": [ "500c5b730574f3175d23f2939a02b9c0dd8340be" ], "author": { "name": "Matthias Männich", "email": "maennich@google.com", "time": "Tue Feb 21 14:51:43 2023 +0000" }, "committer": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Tue Feb 21 16:53:49 2023 +0000" }, "message": "Revert \"strip_useless_const_qualification: leave const void alone\"\n\nThis reverts commit 2964dd6df798f9bc0ded6eb13579082c5b3a97b9.\n\nReason for revert:\n\nThis change brought a lot of instability on generation of const void*\nfrom libabigail. Also we now have option in stgdiff to compare libabiail\nand STG output ignoring const qualifiers, so the reason, why this change\nwas committed in the first place, has disappeared.\n\nChange-Id: I916d34b02c51b83ab4c0d6d961b59761b1bf1390\n" }, { "commit": "52b1d2bebb6329357f6dc4c8417456e94a8f9200", "tree": "69a013ee4366f78ac2b990644f9aba4ac5b1d39f", "parents": [ "54d0a47e3e5d3ad11aa3171891c43898ba3840d0", "49631017a6ab6b17b351c6e4566cf717f1dae42d" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Mon Jan 30 22:18:35 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 30 22:18:35 2023 +0000" }, "message": "symtab: fix getting CRC in relocatable modules am: 500c5b7305 am: 49631017a6\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2400497\n\nChange-Id: I1041697902eaaab0d83c21473d00bd8a5dbe4902\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "49631017a6ab6b17b351c6e4566cf717f1dae42d", "tree": "69a013ee4366f78ac2b990644f9aba4ac5b1d39f", "parents": [ "14061861031d2cd0b8f857b4fde606a790574f16", "500c5b730574f3175d23f2939a02b9c0dd8340be" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Mon Jan 30 21:39:20 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 30 21:39:20 2023 +0000" }, "message": "symtab: fix getting CRC in relocatable modules am: 500c5b7305\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2400497\n\nChange-Id: I4796614eb697b57b60fe3b643b9c3d919170ef24\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "500c5b730574f3175d23f2939a02b9c0dd8340be", "tree": "69a013ee4366f78ac2b990644f9aba4ac5b1d39f", "parents": [ "edc8f44d4fe4b9bef34bb823f2fd295606b48082" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Fri Jan 27 23:42:03 2023 +0000" }, "committer": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Fri Jan 27 23:51:23 2023 +0000" }, "message": "symtab: fix getting CRC in relocatable modules\n\nIn ELF with ET_REL type symbol value holds not absolute but relative to\nsection value. This patch applies adjustment to the address, used in CRC\nvalue extraction.\n\n\t* src/abg-elf-helpers.cc (get_crc_for_symbol): Rename\n\tcrc_symbol_value to crc_symbol_address and adjust it for\n\trelocatable ELF types.\n\nChange-Id: Iff28e7eaf2a1c95630116ad5fdf83ea007aeeba5\nSigned-off-by: Aleksei Vetrov \u003cvvvvvv@google.com\u003e\n" }, { "commit": "54d0a47e3e5d3ad11aa3171891c43898ba3840d0", "tree": "f18db0a7cf558f48d67ce0abfad3774b77f69472", "parents": [ "eb8b447aae9a2844cd2a1a353f967b8846c5f5b0", "14061861031d2cd0b8f857b4fde606a790574f16" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 23 10:32:30 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 23 10:32:30 2023 +0000" }, "message": "abitidy: remove excess members if requested am: edc8f44d4f am: 1406186103\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2393799\n\nChange-Id: I70b11e182122edb8ee4b96b9f5a1e350ad88a412\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "14061861031d2cd0b8f857b4fde606a790574f16", "tree": "f18db0a7cf558f48d67ce0abfad3774b77f69472", "parents": [ "d450a82addac4565531762fdc60cb3251870b8b6", "edc8f44d4fe4b9bef34bb823f2fd295606b48082" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 23 09:51:50 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 23 09:51:50 2023 +0000" }, "message": "abitidy: remove excess members if requested am: edc8f44d4f\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2393799\n\nChange-Id: Ia83b7a135f85cf24ed3676df29e2a560bea29bd5\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "edc8f44d4fe4b9bef34bb823f2fd295606b48082", "tree": "f18db0a7cf558f48d67ce0abfad3774b77f69472", "parents": [ "112007828a90d48cea5552eeeb5a4787731ecdcd" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Fri Jan 20 15:03:24 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Fri Jan 20 15:52:02 2023 +0000" }, "message": "abitidy: remove excess members if requested\n\nVery, very occasionally, abidw emits a duplicate data-member. abitidy\nnow detects and reports these to stderr unconditionally.\n\nThe new option -x | --eliminate-excess-members, implied by --all,\nremoves such duplicates.\n\nBug: 266148118\nChange-Id: I58767a1673997d271a1ed41d84593d80ace20ac3\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "eb8b447aae9a2844cd2a1a353f967b8846c5f5b0", "tree": "595e2663496f0c2c9919ca5873aed076b6468bbf", "parents": [ "2eaefd620e4544fce40f0d9df21ff4f566f6c390", "d450a82addac4565531762fdc60cb3251870b8b6" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Jan 17 20:55:58 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Jan 17 20:55:58 2023 +0000" }, "message": "Disable all integral type name interpretation am: 112007828a am: d450a82add\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2389035\n\nChange-Id: If40136c9e64a91744e1e30e87630c8e30bee1e9a\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "2eaefd620e4544fce40f0d9df21ff4f566f6c390", "tree": "2376b8e7fd70db64aaf72552c639bce819fb966c", "parents": [ "44408b16c46295552d1dc0835975de52a071582a", "ecf970f509863643499c9fb33a386c727d90154a" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Jan 17 20:55:55 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Jan 17 20:55:55 2023 +0000" }, "message": "strip_useless_const_qualification: leave const void alone am: 2964dd6df7 am: ecf970f509\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2389034\n\nChange-Id: I65c9bd5e93016d734709bd8942cf565d4b0afa3c\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "d450a82addac4565531762fdc60cb3251870b8b6", "tree": "595e2663496f0c2c9919ca5873aed076b6468bbf", "parents": [ "ecf970f509863643499c9fb33a386c727d90154a", "112007828a90d48cea5552eeeb5a4787731ecdcd" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Jan 17 19:45:21 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Jan 17 19:45:21 2023 +0000" }, "message": "Disable all integral type name interpretation am: 112007828a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2389035\n\nChange-Id: Id7212cab37218f22483131c4f9137f4a1c2737f6\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "ecf970f509863643499c9fb33a386c727d90154a", "tree": "2376b8e7fd70db64aaf72552c639bce819fb966c", "parents": [ "6fb28acd9aaf99d90504f2f454139ca55ab42fa6", "2964dd6df798f9bc0ded6eb13579082c5b3a97b9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Jan 17 19:45:15 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Jan 17 19:45:15 2023 +0000" }, "message": "strip_useless_const_qualification: leave const void alone am: 2964dd6df7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2389034\n\nChange-Id: Icbb854b1ffcb87cff2e6f1b001132d00b8e51191\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "112007828a90d48cea5552eeeb5a4787731ecdcd", "tree": "595e2663496f0c2c9919ca5873aed076b6468bbf", "parents": [ "2964dd6df798f9bc0ded6eb13579082c5b3a97b9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 16 11:30:43 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 16 17:29:39 2023 +0000" }, "message": "Disable all integral type name interpretation\n\nlibabigail currently canonicalises the names of primitive types,\nwhich are referred to as integral types in the code base.\n\nFor example, DWARF \"short int\" becomes ABI XML \"short\" but \"unsigned\nlong long int\" remains unchanged, which may not have been intentional.\n\nThe STG tools do not interpret type names. This makes cross diffs a bit\nnoisy. We could:\n\n* implement similar functionality to normalise names in STG\n * after DWARF processing and serialisation\n * or before deserialisation and comparison\n* or add an option to ignore type name differences\n* or make this feature of libabigail optional\n* or just disable it\n\nIn any case, experiments revealed that recent GCC and Clang compilers\nemit self-consistent names (and each differently from libabigail).\n\nGCC style (very regular):\n\n* `short int`\n* `unsigned int`\n* `long unsigned int`\n* `long double`\n\nClang style (less regular):\n\n* `short`\n* `unsigned int`\n* `unsigned long`\n* `long double`\n\nHere we do the expedient thing and just disable the canonicalisation.\n\n\t* src/abg-ir.cc (parse_integral_type): always return false\n\t* tests/data/test-annotate/libtest23.so.abi: Refresh test.\n\t* tests/data/test-annotate/libtest24-drop-fns-2.so.abi:\n\tLikewise.\n\t* tests/data/test-annotate/libtest24-drop-fns.so.abi:\n\tLikewise.\n\t* tests/data/test-annotate/test13-pr18894.so.abi: Likewise.\n\t* tests/data/test-annotate/test14-pr18893.so.abi: Likewise.\n\t* tests/data/test-annotate/test15-pr18892.so.abi: Likewise.\n\t* tests/data/test-annotate/test17-pr19027.so.abi: Likewise.\n\t* tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:\n\tLikewise.\n\t* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:\n\tLikewise.\n\t* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:\n\tLikewise.\n\t* tests/data/test-annotate/test21-pr19092.so.abi: Likewise.\n\t* tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0-report-0.txt:\n\tLikewise.\n\t* tests/data/test-diff-dwarf-abixml/test0-pr19026-libvtkIOSQL-6.1.so.1-report-0.txt:\n\tLikewise.\n\t* tests/data/test-diff-dwarf/PR25058-liblttng-ctl-report-1.txt:\n\tLikewise.\n\t* tests/data/test-diff-filter/test30-pr18904-rvalueref-report0.txt:\n\tLikewise.\n\t* tests/data/test-diff-filter/test30-pr18904-rvalueref-report1.txt:\n\tLikewise.\n\t* tests/data/test-diff-filter/test30-pr18904-rvalueref-report2.txt:\n\tLikewise.\n\t* tests/data/test-diff-filter/test33-report-0.txt: Likewise.\n\t* tests/data/test-diff-filter/test34-report-0.txt: Likewise.\n\t* tests/data/test-diff-pkg/libsigc++-2.0-0c2a_2.4.0-1_amd64--libsigc++-2.0-0v5_2.4.1-1ubuntu2_amd64-report-0.txt:\n\tLikewise.\n\t* tests/data/test-diff-pkg/libxcrypt-4.1.1-6.el8.x86_64--libxcrypt-compat-4.4.18-3.el9.x86_64-report-1.txt:\n\tLikewise.\n\t* tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-2.txt:\n\tLikewise.\n\t* tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.\n\t* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/libtest23.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/libtest24-drop-fns.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test-libaaudio.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test-libandroid.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test11-pr18828.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test13-pr18894.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test14-pr18893.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test15-pr18892.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test17-pr19027.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.\n\t* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:\n\tLikewise.\n\t* tests/data/test-read-dwarf/test9-pr18818-clang.so.abi:\n\tLikewise.\n\nChange-Id: If55f9e3351a2612ff176f7f663373bb658d60bfd\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "2964dd6df798f9bc0ded6eb13579082c5b3a97b9", "tree": "2376b8e7fd70db64aaf72552c639bce819fb966c", "parents": [ "1633ecc9857df1fe88db42886f95a45cd78cbee9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 16 11:26:54 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 16 16:59:39 2023 +0000" }, "message": "strip_useless_const_qualification: leave const void alone\n\nThe unconditional transformation of \"const void\" to \"void\" does not\nseem to be the right thing to do. The usual context is \"const void *\",\ni.e, readonly memory.\n\n\t* src/abg-ir.cc (strip_useless_const_qualification): Do not\n\tstrip const qualifier from const void.\n\ttests/data/test-annotate/libtest24-drop-fns-2.so.abi:\n\tLikewise.\n\ttests/data/test-annotate/libtest24-drop-fns.so.abi: Likewise.\n\ttests/data/test-annotate/test1.abi: Likewise.\n\ttests/data/test-annotate/test13-pr18894.so.abi: Likewise.\n\ttests/data/test-annotate/test14-pr18893.so.abi: Likewise.\n\ttests/data/test-annotate/test15-pr18892.so.abi: Likewise.\n\ttests/data/test-annotate/test17-pr19027.so.abi: Likewise.\n\ttests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:\n\tLikewise.\n\ttests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:\n\tLikewise.\n\ttests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:\n\tLikewise.\n\ttests/data/test-annotate/test21-pr19092.so.abi: Likewise.\n\ttests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0-report-0.txt:\n\tLikewise.\n\ttests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-2.txt:\n\tLikewise.\n\ttests/data/test-diff-pkg/tbb-4.1-9.20130314.fc22.x86_64--tbb-4.3-3.20141204.fc23.x86_64-report-0.txt:\n\tLikewise.\n\ttests/data/test-diff-pkg/tbb-4.1-9.20130314.fc22.x86_64--tbb-4.3-3.20141204.fc23.x86_64-report-1.txt:\n\tLikewise.\n\ttests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/PR22122-libftdc.so.abi: Likewise.\n\ttests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.\n\ttests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/libtest24-drop-fns.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test-libaaudio.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test-libandroid.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test1.abi: Likewise.\n\ttests/data/test-read-dwarf/test1.hash.abi: Likewise.\n\ttests/data/test-read-dwarf/test10-pr18818-gcc.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test11-pr18828.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test13-pr18894.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test14-pr18893.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test15-pr18892.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test17-pr19027.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.\n\ttests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:\n\tLikewise.\n\ttests/data/test-read-dwarf/test9-pr18818-clang.so.abi:\n\tLikewise.\n\nChange-Id: Iec30b6e9d1e6af94c1ef2024ee9dae72aff5f19e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "44408b16c46295552d1dc0835975de52a071582a", "tree": "ae4140a60631dfa2fed44cce85dfe4ee381784a3", "parents": [ "72ce09f1695c5a657ac203fa19eeaff3e70d6d55", "6fb28acd9aaf99d90504f2f454139ca55ab42fa6" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Jan 12 20:05:35 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jan 12 20:05:35 2023 +0000" }, "message": "[automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9467136 am: 6fb28acd9a -s ours\n\nam skip reason: Merged-In Ic6ebbeef9109f7f5298846f13780b54e97c9503f with SHA-1 7fc9212b9a is already in history\n\nOriginal change: https://googleplex-android-review.googlesource.com/c/platform/external/libabigail/+/20948066\n\nChange-Id: I2354a68f33c25c84cbe458bc3679d54e28de97d0\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6fb28acd9aaf99d90504f2f454139ca55ab42fa6", "tree": "ae4140a60631dfa2fed44cce85dfe4ee381784a3", "parents": [ "3eee8835d2a8d2e263b61f31024f44426a2c249a", "7fc9212b9af0f97f44bfb8807c15b6e3adf84ed0" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Jan 11 22:39:43 2023 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Jan 12 09:36:19 2023 -0800" }, "message": "Merge tm-qpr-dev-plus-aosp-without-vendor@9467136\n\nBug: 264720040\nMerged-In: Ic6ebbeef9109f7f5298846f13780b54e97c9503f\nChange-Id: I03121534906305bac91a67dbfeb55083d3dc64fe\n" }, { "commit": "72ce09f1695c5a657ac203fa19eeaff3e70d6d55", "tree": "ae4140a60631dfa2fed44cce85dfe4ee381784a3", "parents": [ "f16169ae9ec42aca0578be836e8054cb08864ce1", "3eee8835d2a8d2e263b61f31024f44426a2c249a" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:45:37 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:45:37 2023 +0000" }, "message": "Revert \"abitidy: per-corpus symbol/alias handling\" am: 1633ecc985 am: 3eee8835d2\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2337665\n\nChange-Id: Iba9c1eb13fd8c73a93db595ffc3ee3efd6652653\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f16169ae9ec42aca0578be836e8054cb08864ce1", "tree": "aa7e4ce2c3bc7f97c790fb187866f3e94e0d05f2", "parents": [ "b3d5b643d04dd98a43221b1945d42e5f559e8dc6", "799643eb9a1be069bd8ccdb2c3c476842d0b1d9f" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:45:36 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:45:36 2023 +0000" }, "message": "DWARF reader: avoid C++20 operator!\u003d overload ambiguity am: ecd56004f4 am: 799643eb9a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2379789\n\nChange-Id: I810d84d22c2dba2660fba312db56ea2af58d13cf\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "b3d5b643d04dd98a43221b1945d42e5f559e8dc6", "tree": "aa22a04bf0f594cf546d57a211083b7af0c4aa67", "parents": [ "7fc9212b9af0f97f44bfb8807c15b6e3adf84ed0", "bad42bbf87919de2047d5a7ef57d5880b9b0a54d" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:45:34 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:45:34 2023 +0000" }, "message": "abitidy: include iomanip header am: ea94d3dbe7 am: bad42bbf87\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2379788\n\nChange-Id: Ie3019ec9ae81de0cf2e59295dbdcfa34dd00f7e8\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3eee8835d2a8d2e263b61f31024f44426a2c249a", "tree": "ae4140a60631dfa2fed44cce85dfe4ee381784a3", "parents": [ "799643eb9a1be069bd8ccdb2c3c476842d0b1d9f", "1633ecc9857df1fe88db42886f95a45cd78cbee9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:13:53 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:13:53 2023 +0000" }, "message": "Revert \"abitidy: per-corpus symbol/alias handling\" am: 1633ecc985\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2337665\n\nChange-Id: I34795266baccd35ef4300b0503a14032cfe18467\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "799643eb9a1be069bd8ccdb2c3c476842d0b1d9f", "tree": "aa7e4ce2c3bc7f97c790fb187866f3e94e0d05f2", "parents": [ "bad42bbf87919de2047d5a7ef57d5880b9b0a54d", "ecd56004f427063752924e0c5572d9507b828fa9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:13:52 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:13:52 2023 +0000" }, "message": "DWARF reader: avoid C++20 operator!\u003d overload ambiguity am: ecd56004f4\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2379789\n\nChange-Id: Ic7ca7265310f968d1c91632caf14f8aca2275e8b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "bad42bbf87919de2047d5a7ef57d5880b9b0a54d", "tree": "aa22a04bf0f594cf546d57a211083b7af0c4aa67", "parents": [ "1fbb0b2106e40571297d8eba2c96e579c3fed998", "ea94d3dbe705a56e9fc2c9c49a5720dd191c19e3" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 11:13:51 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Jan 09 11:13:51 2023 +0000" }, "message": "abitidy: include iomanip header am: ea94d3dbe7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2379788\n\nChange-Id: I97c7604e9bc9e017c7ae574555e336da39864ee3\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1633ecc9857df1fe88db42886f95a45cd78cbee9", "tree": "ae4140a60631dfa2fed44cce85dfe4ee381784a3", "parents": [ "ecd56004f427063752924e0c5572d9507b828fa9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Fri Dec 09 10:29:32 2022 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 09:22:47 2023 +0000" }, "message": "Revert \"abitidy: per-corpus symbol/alias handling\"\n\nWas not a good idea.\n\nThis reverts commit 922d5b603ab6ec948076a2a2584cc0b1de0e2d06.\n\nChange-Id: I41f3acbce905f5dea71754de7f462e633b83069a\n" }, { "commit": "ecd56004f427063752924e0c5572d9507b828fa9", "tree": "aa7e4ce2c3bc7f97c790fb187866f3e94e0d05f2", "parents": [ "ea94d3dbe705a56e9fc2c9c49a5720dd191c19e3" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 09:08:25 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 09:08:25 2023 +0000" }, "message": "DWARF reader: avoid C++20 operator!\u003d overload ambiguity\n\nC++20 automatically generates overloads for certain comparison\noperators based on others and this can create ambiguity with older\ncode. The type expr_result has various operators defined and comparing\nexpr_result !\u003d int becomes ambiguous.\n\nThis change just avoids this comparison by extracting the underlying\nvalue, rather than making changes to the type itself. There should be\nno change in behaviour and no tests are affected.\n\n\t* (src/abg-dwarf-reader.cc) op_is_control_flow: In the\n\tDW_OP_bra case, when testing the popped value, use the\n\texpr_result\u0027s const_value explicitly.\n\nChange-Id: Ie25c0fea371a32483f2b4e20bd39d2448eb16cb4\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "ea94d3dbe705a56e9fc2c9c49a5720dd191c19e3", "tree": "aa22a04bf0f594cf546d57a211083b7af0c4aa67", "parents": [ "755ff064363704f2391194aa5a8802b65244cde5" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 09:01:01 2023 +0000" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jan 09 09:03:55 2023 +0000" }, "message": "abitidy: include iomanip header\n\nThis was missing.\n\nChange-Id: I5f2eef6797720d6a1f26352b1a2774434c03b52e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "7fc9212b9af0f97f44bfb8807c15b6e3adf84ed0", "tree": "f762646441982a67342620c3a9a7e9648dd1c853", "parents": [ "5e935f896372d512f562bf0c65736552b0bc05af", "1fbb0b2106e40571297d8eba2c96e579c3fed998" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jan 05 17:09:36 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jan 05 17:09:36 2023 +0000" }, "message": "Restrict header visibility again am: 755ff06436 am: 1fbb0b2106\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2337562\n\nChange-Id: Ic6ebbeef9109f7f5298846f13780b54e97c9503f\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1fbb0b2106e40571297d8eba2c96e579c3fed998", "tree": "f762646441982a67342620c3a9a7e9648dd1c853", "parents": [ "e815751a9d070feeaec5c50558840e0b689c2140", "755ff064363704f2391194aa5a8802b65244cde5" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jan 05 16:39:21 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jan 05 16:39:21 2023 +0000" }, "message": "Restrict header visibility again am: 755ff06436\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2337562\n\nChange-Id: Ie4d1892526d7df7e33eb4991ff5e475ed2f8536b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "755ff064363704f2391194aa5a8802b65244cde5", "tree": "f762646441982a67342620c3a9a7e9648dd1c853", "parents": [ "e815751a9d070feeaec5c50558840e0b689c2140" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Tue Jul 19 13:49:25 2022 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jan 05 15:07:52 2023 +0000" }, "message": "Restrict header visibility again\n\nSTG no longer depends on libabigail (at all). Default visibility is\nreverted back to private and the target libabigail_src_headers is\nremoved.\n\nThis change mostly reverts 42c7a4e0f3de but leaves the include\ndirectory as part of the libabigail\u0027s exported headers.\n\nChange-Id: Ic89dc7049c15ce98729cfcdcae02ae9f6626f0c5\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n" }, { "commit": "5e935f896372d512f562bf0c65736552b0bc05af", "tree": "5be8b02d63f982c303913b767e031e694f2b2b37", "parents": [ "5810e65154ed982985d91c5e993db07047645312", "e815751a9d070feeaec5c50558840e0b689c2140" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Mon Nov 21 15:38:43 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 21 15:38:43 2022 +0000" }, "message": "symtab: add support for CRC values from __kcrctab am: ad0feffef0 am: e815751a9d\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2300221\n\nChange-Id: I97a5171cf3fcd16e894f6bec6b01c5badad8227e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "5810e65154ed982985d91c5e993db07047645312", "tree": "bb1ef4691ebf637640c11534936f7c5ae9ec1e2d", "parents": [ "a78095f83b33255a16177bf8c581a939ec81d9bf", "10bad540b86bef56ce2a2183ad7df172a6811bc9" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Nov 21 15:38:41 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 21 15:38:41 2022 +0000" }, "message": "Narrow Linux symbol CRCs to 32 bits am: 9fc8ac965a am: 10bad540b8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2300220\n\nChange-Id: I35443274518f98fba3ef8b15a1913c3064533346\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e815751a9d070feeaec5c50558840e0b689c2140", "tree": "5be8b02d63f982c303913b767e031e694f2b2b37", "parents": [ "10bad540b86bef56ce2a2183ad7df172a6811bc9", "ad0feffef0707f82041ecdc0e65c950a0e063dde" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Mon Nov 21 14:45:57 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 21 14:45:57 2022 +0000" }, "message": "symtab: add support for CRC values from __kcrctab am: ad0feffef0\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2300221\n\nChange-Id: I8fbec7beb08e0873553f216dae311ee148df5c49\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "10bad540b86bef56ce2a2183ad7df172a6811bc9", "tree": "bb1ef4691ebf637640c11534936f7c5ae9ec1e2d", "parents": [ "4847e566f5acf86720477a70663f8c0523cfd264", "9fc8ac965a5196c80f51a319db6a5225f676446f" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Nov 21 14:45:55 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 21 14:45:55 2022 +0000" }, "message": "Narrow Linux symbol CRCs to 32 bits am: 9fc8ac965a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2300220\n\nChange-Id: I4c215980cd0c482d1a500a0fd4cbcb899fd84275\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "ad0feffef0707f82041ecdc0e65c950a0e063dde", "tree": "5be8b02d63f982c303913b767e031e694f2b2b37", "parents": [ "9fc8ac965a5196c80f51a319db6a5225f676446f" ], "author": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Fri Nov 18 09:09:07 2022 +0000" }, "committer": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Fri Nov 18 16:19:43 2022 +0000" }, "message": "symtab: add support for CRC values from __kcrctab\n\nNew kernels changed the format of storing CRC values from absolute\nsymbol value to the address in __kcrctab or __kcrctab_gpl section.\nThis change adds support for CRC values described in this format.\n\n\t* src/abg-elf-helpers.h (get_crc_for_symbol): Defined new\n\thelper function to extract CRC from ELF symbol.\n\t* src/abg-elf-helpers.cc (get_crc_for_symbol): Implemented this\n\tfunction with support of old and new CRC values format.\n\t* src/abg-symtab-reader.cc (symtab::load_): Used the new\n\tfunction when building CRC values map.\n\nChange-Id: I7de5c737d5caaef0c5b7b2ea0d448368889a16be\nSigned-off-by: Aleksei Vetrov \u003cvvvvvv@google.com\u003e\nSigned-off-by: Dodji Seketeli \u003cdodji@redhat.com\u003e\n(cherry picked from commit c6ac7db457a36939efe81e2e5794d8892344a8db)\n" }, { "commit": "9fc8ac965a5196c80f51a319db6a5225f676446f", "tree": "bb1ef4691ebf637640c11534936f7c5ae9ec1e2d", "parents": [ "977cb756cc016ab31df42d950446ed2edc70c4c7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Fri Nov 11 13:21:51 2022 +0000" }, "committer": { "name": "Aleksei Vetrov", "email": "vvvvvv@google.com", "time": "Thu Nov 17 16:24:46 2022 +0000" }, "message": "Narrow Linux symbol CRCs to 32 bits\n\nMODVERSIONS CRCs are 32-bit hashes of strings representing C type\nelements or typed symbols. The hashes are calculated using a 32-bit\nCRC, hence the name. The kernel module loading code (implicitly)\ntruncates any provided CRC value to 32 bits before comparing it with\nanything.\n\nWhen support was added to libabigail, values up to 64 bits wide were\nsupported. This change narrows libabigail\u0027s concept of Linux CRC to 32\nbits. No tests are affected.\n\n\t* include/abg-ir.h (elf_symbol::elf_symbol): Change CRC type\n\tfrom optional\u003cuint64_t\u003e to optional\u003cuint32_t\u003e.\n\t(elf_symbol::create): Likewise.\n\t(elf_symbol::get_crc): Likewise.\n\t(elf_symbol::set_crc): Likewise.\n\t* src/abg-ir.cc (elf_symbol::priv) Change CRC type from\n\toptional\u003cuint64_t\u003e to optional\u003cuint32_t\u003e.\n\t(elf_symbol::priv::priv): Likewise.\n\t(elf_symbol::elf_symbol): Likewise.\n\t(elf_symbol::create): Likewise.\n\t(elf_symbol::get_crc): Likewise.\n\t(elf_symbol::set_crc): Likewise.\n\t* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol):\n\tChange CRC type from optional\u003cuint64_t\u003e to\n\toptional\u003cuint32_t\u003e.\n\t* src/abg-symtab-reader.cc (symtab::load_): Change crc_values\n\tvalue type from uint64_t to uint32_t.\n\nChange-Id: I388b423d7d29946ff2d7e7bb574caac222a853a4\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n(cherry picked from commit 3cb34e65df668c1c107b06a9dc378713e527184b)\n" }, { "commit": "a78095f83b33255a16177bf8c581a939ec81d9bf", "tree": "6c3c1901d2229544b4e1b084d557ee6cdb28f611", "parents": [ "300c25cee61bb58badafe500cabd58e7a51d2f52", "4847e566f5acf86720477a70663f8c0523cfd264" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 11:20:35 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 11:20:35 2022 +0000" }, "message": "add Linux kernel symbol namespace support am: 977cb756cc am: 4847e566f5\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252145\n\nChange-Id: I11d807cdef5413d10c5d7675a88feab3c73e1d0b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "300c25cee61bb58badafe500cabd58e7a51d2f52", "tree": "d418b7a4e56f7898434e88ecfcfc369d1abf278e", "parents": [ "3cf42fc24109db6d432fce0fc02bb5643317aab9", "a8a3fc77aba7034d8b86f51eef797dd89b6c3699" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 11:20:34 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 11:20:34 2022 +0000" }, "message": "Linux symbol CRCs: support 0 and report presence changes am: 2dcbaeb094 am: a8a3fc77ab\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252144\n\nChange-Id: I36748298ebf1ca85e3fdb648f216e98711410fd1\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3cf42fc24109db6d432fce0fc02bb5643317aab9", "tree": "0268365e6d57caa3eb8a504995705b787c078767", "parents": [ "bc9352ad82ab44d5be4b3d991eef64bd25386f88", "0d426765d22dcc80dceeb5f1aa65ac51d36509bb" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 11:20:33 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 11:20:33 2022 +0000" }, "message": "optional: minor improvements am: 5404a2f3df am: 0d426765d2\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252143\n\nChange-Id: I26c2d14a0c12aec9c7219289c24da28893cd9e0b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "bc9352ad82ab44d5be4b3d991eef64bd25386f88", "tree": "2b718a67209e743c1cffbd0cb174400334f8baf3", "parents": [ "95cac85060395b7143acf9fa33720e2754bf6ff2", "cbaa024631fbf72e869fa0cdcb4ef8aeccd89fec" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 11:20:31 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 11:20:31 2022 +0000" }, "message": "crc_changed: eliminate copying of shared_ptr values am: ef3835946a am: cbaa024631\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252142\n\nChange-Id: I580e3c65ff9b143379bde4ffcd06ed3dc8c38eed\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "4847e566f5acf86720477a70663f8c0523cfd264", "tree": "6c3c1901d2229544b4e1b084d557ee6cdb28f611", "parents": [ "a8a3fc77aba7034d8b86f51eef797dd89b6c3699", "977cb756cc016ab31df42d950446ed2edc70c4c7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 10:50:28 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 10:50:28 2022 +0000" }, "message": "add Linux kernel symbol namespace support am: 977cb756cc\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252145\n\nChange-Id: I1f60ce2cf0b0e1064d7d4a25082e1c41eda72339\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a8a3fc77aba7034d8b86f51eef797dd89b6c3699", "tree": "d418b7a4e56f7898434e88ecfcfc369d1abf278e", "parents": [ "0d426765d22dcc80dceeb5f1aa65ac51d36509bb", "2dcbaeb0948f295a76f94fe2a3ee78ade6b199a7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 10:50:27 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 10:50:27 2022 +0000" }, "message": "Linux symbol CRCs: support 0 and report presence changes am: 2dcbaeb094\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252144\n\nChange-Id: I37dff07226a50c754a2bb42aac07c982a9a63f08\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "0d426765d22dcc80dceeb5f1aa65ac51d36509bb", "tree": "0268365e6d57caa3eb8a504995705b787c078767", "parents": [ "cbaa024631fbf72e869fa0cdcb4ef8aeccd89fec", "5404a2f3df092670679307c5a20856e7f0ac12a1" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 10:50:25 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 10:50:25 2022 +0000" }, "message": "optional: minor improvements am: 5404a2f3df\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252143\n\nChange-Id: I16852520dfc7360aea778b73d27768ca67f4c163\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "cbaa024631fbf72e869fa0cdcb4ef8aeccd89fec", "tree": "2b718a67209e743c1cffbd0cb174400334f8baf3", "parents": [ "95cac85060395b7143acf9fa33720e2754bf6ff2", "ef3835946ab8757f4c1363f406d6fb1a200533e7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 10:50:24 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 13 10:50:24 2022 +0000" }, "message": "crc_changed: eliminate copying of shared_ptr values am: ef3835946a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2252142\n\nChange-Id: Ie9776f5acf8557d9e52a562900ffc948db8298fa\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "977cb756cc016ab31df42d950446ed2edc70c4c7", "tree": "6c3c1901d2229544b4e1b084d557ee6cdb28f611", "parents": [ "2dcbaeb0948f295a76f94fe2a3ee78ade6b199a7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jun 13 15:25:33 2022 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 09:34:56 2022 +0100" }, "message": "add Linux kernel symbol namespace support\n\nBug 28954 - add Linux Kernel symbol namespace support\n\nEach Linux kernel symbol can be exported to a specified named\nnamespace or left in the global (nameless) namespace.\n\nOne complexity is that the symbol values which identify a string in\nthe __ksymtab_strings section must be interpretated differently for\nvmlinux and .ko loadable modules as the former has a fixed load\naddress but the latter are relocatable. For vmlinux, the section base\naddress needs to be subtracted to obtain a section-relative offset.\n\nThe global namespace is explicitly represented as the empty string, at\nleast when it comes to the value of __kstrtabns_FOO symbols, but the\ncommon interpretation is that such symbols lack an export namespace.\n\nI would rather not have to make use of \"empty implies missing\" in many\nplaces, so the code here represents namespace as optional\u003cstring\u003e and\nonly the symtab reader cares about empty strings in __ksymtab_strings.\n\n\t* include/abg-ir.h (elf_symbol::elf_symbol): Add ns argument.\n\t(elf_symbol::create): Add ns argument.\n\t(elf_symbol::get_namespace): Declare new function.\n\t(elf_symbol::set_namespace): Declare new function.\n\tand set_namespace.\n\t* src/abg-comp-filter.cc (namespace_changed): Define new\n\thelper functions.\n\t(categorize_harmful_diff_node): Also call namespace_changed().\n\t* src/abg-ir.cc (elf_symbol::priv): Add namespace_ member.\n\t(elf_symbol::priv::priv): Add namespace_ to initialisers.\n\t(elf_symbol::elf_symbol): Take new ns argument and pass it to\n\tpriv constructor.\n\t(elf_symbol::create): Take new ns argument and pass it to\n\telf_symbol constructor.\n\t(elf_symbol::get_namespace): Define new function.\n\t(elf_symbol::set_namespace): Define new function.\n\t* src/abg-reader.cc (build_elf_symbol): If namespace\n\tattribute is present, set symbol namespace.\n\t* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol): If\n\tsymbol namespaces differ, report this.\n\t* src/abg-symtab-reader.cc (symtab::load): Get ELF header to\n\tdistinguish vmlinux from .ko. Try to get __ksymtab_strings\n\tmetadata and data. Use these to look up __kstrtabns_FOO\n\tnamespace entries. Set symbol namespace where found.\n\t* src/abg-writer.cc (write_elf_symbol): Emit namespace\n\tattribute, if symbol has a namespace.\n\t* tests/data/Makefile.am: Add new test files.\n\t* tests/data/test-abidiff/test-namespace-0.xml: New test file.\n\t* tests/data/test-abidiff/test-namespace-1.xml: Likewise\n\t* tests/data/test-abidiff/test-namespace-report.txt: Likewise.\n\t* tests/test-abidiff.cc: Add new test case.\n\nReviewed-by: Matthias Maennich \u003cmaennich@google.com\u003e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n(cherry picked from commit 7e18fc8ad8c00db49e8889f28198bfdcedeb4a03)\nChange-Id: Ibca0490264ba087fb38c96751fb70055c1d5f1b0\n" }, { "commit": "2dcbaeb0948f295a76f94fe2a3ee78ade6b199a7", "tree": "d418b7a4e56f7898434e88ecfcfc369d1abf278e", "parents": [ "5404a2f3df092670679307c5a20856e7f0ac12a1" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jun 13 15:25:32 2022 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 09:31:36 2022 +0100" }, "message": "Linux symbol CRCs: support 0 and report presence changes\n\nThe CRC with value zero was used to mean \"absent\". This can be better\nmodelled using optional.\n\nThis commit makes this change and also tweaks reporting so that\ndisappearing / appearing CRCs are noted. This should be essentially\nimpossible unless CRCs are enabled / disabled altogether but would be\nvery noteworthy otherwise.\n\n\t* include/abg-ir.h (elf_symbol::elf_symbol): Argument crc is\n\tnow an optional defaulted to absent.\n\t(elf_symbol::create): Likewise.\n\t(elf_symbol::get_crc): Now returns an optional uint64_t.\n\t(elf_symbol::set_src): Now takes an optional uint64_t.\n\t* src/abg-comp-filter.cc (crc_changed): Simplify comparison.\n\t* src/abg-ir.cc (elf_symbol::priv): Member crc_ is now an\n\toptional uint64_t.\n\t(elf_symbol::priv::priv): Argument crc is now an optional\n\tuint64_t.\n\t(elf_symbol::elf_symbol): Likewise.\n\t(elf_symbol::create): Argument crc is now an optional uint64_t\n\tand defaults to absent.\n\t(textually_equals): Simplify comparison.\n\t(elf_symbol::get_crc): Now returns an optional uint64_t.\n\t(elf_symbol::set_crc): Now takes an optional uint64_t.\n\t* src/abg-reader.cc (build_elf_symbol): Treat CRC 0 the same\n\tas other CRC values.\n\t* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol):\n\tTreat CRC 0 the same as other CRC values and also report\n\tchanges to CRC presence.\n\t* src/abg-writer.cc (write_elf_symbol): Treat CRC 0 the same\n\tas other CRC values.\n\t* tests/data/Makefile: Remove test-abidiff/test-crc-report.txt\n\tand add test-abidiff/test-crc-report-{0-1,1-0,1-2}.txt.\n\t* tests/data/test-abidiff/test-crc-report-0-1.txt: Report\n\tshowing additional of CRCs.\n\t* tests/data/test-abidiff/test-crc-report-1-0.txt: Report\n\tshowing removal of CRCs.\n\t* tests/data/test-abidiff/test-crc-report-1-2.txt: Renamed\n\tfrom tests/data/test-abidiff/test-crc-report.txt.\n\t* tests/test-abidiff.cc: Update test cases that no longer\n\tgenerate empty reports.\n\t* tests/test-symtab.cc: Update KernelSymtabsWithCRC test.\n\nReviewed-by: Matthias Maennich \u003cmaennich@google.com\u003e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n(cherry picked from commit 89e6854ca4408654bb5ff5665864d80a0ae45b72)\nChange-Id: Ibf52b12588b5a654bc59060f7b1cd05121125358\n" }, { "commit": "5404a2f3df092670679307c5a20856e7f0ac12a1", "tree": "0268365e6d57caa3eb8a504995705b787c078767", "parents": [ "ef3835946ab8757f4c1363f406d6fb1a200533e7" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jun 13 15:25:31 2022 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 09:31:22 2022 +0100" }, "message": "optional: minor improvements\n\nThis change makes minor improvements to the optional class used with\npre-C++17 compilers.\n\n- adds operator\u003d\u003d and operator!\u003d\n- adds various missing noexcept (but not constexpr) decorations\n- defines operator bool in terms of has_value\n\nNote that some constexpr decorations would require C++17 anyway.\n\n\t* include/abg-cxx-compat.h (optional): Add operator\u003d\u003d and\n\toperator!\u003d. Add noexcept decorations. Tweak operator bool.\n\nReviewed-by: Matthias Maennich \u003cmaennich@google.com\u003e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n(cherry picked from commit ce7bd9f595960d05c4cf12bf2250907db792d00e)\nChange-Id: I4ac3e0189d694585444aa45f8adb4741add14b31\n" }, { "commit": "ef3835946ab8757f4c1363f406d6fb1a200533e7", "tree": "2b718a67209e743c1cffbd0cb174400334f8baf3", "parents": [ "3888a5b0fd8a91019f22bcda1482dcc51c9a034f" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Mon Jun 13 15:25:30 2022 +0100" }, "committer": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Oct 13 09:30:58 2022 +0100" }, "message": "crc_changed: eliminate copying of shared_ptr values\n\nAs pointed out in a review of similar code, it is possible to avoid\ncopying a couple of shared pointers in this function, by taking\nreferences instead.\n\nThis commit also splits declarations to one per line and removes the\nunnecessary parentheses around the return expression.\n\n\t* src/abg-comp-filter.cc (crc_changed): Take references to\n\tavoid std::shared_ptr copying. Split declarations into one per\n\tline. Remove unnecessary return expression parentheses.\n\nReviewed-by: Matthias Maennich \u003cmaennich@google.com\u003e\nSigned-off-by: Giuliano Procida \u003cgprocida@google.com\u003e\n(cherry picked from commit d15c30e31950e27e72f50777dde00f63400ed80b)\nChange-Id: I4926d2f1a8eb07ca60a555144b02cb951a63124b\n" }, { "commit": "95cac85060395b7143acf9fa33720e2754bf6ff2", "tree": "44cc8e15efe22e90d4b2f4257e08b5b257d9ce08", "parents": [ "55d75f67b33c29f18aa45f9e7d1f1a3e2f7ef08d", "d44213fc5dbd80f675a11c0fba4eca92422b85b1" ], "author": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Thu Sep 22 18:14:44 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Sep 22 18:14:44 2022 +0000" }, "message": "abitidy: add functionality to remove top-level qualifiers on function parameter and return types am: 3888a5b0fd am: 9d46419b22 am: 84b53be3d1 am: d44213fc5d\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2162198\n\nChange-Id: I8bb3301929079090f9dbcd994e066c49c9233d15\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "d44213fc5dbd80f675a11c0fba4eca92422b85b1", "tree": "44cc8e15efe22e90d4b2f4257e08b5b257d9ce08", "parents": [ "871852e3a2d69b046d7d2e8ca48b290e025eccf2", "84b53be3d1e4b229d1a774b8a3218d8ff3dd35ec" ], "author": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Thu Sep 22 17:25:01 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Sep 22 17:25:01 2022 +0000" }, "message": "abitidy: add functionality to remove top-level qualifiers on function parameter and return types am: 3888a5b0fd am: 9d46419b22 am: 84b53be3d1\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2162198\n\nChange-Id: If9bcea498a1e5d04caf2f8be1b89c320fd609501\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "84b53be3d1e4b229d1a774b8a3218d8ff3dd35ec", "tree": "44cc8e15efe22e90d4b2f4257e08b5b257d9ce08", "parents": [ "94e310bc479a1d1d571847228aa54999ac169ee7", "9d46419b224bfaef210d918637a302b5f32aac71" ], "author": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Thu Sep 22 16:33:21 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Sep 22 16:33:21 2022 +0000" }, "message": "abitidy: add functionality to remove top-level qualifiers on function parameter and return types am: 3888a5b0fd am: 9d46419b22\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2162198\n\nChange-Id: I3fd855b644914182193ed3a69dd5c65dee1825eb\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "9d46419b224bfaef210d918637a302b5f32aac71", "tree": "44cc8e15efe22e90d4b2f4257e08b5b257d9ce08", "parents": [ "18560ea489aa10f5125bd176fbf523a8186c924c", "3888a5b0fd8a91019f22bcda1482dcc51c9a034f" ], "author": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Thu Sep 22 15:45:00 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Sep 22 15:45:00 2022 +0000" }, "message": "abitidy: add functionality to remove top-level qualifiers on function parameter and return types am: 3888a5b0fd\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2162198\n\nChange-Id: I1864fe0a02803447071bed412e437100a216da31\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3888a5b0fd8a91019f22bcda1482dcc51c9a034f", "tree": "44cc8e15efe22e90d4b2f4257e08b5b257d9ce08", "parents": [ "9ee33c13f9a74fc49f5a7eee5c9fb1a5e3823b03" ], "author": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Thu Jul 21 17:57:36 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Thu Sep 22 14:04:04 2022 +0000" }, "message": "abitidy: add functionality to remove top-level qualifiers on function parameter and return types\n\nBug: 238866030\nChange-Id: I1c15a590d2a00ef0464c9e7023444b6e2ce03487\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\n" }, { "commit": "55d75f67b33c29f18aa45f9e7d1f1a3e2f7ef08d", "tree": "7fda171a309af9f76cdf111fd6e58c5b2a62a646", "parents": [ "f596900bec87a0e61311261397a4abcac477c900", "871852e3a2d69b046d7d2e8ca48b290e025eccf2" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:16:27 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:16:27 2022 +0000" }, "message": "abitidy: extract code to get a comment node into a separate function am: 9ee33c13f9 am: 18560ea489 am: 94e310bc47 am: 871852e3a2\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2175523\n\nChange-Id: I8a6b9d863c52276270f8a63232983e459f50b890\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f596900bec87a0e61311261397a4abcac477c900", "tree": "b57bac571bbb062e757673a4a8632b7ecf843550", "parents": [ "5b2741887ca96af01827f3756c9aebd19272f3cc", "34428b3e42f612643c64f4376ea470f266a9d8ec" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:28 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:28 2022 +0000" }, "message": "abitidy: Add an anonymous type id renumbering strategy using first member am: 69680726ad am: a1bff3b74c am: 99084ec9be am: 34428b3e42\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2200428\n\nChange-Id: I53b1844115d418a8a36af173b970876975906e74\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "5b2741887ca96af01827f3756c9aebd19272f3cc", "tree": "f805ffd17db74509c0d62b60373c31baaa91e7bb", "parents": [ "7087f27db0cd4fba591abaa87558e3eb2ca670a4", "f3feea61711334306ab3aa50808d5552ce3145ac" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:27 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:27 2022 +0000" }, "message": "abitidy: Renumber anonymous type ids using option `renumber-anonymous-types` am: a6b16768b5 am: 53b127586f am: 0bc20f18d1 am: f3feea6171\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197901\n\nChange-Id: I1a0ac6491dbd9dd5cfe28983e4f7da7ad7e74e4c\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "7087f27db0cd4fba591abaa87558e3eb2ca670a4", "tree": "0aeef07a93f034ff52e83ea3b91e95dd8f1e7f92", "parents": [ "411555cff2673052cf47a59dc33d0740789ea566", "bdfa8a7cb8cb181a41f7c5b6ad36c109d8417f25" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:26 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:26 2022 +0000" }, "message": "abitidy: Add method to replace old type ids of anonymous types by new ones am: 818fdda4ef am: a9a0e43cf0 am: 7bf5e53d39 am: bdfa8a7cb8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197900\n\nChange-Id: I22e07d747b27c6f1fe25d03fb44779e72f28e573\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "411555cff2673052cf47a59dc33d0740789ea566", "tree": "33be994ec0e2fe2e02e00a81e51545e67682aea2", "parents": [ "bee2ac98a931d644329a93461e198c5686eb72a4", "75668a20e732873b22e40c4935dea37b37f42659" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:25 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:25 2022 +0000" }, "message": "abitidy: Add method to calculate new ids for anonymous types am: 4ccad53441 am: 1aed691eab am: 20e910e059 am: 75668a20e7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197899\n\nChange-Id: Iaf22957786f013d91b5660533cf8af89bf1698b4\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "bee2ac98a931d644329a93461e198c5686eb72a4", "tree": "3462916dd2300689c9c130b455bac497939c9984", "parents": [ "96d0e84830516a420690a51aa2341e32b398463e", "3b980b550424f73c6b4aef9499a5bf5557209000" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:24 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:24 2022 +0000" }, "message": "abitidy: Record type ids for anonymous types that have to be renumbered am: 24ad0a7342 am: 71d3b83719 am: 079452428c am: 3b980b5504\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197898\n\nChange-Id: I29a368b10ca7e3f1526e7a0f62241e570f3c5d62\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "96d0e84830516a420690a51aa2341e32b398463e", "tree": "6cb29cd757d1361de60b78111021baa05c949095", "parents": [ "1226e9c46fa841201e791803bedcf3d1f218a497", "2157052f72683486730063304ba2c62c78dc6488" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 23:15:22 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 23:15:22 2022 +0000" }, "message": "abitidy: Refactor sorting logic am: 0d7a60e63c am: 7c1ef4e509 am: 9df654a263 am: 2157052f72\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2167322\n\nChange-Id: I62c58ebc4b608ea352d694aa6287b26f2f2c2b92\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "871852e3a2d69b046d7d2e8ca48b290e025eccf2", "tree": "7fda171a309af9f76cdf111fd6e58c5b2a62a646", "parents": [ "34428b3e42f612643c64f4376ea470f266a9d8ec", "94e310bc479a1d1d571847228aa54999ac169ee7" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:35:41 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:35:41 2022 +0000" }, "message": "abitidy: extract code to get a comment node into a separate function am: 9ee33c13f9 am: 18560ea489 am: 94e310bc47\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2175523\n\nChange-Id: I4f98b11462c631bb7d9bd07dd487ba713fe71ed4\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "34428b3e42f612643c64f4376ea470f266a9d8ec", "tree": "b57bac571bbb062e757673a4a8632b7ecf843550", "parents": [ "f3feea61711334306ab3aa50808d5552ce3145ac", "99084ec9befdb45ce1a532322871eb6726bc6e42" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:57 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:57 2022 +0000" }, "message": "abitidy: Add an anonymous type id renumbering strategy using first member am: 69680726ad am: a1bff3b74c am: 99084ec9be\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2200428\n\nChange-Id: Id06fffc21a5d03cdf26ef4f8bcf08c42a88903ed\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f3feea61711334306ab3aa50808d5552ce3145ac", "tree": "f805ffd17db74509c0d62b60373c31baaa91e7bb", "parents": [ "bdfa8a7cb8cb181a41f7c5b6ad36c109d8417f25", "0bc20f18d1e93d43067bcd6d772d8cb53b45dd84" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:56 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:56 2022 +0000" }, "message": "abitidy: Renumber anonymous type ids using option `renumber-anonymous-types` am: a6b16768b5 am: 53b127586f am: 0bc20f18d1\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197901\n\nChange-Id: I9bb4bab7213225c29e9ab8c0a493261ca938f500\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "bdfa8a7cb8cb181a41f7c5b6ad36c109d8417f25", "tree": "0aeef07a93f034ff52e83ea3b91e95dd8f1e7f92", "parents": [ "75668a20e732873b22e40c4935dea37b37f42659", "7bf5e53d39be73610d1f6a93e4416ce19eb59c9b" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:55 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:55 2022 +0000" }, "message": "abitidy: Add method to replace old type ids of anonymous types by new ones am: 818fdda4ef am: a9a0e43cf0 am: 7bf5e53d39\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197900\n\nChange-Id: If555a7d52eedd7a320d3631a19702e8f851c27f5\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "75668a20e732873b22e40c4935dea37b37f42659", "tree": "33be994ec0e2fe2e02e00a81e51545e67682aea2", "parents": [ "3b980b550424f73c6b4aef9499a5bf5557209000", "20e910e0594b955eea2474f9cd3df71a11365699" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:54 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:54 2022 +0000" }, "message": "abitidy: Add method to calculate new ids for anonymous types am: 4ccad53441 am: 1aed691eab am: 20e910e059\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197899\n\nChange-Id: I46c4a590cd4aba59171534b4d4aea72cf39238ff\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3b980b550424f73c6b4aef9499a5bf5557209000", "tree": "3462916dd2300689c9c130b455bac497939c9984", "parents": [ "2157052f72683486730063304ba2c62c78dc6488", "079452428c636b3eb75fb69c09c13d758f4db822" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:52 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:52 2022 +0000" }, "message": "abitidy: Record type ids for anonymous types that have to be renumbered am: 24ad0a7342 am: 71d3b83719 am: 079452428c\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197898\n\nChange-Id: Ic03a624dac6920d9c3c1c991b6bd5f5549cc139e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "2157052f72683486730063304ba2c62c78dc6488", "tree": "6cb29cd757d1361de60b78111021baa05c949095", "parents": [ "a399ea0edc28a4150bd0b510614f8777e3ac37e6", "9df654a26393261a45d31b28fbfed75d391adcef" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Sep 21 21:34:51 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 21 21:34:51 2022 +0000" }, "message": "abitidy: Refactor sorting logic am: 0d7a60e63c am: 7c1ef4e509 am: 9df654a263\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2167322\n\nChange-Id: Ica93471337718374307c164be759df552f5f221a\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "94e310bc479a1d1d571847228aa54999ac169ee7", "tree": "7fda171a309af9f76cdf111fd6e58c5b2a62a646", "parents": [ "99084ec9befdb45ce1a532322871eb6726bc6e42", "18560ea489aa10f5125bd176fbf523a8186c924c" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:46:20 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:46:20 2022 +0000" }, "message": "abitidy: extract code to get a comment node into a separate function am: 9ee33c13f9 am: 18560ea489\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2175523\n\nChange-Id: Ibbcc272592a37dda4c0ec6f8ae1c9719f60e3d68\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "99084ec9befdb45ce1a532322871eb6726bc6e42", "tree": "b57bac571bbb062e757673a4a8632b7ecf843550", "parents": [ "0bc20f18d1e93d43067bcd6d772d8cb53b45dd84", "a1bff3b74c129df511767aad8f6302e783cf0483" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:55 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:55 2022 +0000" }, "message": "abitidy: Add an anonymous type id renumbering strategy using first member am: 69680726ad am: a1bff3b74c\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2200428\n\nChange-Id: I50f29ffd78650c37a6bd1ce474c9eda20384eed2\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "0bc20f18d1e93d43067bcd6d772d8cb53b45dd84", "tree": "f805ffd17db74509c0d62b60373c31baaa91e7bb", "parents": [ "7bf5e53d39be73610d1f6a93e4416ce19eb59c9b", "53b127586f2b249ab68cae15c2c81a91241b37af" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:53 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:53 2022 +0000" }, "message": "abitidy: Renumber anonymous type ids using option `renumber-anonymous-types` am: a6b16768b5 am: 53b127586f\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197901\n\nChange-Id: I1b10a382bb02bb857525fbad5a7f76a4b5370762\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "7bf5e53d39be73610d1f6a93e4416ce19eb59c9b", "tree": "0aeef07a93f034ff52e83ea3b91e95dd8f1e7f92", "parents": [ "20e910e0594b955eea2474f9cd3df71a11365699", "a9a0e43cf028eb2eafb3afd9bfcd23bb293aa371" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:52 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:52 2022 +0000" }, "message": "abitidy: Add method to replace old type ids of anonymous types by new ones am: 818fdda4ef am: a9a0e43cf0\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197900\n\nChange-Id: I78da3ab1baff7b8bf061bbd22b6c0c4945ec8856\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "20e910e0594b955eea2474f9cd3df71a11365699", "tree": "33be994ec0e2fe2e02e00a81e51545e67682aea2", "parents": [ "079452428c636b3eb75fb69c09c13d758f4db822", "1aed691eab3dcbcc134651e42b909b613cf5ccb4" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:51 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:51 2022 +0000" }, "message": "abitidy: Add method to calculate new ids for anonymous types am: 4ccad53441 am: 1aed691eab\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197899\n\nChange-Id: I0b936b28c85b9ce1aa83caa9e116b52d21c45e3e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "079452428c636b3eb75fb69c09c13d758f4db822", "tree": "3462916dd2300689c9c130b455bac497939c9984", "parents": [ "9df654a26393261a45d31b28fbfed75d391adcef", "71d3b8371926aa164c58e016875ab58c7c3cbced" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:50 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:50 2022 +0000" }, "message": "abitidy: Record type ids for anonymous types that have to be renumbered am: 24ad0a7342 am: 71d3b83719\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197898\n\nChange-Id: I48e19ec3323bd03c1b07fbaf37a77b7e95e224a1\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "9df654a26393261a45d31b28fbfed75d391adcef", "tree": "6cb29cd757d1361de60b78111021baa05c949095", "parents": [ "6efd8723270e1a34cf93a120fe29ecc9cede6632", "7c1ef4e50920a29108ec2c5b97ebdfaf1d9c7942" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 17:45:49 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 17:45:49 2022 +0000" }, "message": "abitidy: Refactor sorting logic am: 0d7a60e63c am: 7c1ef4e509\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2167322\n\nChange-Id: Id8361d38a4d5c97cf2399d6bf6a7442c02afefde\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "18560ea489aa10f5125bd176fbf523a8186c924c", "tree": "7fda171a309af9f76cdf111fd6e58c5b2a62a646", "parents": [ "a1bff3b74c129df511767aad8f6302e783cf0483", "9ee33c13f9a74fc49f5a7eee5c9fb1a5e3823b03" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:56 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:56 2022 +0000" }, "message": "abitidy: extract code to get a comment node into a separate function am: 9ee33c13f9\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2175523\n\nChange-Id: Ib0faa5b0eb93c0841b31303afb3eab924a0591eb\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a1bff3b74c129df511767aad8f6302e783cf0483", "tree": "b57bac571bbb062e757673a4a8632b7ecf843550", "parents": [ "53b127586f2b249ab68cae15c2c81a91241b37af", "69680726ad18fb2feb477ceb2a0986c772b48ae7" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:43 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:43 2022 +0000" }, "message": "abitidy: Add an anonymous type id renumbering strategy using first member am: 69680726ad\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2200428\n\nChange-Id: I0510501d3e8961be9df8e48b7b9a6b583e5b2eb0\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "53b127586f2b249ab68cae15c2c81a91241b37af", "tree": "f805ffd17db74509c0d62b60373c31baaa91e7bb", "parents": [ "a9a0e43cf028eb2eafb3afd9bfcd23bb293aa371", "a6b16768b51740dba22790deb4cb2172d0a0c9e8" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:42 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:42 2022 +0000" }, "message": "abitidy: Renumber anonymous type ids using option `renumber-anonymous-types` am: a6b16768b5\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197901\n\nChange-Id: Ifff1a62bf8c0efdeb991e47e21ab31261b1d4959\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a9a0e43cf028eb2eafb3afd9bfcd23bb293aa371", "tree": "0aeef07a93f034ff52e83ea3b91e95dd8f1e7f92", "parents": [ "1aed691eab3dcbcc134651e42b909b613cf5ccb4", "818fdda4ef7e411a83c7fb38dc67e147e622b6d8" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:41 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:41 2022 +0000" }, "message": "abitidy: Add method to replace old type ids of anonymous types by new ones am: 818fdda4ef\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197900\n\nChange-Id: Ia9fb99547fb5130a1ff4f6b458726d1394dcf868\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1aed691eab3dcbcc134651e42b909b613cf5ccb4", "tree": "33be994ec0e2fe2e02e00a81e51545e67682aea2", "parents": [ "71d3b8371926aa164c58e016875ab58c7c3cbced", "4ccad53441007235e620f685ef8fce85296c815a" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:39 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:39 2022 +0000" }, "message": "abitidy: Add method to calculate new ids for anonymous types am: 4ccad53441\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197899\n\nChange-Id: If74f786fa4f14f5dfbb9793731a27f0c397e3b45\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "71d3b8371926aa164c58e016875ab58c7c3cbced", "tree": "3462916dd2300689c9c130b455bac497939c9984", "parents": [ "7c1ef4e50920a29108ec2c5b97ebdfaf1d9c7942", "24ad0a7342f83a60693febb3968dc0e5402f4da4" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:38 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:38 2022 +0000" }, "message": "abitidy: Record type ids for anonymous types that have to be renumbered am: 24ad0a7342\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2197898\n\nChange-Id: I2059c56691f922aeafa2208e245916977be550ca\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "7c1ef4e50920a29108ec2c5b97ebdfaf1d9c7942", "tree": "6cb29cd757d1361de60b78111021baa05c949095", "parents": [ "9a051ce8948dda10bef82b4f060e862be6555a6e", "0d7a60e63c772f129c0c6b0829d4e381c1f3d7a9" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:44:37 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 20 16:44:37 2022 +0000" }, "message": "abitidy: Refactor sorting logic am: 0d7a60e63c\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2167322\n\nChange-Id: Icf5697a203355763912c2bf977c8bb5a202bade0\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "9ee33c13f9a74fc49f5a7eee5c9fb1a5e3823b03", "tree": "7fda171a309af9f76cdf111fd6e58c5b2a62a646", "parents": [ "69680726ad18fb2feb477ceb2a0986c772b48ae7" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Aug 08 11:51:36 2022 +0000" }, "committer": { "name": "Sid Nayyar", "email": "sidnayyar@google.com", "time": "Tue Sep 20 16:18:14 2022 +0000" }, "message": "abitidy: extract code to get a comment node into a separate function\n\nThe piece of code to find the comment node for a node is replicated in 4\ndifferent places. This change consolidates this code in one place by\nextracting it out into a function.\n\nBug: 238866030\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: I91e84366033d640ff2ee7bb63598980b1a2acccf\n" }, { "commit": "69680726ad18fb2feb477ceb2a0986c772b48ae7", "tree": "b57bac571bbb062e757673a4a8632b7ecf843550", "parents": [ "a6b16768b51740dba22790deb4cb2172d0a0c9e8" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Aug 30 17:38:35 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 14:44:46 2022 +0000" }, "message": "abitidy: Add an anonymous type id renumbering strategy using first member\n\nThis change adds a strategy where the first member (first enumerator for\nenums and first data member for structs or unions) is used to compute a\nmore stable hash for ids of anonymous types.\n\nThe stategy here is to use a combination of the name and type of the\nfirst member as well as the kind (struct/union/enum) of the type being\nrenumbered to compute a new type id.\n\nUsing this strategy it was found that while computation of hashes, the\nlength of a collision chain was at most 3 with the android13-5.15\nkernel. Moreover, the total number of hash collisions were less than 30.\nTherefore, this strategy is very effective in preventing long collision\nchains, hence preventing long chain of changes in case anonymous types\nget renumbered due to addition of new anonymous types.\n\nBug: 239910948\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: Iaa06244ac18bf19c4748a971df599cd6620cba07\n" }, { "commit": "a6b16768b51740dba22790deb4cb2172d0a0c9e8", "tree": "f805ffd17db74509c0d62b60373c31baaa91e7bb", "parents": [ "818fdda4ef7e411a83c7fb38dc67e147e622b6d8" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Aug 15 18:23:49 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 14:41:48 2022 +0000" }, "message": "abitidy: Renumber anonymous type ids using option `renumber-anonymous-types`\n\nAnonymous type renumbering pass can be done before or after the existing\nanonymous type handling pass, but doing it beforehand ensures that it\nwill be applied to a smaller set of types. This is because types with\nnaming typedef backlinks will be excluded and libabigail has in any case\nlikely produced unique ids for these.\n\nThis option is experimental for now and not part of the `--all` options.\nWhen the flag is used, type ids for anonymous types are renumbered by\naditidy using information about the type making it less to random\nchanges due to linear probing during type id generation.\n\nBug: 239910948\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: Ibbfdd4bb6eec14d91e85942b7580e5427981e692\n" }, { "commit": "818fdda4ef7e411a83c7fb38dc67e147e622b6d8", "tree": "0aeef07a93f034ff52e83ea3b91e95dd8f1e7f92", "parents": [ "4ccad53441007235e620f685ef8fce85296c815a" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Aug 15 16:52:58 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 14:41:42 2022 +0000" }, "message": "abitidy: Add method to replace old type ids of anonymous types by new ones\n\nThis replacement aims to make the anonymous type ids in the ABI XML less\nprone to undergo changes randomly, since the replacement method uses new\ntype ids which are derived from type information that are more stable\nand ensure that different hashes are possibly generated for different\ntypes. Therefore this helps in avoiding linear probing during hash\ngeneration for type ids.\n\nBug: 239910948\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: I7ed50f0cb488c44d68c53719102171b4b49d73f5\n" }, { "commit": "4ccad53441007235e620f685ef8fce85296c815a", "tree": "33be994ec0e2fe2e02e00a81e51545e67682aea2", "parents": [ "24ad0a7342f83a60693febb3968dc0e5402f4da4" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Aug 15 16:34:42 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 14:41:42 2022 +0000" }, "message": "abitidy: Add method to calculate new ids for anonymous types\n\nThis method only considers the kind of the anonymous types to renumber\nids for now. It will be developed further in the following changes to\nconsider the information about the data members to of the anonymous type\nin order to renumber them.\n\nBug: 239910948\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: I724bad71fc0b16c2a28c67b9cea86678fcb8e339\n" }, { "commit": "24ad0a7342f83a60693febb3968dc0e5402f4da4", "tree": "3462916dd2300689c9c130b455bac497939c9984", "parents": [ "0d7a60e63c772f129c0c6b0829d4e381c1f3d7a9" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Aug 15 16:02:04 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Tue Sep 20 14:36:28 2022 +0000" }, "message": "abitidy: Record type ids for anonymous types that have to be renumbered\n\nThe recorded type ids will be used to renumber anonymous types using\nsome information about the type other than the names to produce more\nstable type ids, which are less prone to hash collisions during type id\ngeneration.\n\nBug: 239910948\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\nChange-Id: I636086366f2df52b7d4f721e7d36c53deff47533\n" }, { "commit": "0d7a60e63c772f129c0c6b0829d4e381c1f3d7a9", "tree": "6cb29cd757d1361de60b78111021baa05c949095", "parents": [ "9a051ce8948dda10bef82b4f060e862be6555a6e" ], "author": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Wed Jul 27 13:58:02 2022 +0000" }, "committer": { "name": "Sid", "email": "sidnayyar@google.com", "time": "Mon Sep 05 15:16:28 2022 +0000" }, "message": "abitidy: Refactor sorting logic\n\nThe new sorting logic sorts by the following (in the given order):\n\n1. XML element name\n2. Effective name\n3. Type id\n\nEffective name is the value of the \u0027name\u0027 attribute for all nodes except\nnodes which represent anonymous types. For anonymous types, the\neffective name is null.\n\nBug: 239910948\nChange-Id: I532b977ba88c1a0475faa753e5ccda88a54329d5\nSigned-off-by: Sid Nayyar \u003csidnayyar@google.com\u003e\n" }, { "commit": "1226e9c46fa841201e791803bedcf3d1f218a497", "tree": "576f0cb61520fdb169396a115b95126b23f280a2", "parents": [ "f8be16d5b4213336b03efd72aac7c99d86baafc8", "a399ea0edc28a4150bd0b510614f8777e3ac37e6" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jul 28 21:43:19 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jul 28 21:43:19 2022 +0000" }, "message": "abitidy: per-corpus symbol/alias handling am: 922d5b603a am: 9a051ce894 am: 6efd872327 am: a399ea0edc\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2127439\n\nChange-Id: I09577634c0e42bd8c70f289e0edca5c143018d2f\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a399ea0edc28a4150bd0b510614f8777e3ac37e6", "tree": "576f0cb61520fdb169396a115b95126b23f280a2", "parents": [ "b22c89b73103cc07098a25ee4e351ce8a16de153", "6efd8723270e1a34cf93a120fe29ecc9cede6632" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jul 28 21:16:57 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jul 28 21:16:57 2022 +0000" }, "message": "abitidy: per-corpus symbol/alias handling am: 922d5b603a am: 9a051ce894 am: 6efd872327\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2127439\n\nChange-Id: I725355a7eb3b8eeaabb4aa292526db1f09135bda\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6efd8723270e1a34cf93a120fe29ecc9cede6632", "tree": "576f0cb61520fdb169396a115b95126b23f280a2", "parents": [ "5649f633b2086b25dd9c5f9e646561f4569fe7a2", "9a051ce8948dda10bef82b4f060e862be6555a6e" ], "author": { "name": "Giuliano Procida", "email": "gprocida@google.com", "time": "Thu Jul 28 20:51:02 2022 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Jul 28 20:51:02 2022 +0000" }, "message": "abitidy: per-corpus symbol/alias handling am: 922d5b603a am: 9a051ce894\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libabigail/+/2127439\n\nChange-Id: Ie44083905b3140dc06461a4549d07cb875cb95e7\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" } ], "next": "9a051ce8948dda10bef82b4f060e862be6555a6e" }