commit 00d478d96d328516ee8de6076c84ceec4a92094b
author Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Tue Oct 15 12:29:23 2024 -0400
committer Marge Bot <emma+marge@anholt.net> Fri Jan 17 19:41:45 2025 +0000
tree 957ecab14eff30f6888edf33b98a7fa997fb14d8
parent 7e8c13ea64f1e07576491c1b36c733d3cb4cf438

lavapipe: abort on unsupported depth copy ops

better than silently failing

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33098>

src/gallium/frontends/lavapipe/lvp_execute.c

diff --git a/src/gallium/frontends/lavapipe/lvp_execute.c b/src/gallium/frontends/lavapipe/lvp_execute.c
index 52453b2..78af130 100644
--- a/src/gallium/frontends/lavapipe/lvp_execute.c
+++ b/src/gallium/frontends/lavapipe/lvp_execute.c
@@ -2203,6 +2203,7 @@
                                                       src, src_stride,
                                                       width, height);
       } else {
+         abort();
       }
    } else if (dst_format == PIPE_FORMAT_Z24X8_UNORM) {
       util_format_z24_unorm_s8_uint_unpack_z24(dst, dst_stride,
@@ -2213,6 +2214,8 @@
          util_format_z32_float_s8x24_uint_unpack_z_float((float *)dst, dst_stride,
                                                          src, src_stride,
                                                          width, height);
+      } else {
+         abort();
       }
    } else if (dst_format == PIPE_FORMAT_Z32_FLOAT_S8X24_UINT) {
       if (src_format == PIPE_FORMAT_Z32_FLOAT)
@@ -2223,15 +2226,19 @@
          util_format_z32_float_s8x24_uint_pack_s_8uint(dst, dst_stride,
                                                        src, src_stride,
                                                        width, height);
+      else
+         abort();
    } else if (dst_format == PIPE_FORMAT_Z24_UNORM_S8_UINT) {
       if (src_format == PIPE_FORMAT_S8_UINT)
          util_format_z24_unorm_s8_uint_pack_s_8uint(dst, dst_stride,
                                                     src, src_stride,
                                                     width, height);
-      if (src_format == PIPE_FORMAT_Z24X8_UNORM)
+      else if (src_format == PIPE_FORMAT_Z24X8_UNORM)
          util_format_z24_unorm_s8_uint_pack_z24(dst, dst_stride,
                                                 src, src_stride,
                                                 width, height);
+      else
+         abort();
    }
 }