minigbm: consistent style
- Sometimes were return -1 and sometimes -errno. Prefer -errno
wherever possible.
- No braces for single line if/else statements. This does not
apply gralloc3/gralloc4, since that directory follows AOSP
style.
BUG=b:178495907
TEST=Cuttlefish CFI
Change-Id: I4c35768e015109730772a972b4b18e8d2c3cbb9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2665001
Reviewed-by: Gurchetan Singh <[email protected]>
Reviewed-by: Jason Macnak <[email protected]>
Commit-Queue: Gurchetan Singh <[email protected]>
Tested-by: Gurchetan Singh <[email protected]>
diff --git a/dri.c b/dri.c
index 3ee405b..ad4bf1e 100644
--- a/dri.c
+++ b/dri.c
@@ -94,17 +94,14 @@
if (dri->image_extension->queryImage(bo->priv, __DRI_IMAGE_ATTRIB_MODIFIER_UPPER,
&modifier_upper) &&
dri->image_extension->queryImage(bo->priv, __DRI_IMAGE_ATTRIB_MODIFIER_LOWER,
- &modifier_lower)) {
+ &modifier_lower))
bo->meta.format_modifier =
((uint64_t)modifier_upper << 32) | (uint32_t)modifier_lower;
- } else {
+ else
bo->meta.format_modifier = DRM_FORMAT_MOD_INVALID;
- }
- if (!dri->image_extension->queryImage(bo->priv, __DRI_IMAGE_ATTRIB_NUM_PLANES,
- &num_planes)) {
+ if (!dri->image_extension->queryImage(bo->priv, __DRI_IMAGE_ATTRIB_NUM_PLANES, &num_planes))
return -errno;
- }
bo->meta.num_planes = num_planes;
for (i = 0; i < num_planes; ++i) {
@@ -314,9 +311,8 @@
int ret, dri_format;
struct dri_driver *dri = bo->drv->priv;
- if (!dri->image_extension->createImageWithModifiers) {
+ if (!dri->image_extension->createImageWithModifiers)
return -ENOENT;
- }
dri_format = drm_format_to_dri_format(format);
