Change enum string name for reserved words (#9780)
* Change enum string name for reserved words
Update PHP descriptor protos
* conditionally generate value compat code
diff --git a/php/tests/GeneratedClassTest.php b/php/tests/GeneratedClassTest.php
index 3c4ef13..37c33df 100644
--- a/php/tests/GeneratedClassTest.php
+++ b/php/tests/GeneratedClassTest.php
@@ -291,6 +291,10 @@
// Test Enum methods
$this->assertEquals('ONE', TestEnum::name(1));
$this->assertEquals(1, TestEnum::value('ONE'));
+ $this->assertEquals('ECHO', TestEnum::name(3));
+ $this->assertEquals(3, TestEnum::value('ECHO'));
+ // Backwards compat value lookup by prefixed-name.
+ $this->assertEquals(3, TestEnum::value('PBECHO'));
}
public function testInvalidEnumValueThrowsException()
