commit 80780bdffa484d82dfd55378bd18d8eb30bc78a6
author Jan Tattermusch <jtattermusch@google.com> Tue Jun 23 16:53:05 2020 +0200
committer Jan Tattermusch <jtattermusch@google.com> Tue Jun 23 16:53:05 2020 +0200
tree c1fc4f23a5828775ef2166e4f9c5b21ec4d675c1
parent 6afd469fe0b566784c70b0e94c6f4d0d3ff04a57

optimize WriteRawByte

csharp/src/Google.Protobuf/WriteBufferHelper.cs

diff --git a/csharp/src/Google.Protobuf/WriteBufferHelper.cs b/csharp/src/Google.Protobuf/WriteBufferHelper.cs
index f6617c9..f2a59bc 100644
--- a/csharp/src/Google.Protobuf/WriteBufferHelper.cs
+++ b/csharp/src/Google.Protobuf/WriteBufferHelper.cs
@@ -117,7 +117,7 @@
             }
         }
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        [MethodImpl(MethodImplOptions.NoInlining)]
         public static void RefreshBuffer(ref Span<byte> buffer, ref WriterInternalState state)
         {
             if (state.writeBufferHelper.codedOutputStream?.InternalOutputStream != null)

csharp/src/Google.Protobuf/WritingPrimitives.cs

diff --git a/csharp/src/Google.Protobuf/WritingPrimitives.cs b/csharp/src/Google.Protobuf/WritingPrimitives.cs
index a4a229d..ed76682 100644
--- a/csharp/src/Google.Protobuf/WritingPrimitives.cs
+++ b/csharp/src/Google.Protobuf/WritingPrimitives.cs
@@ -397,9 +397,9 @@
             WriteRawByte(ref buffer, ref state, (byte)(value >> 56));
         }
 
-        public static void WriteRawByte(ref Span<byte> buffer, ref WriterInternalState state, byte value)
+        private static void WriteRawByte(ref Span<byte> buffer, ref WriterInternalState state, byte value)
         {
-            if (state.position == state.limit)
+            if (state.position == buffer.Length)
             {
                 WriteBufferHelper.RefreshBuffer(ref buffer, ref state);
             }