[MPS] Fall back multi-layer LSTM on macOS 12 (#90909)
The native implementation of LSTM has been fixed on macOS 13.
On macOS 12, the multi-layer LSTM still has a numerical correctness issue that cannot be resolved on OS's side.
Thus, we fall back the multi-layer LSTM on macOS 12 to LSTMCell iteration. It might have performance impact but will make LSTM on macOS 12 fully usable.
Fixes: #90421
Issues related: #80306, #83144
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90909
Approved by: https://github.com/albanD, https://github.com/kulinseth
diff --git a/test/test_mps.py b/test/test_mps.py
index f610e6f..66124e9 100644
--- a/test/test_mps.py
+++ b/test/test_mps.py
@@ -9915,12 +9915,12 @@
]
def test_lstm_forward(self, device="mps", dtype=torch.float32):
- for num_layers in [1] if product_version < 13.0 else [1, 2, 5]:
+ for num_layers in [1, 2, 5]:
for test_options in self.LSTM_TEST_CASES:
self._lstm_helper(num_layers=num_layers, dtype=dtype, device=device, **test_options)
def test_lstm_backward(self, device="mps", dtype=torch.float32):
- for num_layers in [1] if product_version < 13.0 else [1, 2, 5]:
+ for num_layers in [1, 2, 5]:
for test_options in self.LSTM_TEST_CASES:
self._lstm_helper(num_layers=num_layers, dtype=dtype, device=device, backward=True, **test_options)
