qemu-option: factor out parse_option_bool
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
diff --git a/qemu-option.c b/qemu-option.c
index bb2a09e..8aac6ae 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -165,6 +165,23 @@
return NULL;
}
+static int parse_option_bool(const char *name, const char *value, int *ret)
+{
+ if (value != NULL) {
+ if (!strcmp(value, "on")) {
+ *ret = 1;
+ } else if (!strcmp(value, "off")) {
+ *ret = 0;
+ } else {
+ fprintf(stderr, "Option '%s': Use 'on' or 'off'\n", name);
+ return -1;
+ }
+ } else {
+ *ret = 1;
+ }
+ return 0;
+}
+
/*
* Sets the value of a parameter in a given option list. The parsing of the
* value depends on the type of option:
@@ -185,6 +202,8 @@
int set_option_parameter(QEMUOptionParameter *list, const char *name,
const char *value)
{
+ int flag;
+
// Find a matching parameter
list = get_option_parameter(list, name);
if (list == NULL) {
@@ -195,18 +214,9 @@
// Process parameter
switch (list->type) {
case OPT_FLAG:
- if (value != NULL) {
- if (!strcmp(value, "on")) {
- list->value.n = 1;
- } else if (!strcmp(value, "off")) {
- list->value.n = 0;
- } else {
- fprintf(stderr, "Option '%s': Use 'on' or 'off'\n", name);
- return -1;
- }
- } else {
- list->value.n = 1;
- }
+ if (-1 == parse_option_bool(name, value, &flag))
+ return -1;
+ list->value.n = flag;
break;
case OPT_STRING:
