qemu-sockets: avoid strlen of NULL pointer If the user wants to create a chardev of type socket but forgets to give a host= option, qemu_opt_get returns NULL. This NULL pointer is then fed into strlen a few lines below without a check which results in a segfault. This fixes it. Signed-off-by: Jens Osterkamp <[email protected]> Signed-off-by: Aurelien Jarno <[email protected]>
diff --git a/qemu-sockets.c b/qemu-sockets.c index a7399aa..c526324 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c
@@ -130,7 +130,8 @@ ai.ai_family = PF_UNSPEC; ai.ai_socktype = SOCK_STREAM; - if (qemu_opt_get(opts, "port") == NULL) { + if ((qemu_opt_get(opts, "host") == NULL) || + (qemu_opt_get(opts, "port") == NULL)) { fprintf(stderr, "%s: host and/or port not specified\n", __FUNCTION__); return -1; }