| commit | de04c5f41c2db68aeb00a2db87f55a98685d98c4 | [log] [tgz] |
|---|---|---|
| author | Andrew Walbran <[email protected]> | Mon Nov 20 17:35:49 2023 +0000 |
| committer | Automerger Merge Worker <[email protected]> | Mon Nov 20 17:35:49 2023 +0000 |
| tree | 4cdb9480305c1f26508a75c711cabff8efedffd8 | |
| parent | 0af49ca108c5d4160ce3030646726f63cce785aa [diff] | |
| parent | f420b5a6dd99fb219bb68083a8c11fd1faf90c98 [diff] |
Migrate to cargo_embargo. am: 8725301739 am: 2b1166aff1 am: f420b5a6dd Original change: https://android-review.googlesource.com/c/platform/external/rust/crates/shared_child/+/2838082 Change-Id: Idbf97d15f5c8c19ce3245671e808c31096cb0e20 Signed-off-by: Automerger Merge Worker <[email protected]>
A library for awaiting and killing child processes from multiple threads.
The std::process::Child type in the standard library provides wait and kill methods that take &mut self, making it impossible to kill a child process while another thread is waiting on it. That design works around a race condition in Unix's waitpid function, where a PID might get reused as soon as the wait returns, so a signal sent around the same time could accidentally get delivered to the wrong process.
However with the newer POSIX waitid function, we can wait on a child without freeing its PID for reuse. That makes it safe to send signals concurrently. Windows has actually always supported this, by preventing PID reuse while there are still open handles to a child process. This library wraps std::process::Child for concurrent use, backed by these APIs.
Compatibility note: The libc crate doesn't currently support waitid on NetBSD or OpenBSD, or on older versions of OSX. There might also be some version of OSX where the waitid function exists but is broken. We can add a “best effort” workaround using waitpid for these platforms as we run into them. Please file an issue if you hit this.
use shared_child::SharedChild; use std::process::Command; use std::sync::Arc; // Spawn a child that will just sleep for a long time, // and put it in an Arc to share between threads. let mut command = Command::new("python"); command.arg("-c").arg("import time; time.sleep(1000000000)"); let shared_child = SharedChild::spawn(&mut command).unwrap(); let child_arc = Arc::new(shared_child); // On another thread, wait on the child process. let child_arc_clone = child_arc.clone(); let thread = std::thread::spawn(move || { child_arc_clone.wait().unwrap() }); // While the other thread is waiting, kill the child process. // This wouldn't be possible with e.g. Arc<Mutex<Child>> from // the standard library, because the waiting thread would be // holding the mutex. child_arc.kill().unwrap(); // Join the waiting thread and get the exit status. let exit_status = thread.join().unwrap(); assert!(!exit_status.success());