commit eb2a875747c3030da5d8dc39197d0889fd8926e7
author Jokke Hämäläinen <jokke.hamalainen@kolttonen.fi> Mon Jun 17 15:02:39 2019 +0300
committer William Roberts <william.c.roberts@intel.com> Wed Jun 19 09:01:12 2019 -0700
tree 1cb1d47e3480fca5e4ada001f2d4cae8a2770ae4
parent e8d880e0a22111e8ad3d6b36418014ba4430a944

libsepol: Replace constant with sizeof()

Replace constant 18 with safer use of sizeof()

Signed-off-by: Unto Sten <sten.unto@gmail.com>

libsepol/src/kernel_to_conf.c

diff --git a/libsepol/src/kernel_to_conf.c b/libsepol/src/kernel_to_conf.c
index 5fb4e83..930bafa 100644
--- a/libsepol/src/kernel_to_conf.c
+++ b/libsepol/src/kernel_to_conf.c
@@ -448,7 +448,7 @@
 		if (i < num_sids) {
 			sid = (char *)sid_to_str[i];
 		} else {
-			snprintf(unknown, 18, "%s%u", "UNKNOWN", i);
+			snprintf(unknown, sizeof(unknown), "%s%u", "UNKNOWN", i);
 			sid = strdup(unknown);
 			if (!sid) {
 				rc = -1;
@@ -2376,7 +2376,7 @@
 		if (i < num_sids) {
 			sid = (char *)sid_to_str[i];
 		} else {
-			snprintf(unknown, 18, "%s%u", "UNKNOWN", i);
+			snprintf(unknown, sizeof(unknown), "%s%u", "UNKNOWN", i);
 			sid = unknown;
 		}