Dedupe addition of crash-diagnostics-dir
For chromeos-chrome builds, we need to remove any unnecessary
{PVR} like info from the build cmd in order for cache hits across
builds.
chromeos-chrome already defines "crash_diagnostics-dir" in such a
manner, but compiler-wrapper adds a duplicate definition of this same
flag but with {PVR} like info.
The fix here is to update compiler-wrapper so that it does not add
"crash-diagnostics-dir" if it is already defined.
BUG=b:326847828
TEST=go test -vet=all (and added more tests)
Change-Id: I81c4dbb29241e85cf78659f35ac9dd93999b6b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5321366
Tested-by: Eric Lok <[email protected]>
Commit-Queue: Eric Lok <[email protected]>
Auto-Submit: Eric Lok <[email protected]>
Reviewed-by: Jordan Abrahams-Whitehead <[email protected]>
Commit-Queue: Ryan Beltran <[email protected]>
Reviewed-by: Ryan Beltran <[email protected]>
Reviewed-by: Raul Rangel <[email protected]>
toolchain-utilsVarious utilities used by the ChromeOS toolchain team.
To run Python scripts in this directory, first run:
export PYTHONPATH=$(readlink -f .):$PYTHONPATH
from this directory.
Then you can run any script.
To get help on any script, type in python <script> --help, or refer to the header of the script for more information.