v4l2_codec2 encoder: Fix minor coding style issue in format converter.
This CL renames a function to fix a minor coding style violation in the
format converter.
Bug: 205203831
Test: arc.VideoEncodeAccel.h264_192p_i420_vm
Change-Id: I6524c09b2957deea2528dc0bef4edad080a227ce
(cherry picked from commit def29da9dbc2e896c548e0687ca8c2603c9ac555)
diff --git a/common/FormatConverter.cpp b/common/FormatConverter.cpp
index 18893d5..4a43217 100644
--- a/common/FormatConverter.cpp
+++ b/common/FormatConverter.cpp
@@ -60,7 +60,7 @@
}
// static
-std::unique_ptr<ImplDefinedToRGBXMap> ImplDefinedToRGBXMap::Create(
+std::unique_ptr<ImplDefinedToRGBXMap> ImplDefinedToRGBXMap::create(
const C2ConstGraphicBlock& block) {
uint32_t width, height, format, stride, igbpSlot, generation;
uint64_t usage, igbpId;
@@ -92,7 +92,7 @@
}
// static
-std::unique_ptr<FormatConverter> FormatConverter::Create(VideoPixelFormat outFormat,
+std::unique_ptr<FormatConverter> FormatConverter::create(VideoPixelFormat outFormat,
const ui::Size& visibleSize,
uint32_t inputCount,
const ui::Size& codedSize) {
@@ -195,7 +195,7 @@
// The above layout() cannot fill layout information and sets it to 0 instead if the input
// format is IMPLEMENTATION_DEFINED and its backed format is RGB. We fill the layout by
// using ImplDefinedToRGBXMap in this case.
- idMap = ImplDefinedToRGBXMap::Create(inputBlock);
+ idMap = ImplDefinedToRGBXMap::create(inputBlock);
if (!idMap) {
ALOGE("Unable to parse RGBX_8888 from IMPLEMENTATION_DEFINED");
return C2_CORRUPTED;
diff --git a/common/include/v4l2_codec2/common/FormatConverter.h b/common/include/v4l2_codec2/common/FormatConverter.h
index 116ef57..b4aacca 100644
--- a/common/include/v4l2_codec2/common/FormatConverter.h
+++ b/common/include/v4l2_codec2/common/FormatConverter.h
@@ -28,7 +28,7 @@
~ImplDefinedToRGBXMap();
ImplDefinedToRGBXMap() = delete;
- static std::unique_ptr<ImplDefinedToRGBXMap> Create(const C2ConstGraphicBlock& block);
+ static std::unique_ptr<ImplDefinedToRGBXMap> create(const C2ConstGraphicBlock& block);
const uint8_t* addr() const { return mAddr; }
int offset() const { return 0; }
@@ -51,7 +51,7 @@
// Create FormatConverter instance and initialize it, nullptr will be returned on
// initialization error.
- static std::unique_ptr<FormatConverter> Create(VideoPixelFormat outFormat,
+ static std::unique_ptr<FormatConverter> create(VideoPixelFormat outFormat,
const ui::Size& visibleSize, uint32_t inputCount,
const ui::Size& codedSize);
diff --git a/components/V4L2EncodeComponent.cpp b/components/V4L2EncodeComponent.cpp
index a1b205a..0dd2f03 100644
--- a/components/V4L2EncodeComponent.cpp
+++ b/components/V4L2EncodeComponent.cpp
@@ -58,7 +58,7 @@
// IMPLEMENTATION_DEFINED and its backed format is RGB. We fill the layout by using
// ImplDefinedToRGBXMap in the case.
if (layout.type == C2PlanarLayout::TYPE_UNKNOWN) {
- std::unique_ptr<ImplDefinedToRGBXMap> idMap = ImplDefinedToRGBXMap::Create(block);
+ std::unique_ptr<ImplDefinedToRGBXMap> idMap = ImplDefinedToRGBXMap::create(block);
if (idMap == nullptr) {
ALOGE("Unable to parse RGBX_8888 from IMPLEMENTATION_DEFINED");
return std::nullopt;
@@ -679,7 +679,7 @@
ALOGV("Creating input format convertor (%s)",
videoPixelFormatToString(mEncoder->inputFormat()).c_str());
mInputFormatConverter =
- FormatConverter::Create(mEncoder->inputFormat(), mEncoder->visibleSize(),
+ FormatConverter::create(mEncoder->inputFormat(), mEncoder->visibleSize(),
V4L2Encoder::kInputBufferCount, mEncoder->codedSize());
if (!mInputFormatConverter) {
ALOGE("Failed to created input format convertor");
