commit a11ae0b0edb898154eae54a017abfcc398629ccc
author Jamie Madill <jmadill@chromium.org> Wed Nov 08 14:48:32 2017 -0500
committer Mark Lobodzinski <mark@lunarg.com> Mon Nov 27 15:30:19 2017 -0700
tree da4e3513a58d2198f217369d9bf4ecc3413c9c50
parent 2406985604ffa69f0fd29cabf19f6336a1619749

loader: Fix improper cast warning.

warning C4057: 'function': 'LPBYTE' differs in indirection to slightly different base types

This was popping up in some Windows builds. Also add it to the list
of warnings enabled by default with MSVS.

Change-Id: I2703f2e57ba3fb33ec03fbc7b8324c75187abec6

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fdc63bd..785d6fc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -94,6 +94,8 @@
     # Warn about potentially uninitialized variables
     add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34701>")
     add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34703>")
+    # Warn about different indirection types.
+    add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34057>")
 endif()
 
 if(NOT WIN32)

loader/loader.c

diff --git a/loader/loader.c b/loader/loader.c
index 8f954e0..ca6d571 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -465,7 +465,7 @@
         value_name,
         NULL,
         &data_type,
-        manifest_path,
+        (BYTE *)manifest_path,
         &requiredSize
     );