commit 45768e1663714702c0c2b7adf14fdbd80dae71f5
author Chih-Hung Hsieh <chh@google.com> Wed Aug 10 12:32:11 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Wed Aug 17 14:32:30 2016 -0700
tree 390f58ffc3bc16cdafcbec15b4c0b85f21332494
parent b89f1d7327e3132f8496cb64e314f89cd5f5bae5

Fix clang-tidy performance warnings.

* Use const reference type for read-only parameters.
Bug: 30407689
Test: build with WITH_TIDY=1

Change-Id: I7c19a10f0ae0b4784851bedbcaf1c4565c6616d1

cpp/BaseObj.cpp

diff --git a/cpp/BaseObj.cpp b/cpp/BaseObj.cpp
index c1a3e55..59eaa9a 100644
--- a/cpp/BaseObj.cpp
+++ b/cpp/BaseObj.cpp
@@ -27,7 +27,7 @@
     return mID;
 }
 
-void * BaseObj::getObjID(sp<const BaseObj> o) {
+void * BaseObj::getObjID(const sp<const BaseObj>& o) {
     return o == nullptr ? nullptr : o->getID();
 }
 
@@ -57,7 +57,7 @@
     mName = name;
 }
 
-bool BaseObj::equals(sp<const BaseObj> obj) {
+bool BaseObj::equals(const sp<const BaseObj>& obj) {
     // Early-out check to see if both BaseObjs are actually the same.
     if (this == obj.get())
         return true;