Google Git
Sign in
android / platform / frameworks / support / 17c92cbbf1051eddc01f64ad5c4d87d5d17b8117
commit17c92cbbf1051eddc01f64ad5c4d87d5d17b8117[log] [tgz]
authorOussama Ben Abdelbaki <[email protected]>Thu Sep 27 14:46:05 2018 -0400
committerOussama Ben Abdelbaki <[email protected]>Mon Oct 22 14:55:44 2018 -0400
treee390443bf1b7b37b581684ea9cffd17740a76f1e
parent5799132835d39bcd370e807618458486c9d21c7a [diff]
Added support for custom error prone rules

We are now able to write our own custom error prone rules as java
files inside the customerrorprone project. There are currently
3 custom rules:
- BanUnlistedSDKVersionComparison bans comprison of SDK_INT
to anything other than constants in VERSION_CODES. This
rule is written but not yet enforced until further
discussion.

- BanKeepAnnotation bans the use of androidx.annotation.Keep.

-BanParcelableUsage prevents any future implmenetations of
Parcelable and directs the user to use VersionedParcelable
instead.

Test: manual testing and ensuring that the error prone errors
trigger on the intended cases.

Bug: 112764060, 115353070, 38123251
Change-Id: I4f02bb270439c47418e0743bfe6b608d966d61a1
33 files changed
tree: e390443bf1b7b37b581684ea9cffd17740a76f1e
  1. .idea/
  2. activity/
  3. animation/
  4. annotations/
  5. api/
  6. appcompat/
  7. arch/
  8. asynclayoutinflater/
  9. benchmark/
  10. biometric/
  11. browser/
  12. buildSrc/
  13. car/
  14. cardview/
  15. collection/
  16. concurrent/
  17. content/
  18. coordinatorlayout/
  19. core/
  20. cursoradapter/
  21. customerrorprone/
  22. customview/
  23. development/
  24. docs-fake/
  25. documentfile/
  26. drawerlayout/
  27. dumb-tests/
  28. dynamic-animation/
  29. emoji/
  30. exifinterface/
  31. fragment/
  32. frameworks/
  33. gradle/
  34. graphics/
  35. gridlayout/
  36. heifwriter/
  37. interpolator/
  38. jetifier/
  39. leanback/
  40. leanback-preference/
  41. legacy/
  42. lifecycle/
  43. loader/
  44. localbroadcastmanager/
  45. media/
  46. media-widget/
  47. media2/
  48. mediarouter/
  49. navigation/
  50. paging/
  51. palette/
  52. percent/
  53. persistence/
  54. preference/
  55. print/
  56. recommendation/
  57. recyclerview/
  58. remotecallback/
  59. room/
  60. samples/
  61. scripts/
  62. slices/
  63. slidingpanelayout/
  64. swiperefreshlayout/
  65. testutils/
  66. testutils-ktx/
  67. textclassifier/
  68. transition/
  69. tv-provider/
  70. versionedparcelable/
  71. viewpager/
  72. viewpager2/
  73. wear/
  74. webkit/
  75. work/
  76. .gitignore
  77. build.gradle
  78. cleanBuild.sh
  79. gradle.properties
  80. gradlew
  81. include-composite-deps.gradle
  82. include-support-library.gradle
  83. LICENSE.txt
  84. OWNERS
  85. PREUPLOAD.cfg
  86. README.md
  87. settings.gradle
README.md

AOSP AndroidX Contribution Guide

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b androidx-master-dev

The first time you initialize the repository, it will ask for user name and email.

Now your repository is set to pull only what you need for building and running AndroidX libraries. Download the code (and grab a coffee while we pull down 3GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full AndroidX library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Testing modified AndroidX Libraries to in your App

You can build maven artifacts locally, and test them directly in your app:

./gradlew createArchive

And put in your project build.gradle file:

handler.maven { url '/path/to/checkout/out/host/gradle/frameworks/support/build/support_repo' }

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run androidx.foobar

Running Sample Apps

The AndroidX repository has a set of Android applications that exercise AndroidX code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named either <libraryname>-integration-tests-testapp, or support-\*-demos (e.g. support-4v-demos or support-leanback-demos). You can run them by clicking Run > Run ... and choosing the desired application.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

If the upload succeeds, you'll see output like:

remote:
remote: New Changes:
remote:   https://android-review.googlesource.com/c/platform/frameworks/support/+/720062 Further README updates
remote:

To edit your change, use git commit --amend, and re-upload.

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.