Google Git
Sign in
android / platform / frameworks / support / 687d3b949ea7b3fdd5a7364e392c30438d695696
commit687d3b949ea7b3fdd5a7364e392c30438d695696[log] [tgz]
authorNeda Topoljanac <[email protected]>Mon Feb 05 20:07:33 2024 +0000
committerNeda Topoljanac <[email protected]>Tue Feb 06 13:45:55 2024 +0000
tree31ae4391529cfb12726ec28ac12eba43f6558930
parent7752e097445f5c07f2b8d44dbdbe24b1007b7827 [diff]
Fix Text alignment issue when ellipsize, letter spacing and center align is used

This issue exists in Android's TextView and it existed in Compose.

Note that RTL issue still exists in platform.

This applies the fix that Compose has by applying IndentationFixSpan
to the TextView when all these parameters are set.

No need to apply it for non-center alignment as those don't have
issue and there's no diff between applied fix and not applied.
Spannable and SpanText don't have this issue.

Updated existing Material screenshot test cases to use default
center align. We changed them previously to start align because
of this issue, to make them look better, changing it back to this
to test the fix.

Fixes: 319243678
Test: Added
Relnote: "Fixed Text alignment issue when ellipsize, letter spacing and center align are all used on Text."
Change-Id: I716c70d5c35ac599c9bb87eaa1cbd4f2172cbdf9
4 files changed
tree: 31ae4391529cfb12726ec28ac12eba43f6558930
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appactions/
  6. appcompat/
  7. appintegration/
  8. appsearch/
  9. arch/
  10. asynclayoutinflater/
  11. autofill/
  12. benchmark/
  13. biometric/
  14. bluetooth/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. contentpager/
  27. coordinatorlayout/
  28. core/
  29. credentials/
  30. cursoradapter/
  31. customview/
  32. datastore/
  33. development/
  34. docs/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. glance/
  48. gradle/
  49. graphics/
  50. gridlayout/
  51. health/
  52. heifwriter/
  53. hilt/
  54. input/
  55. inspection/
  56. interpolator/
  57. javascriptengine/
  58. kruth/
  59. leanback/
  60. lifecycle/
  61. lint/
  62. lint-checks/
  63. loader/
  64. media/
  65. media2/
  66. mediarouter/
  67. metrics/
  68. navigation/
  69. paging/
  70. palette/
  71. pdf/
  72. percentlayout/
  73. placeholder/
  74. placeholder-tests/
  75. playground-common/
  76. playground-projects/
  77. preference/
  78. print/
  79. privacysandbox/
  80. profileinstaller/
  81. recommendation/
  82. recyclerview/
  83. remotecallback/
  84. resourceinspection/
  85. room/
  86. safeparcel/
  87. samples/
  88. savedstate/
  89. security/
  90. sharetarget/
  91. slice/
  92. slidingpanelayout/
  93. sqlite/
  94. stableaidl/
  95. startup/
  96. swiperefreshlayout/
  97. test/
  98. testutils/
  99. text/
  100. tracing/
  101. transition/
  102. tv/
  103. tvprovider/
  104. vectordrawable/
  105. versionedparcelable/
  106. viewpager/
  107. viewpager2/
  108. wear/
  109. webkit/
  110. window/
  111. work/
  112. .gitignore
  113. build.gradle
  114. cleanBuild.sh
  115. code-review.md
  116. CONTRIBUTING.md
  117. gradle.properties
  118. gradlew
  119. libraryversions.toml
  120. LICENSE.txt
  121. OWNERS
  122. PREUPLOAD.cfg
  123. README.md
  124. settings.gradle
  125. studiow
  126. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.