tree 54c885f700bffa5be0c598ee23152daa8afbd709
parent 6722858e9ac7e2dc05062faffabd607721b4ec21
author Marcello Galhardo <mgalhardo@google.com> 1709639347 +0000
committer Marcello Galhardo <mgalhardo@google.com> 1709639526 +0000

Check against duplicated entries for `ViewModelFactoryDsl`

* `ViewModelFactoryDsl` allows duplicated initializers, unnecessary keeping a reference to duplicates while the returned `InitializerViewModelFactory` ignores the duplicated entries. That can cause subtle bugs at runtime.
* To give immediate feedback, we now check against duplicated and throw an `IllegalArgumentException(message = "A `initializer` with the same `clazz` has already been added: $qualifiedName")`.
* In addition to those changes:
  * All tests now are using `this: CreationExtras` in their `initializer` to access the extras.
  * Different test values are using different keys.

RelNote: "`InitializerViewModelFactory` (including `viewModelFactory` builder function) will now throw an `IllegalArgumentException` if a `initializer` with the same `clazz: KClass<VM : ViewModel>` has already been added."
Fixes: b/326226169
Test: ViewModelInitializerTest
Change-Id: Ic3a36b87c170bd886e60fc264a352096be003c02