Google Git
Sign in
android / platform / frameworks / support / 7341ef64fbf832915b8ee6c1ed4838b5981fd886
commit7341ef64fbf832915b8ee6c1ed4838b5981fd886[log] [tgz]
authorClara Fok <[email protected]>Wed Nov 13 11:45:32 2024 -0800
committerClara Fok <[email protected]>Thu Nov 14 10:18:20 2024 -0800
treedc47dd746090fb6d855d86c29f5e5d2bd3539f0c
parentc517af6c6d30da5d5d76b6b8ab72d11e299a16cc [diff]
Fix NavDestination mismatch when adding NavBackStackEntry

When navigating to a nested NavDestination, we trace the target destination's hierarchy and add its parents to the backstack. Since a destination can have different parents (i.e. same destination exists within different graphs), we check its parent for referential equality and add it only if that specific parent hasn't been added yet.

Part of this process includes searching for a specific parent instance. However, parents can also be duplicated - a parent destination can also exist in several different graphs. The current bug is due to findDestination returning the wrong parent duplicate.

So findDestination is modified to take an optional matchingDestination parameter. When matchingDestination is present, findDestination will attempt to return a destination that is equal (==) and has the same parent (same nesting) as the matchingDestination.

Bug: 361560785
Test: ./gradlew navigation:navigation-runtime:cC
Relnote: "Fixed NavDestination NullPointerException when updating a Graph's startDestination"
Change-Id: I99421bf1e4aef9802873d9d78fbc6fafc15a21ba
3 files changed
tree: dc47dd746090fb6d855d86c29f5e5d2bd3539f0c
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appcompat/
  6. appintegration/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. binarycompatibilityvalidator/
  13. biometric/
  14. bluetooth/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. contentpager/
  27. coordinatorlayout/
  28. core/
  29. credentials/
  30. cursoradapter/
  31. customview/
  32. datastore/
  33. development/
  34. docs/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. glance/
  48. gradle/
  49. graphics/
  50. gridlayout/
  51. health/
  52. heifwriter/
  53. hilt/
  54. ink/
  55. input/
  56. inspection/
  57. interpolator/
  58. javascriptengine/
  59. kruth/
  60. leanback/
  61. lifecycle/
  62. lint/
  63. lint-checks/
  64. loader/
  65. media/
  66. mediarouter/
  67. metrics/
  68. navigation/
  69. navigation3/
  70. paging/
  71. palette/
  72. pdf/
  73. percentlayout/
  74. performance/
  75. placeholder/
  76. placeholder-tests/
  77. playground-common/
  78. playground-projects/
  79. preference/
  80. print/
  81. privacysandbox/
  82. profileinstaller/
  83. recommendation/
  84. recyclerview/
  85. remotecallback/
  86. resourceinspection/
  87. room/
  88. safeparcel/
  89. samples/
  90. savedstate/
  91. security/
  92. sharetarget/
  93. slice/
  94. slidingpanelayout/
  95. sqlite/
  96. stableaidl/
  97. startup/
  98. swiperefreshlayout/
  99. test/
  100. testutils/
  101. tracing/
  102. transition/
  103. tv/
  104. tvprovider/
  105. vectordrawable/
  106. versionedparcelable/
  107. viewpager/
  108. viewpager2/
  109. wear/
  110. webkit/
  111. window/
  112. work/
  113. .gitignore
  114. build.gradle
  115. cleanBuild.sh
  116. code-review.md
  117. CONTRIBUTING.md
  118. gradle.properties
  119. gradlew
  120. libraryversions.toml
  121. license-baseline.txt
  122. LICENSE.txt
  123. OWNERS
  124. PREUPLOAD.cfg
  125. README.md
  126. settings.gradle
  127. studiow
  128. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.