| commit | 7afc0733ed6d3e5024f6159e638dfb24dad10260 | [log] [tgz] |
|---|---|---|
| author | Kuan-Ying Chou <[email protected]> | Wed Mar 20 15:39:21 2024 +0000 |
| committer | Kuan-Ying Chou <[email protected]> | Tue Apr 23 18:24:08 2024 +0100 |
| tree | 177dfc4fb16cb4c2e76a6ec34d670809fdbf1cf8 | |
| parent | f19e2e4e5bcd2beed333785346e84af168385f91 [diff] |
[KSP2] Fix type parameter bounds KSP2 adds `Any?` to the upper bound of type parameters when the bound is not explicitly specified. When the origin is Java this bound has a nullability of platform[1], which leads us to generate a Kotlin type name `Any` instead of `Any?` because `isMarkedNullable` is false for platform types. This CL forces the nullability of bounds to be nullable in KSP if it's of platform type. This also changes explicitly specified bounds, for example, `List<T extends Number>` in Java will become `List<T: Number?>` instead of `List<T: Number>` in Kotlin codegen. If the bound is specified and has a `@NotNull` annotation the nullability will be correctly recognized as not-null and not platform in KSP. So `List<T extends @NotNull Number>` in Java will have a Kotlin typename of `List<T: Number>`. Note that this change doesn't apply to platform types in other places. We may consider making them consistent in the future[2]. Also note that this changes the behavior in KSP1 as well, and the result is not consistent with Javac when the bound is explicitly specified. However, we don't do Kotlin codegen with Javac so it should be less of an issue. [1] https://kotlinlang.org/docs/java-interop.html#null-safety-and-platform-types [2] https://b.corp.google.com/issues/331427836 Test: manually tested with KSP2 Change-Id: Iccfd35a213c180f7f5e38cbd69146a1010c0b756
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.
