tree b88b0501ff6fef493f0cc6dbb9e7c7550d1af97d
parent 2dfc326798f11d8fcebf7fa7e7c9d69af0a2b69b
author Tahsin Masrur <tahsinm@google.com> 1724389787 +0800
committer Tahsin Masrur <tahsinm@google.com> 1725010731 +0800

Refactor TorchControl to simplify and optimize the logic

  The primary objective in this CL is setting AE mode at the same capture request where torch mode is set. Currently, we set the torch mode first and await its submission before updating the AE mode in a separate request. This can be error-prone in future changes as well for cases like when user sets some AE mode in the middle of these two operations. Ideally, we should be able to do a single quick synchronous update to CameraPipe when user calls enableTorch or disableTorch.

1. Allow users to override the AE mode set at Controller3A#setTorch
- This allows us to set the appropriate AE mode at the same request of disabling torch. Otherwise, two separate requests need to be used.
2. Simplify TorchControl by awaiting on Controller3A.setTorch only instead of requiring to depend on update3A as well to workaround the previous limitation.

  This can be helpful in aosp/3210473 as well, see the difference in TorchControl vs other control classes there in patch 17.

Bug: 358093572
Test: TorchControlTest, CameraControlAdapterDeviceTest
Change-Id: I54098ff833f915976d3c445c6f53b489c6176f32