| commit | 1924aaf9f9ea73998068aff420d50743ff132713 | [log] [tgz] |
|---|---|---|
| author | Daniel Santiago Rivera <[email protected]> | Mon Jul 02 15:28:11 2018 -0700 |
| committer | Daniel Santiago Rivera <[email protected]> | Tue Jul 03 09:51:47 2018 -0700 |
| tree | 89fcb8b9e32e90964ee9f1760d286e8f838b42a3 | |
| parent | 0afeb397801a874694296f556bf1eb7f304e65d4 [diff] |
Sanitize argument names to avoid generating invalid safe-args classes. This change allows for argument names to have some non-valid java field name, such as dots or bangs while still generating correct safe-args classes. The names are stripped out of non-alphabetical and non-numeric characters, then they are camel-cased to generate Java/Kotlin consistent names. Note that this strategy is not a silver bullet that will perfectly sanitize any string, but it is nicer than doing nothing. Moreover, an error is now thrown when multiple different non-sanitized argument names result in the same string after being sanitized. Finally, this change also applies camel-case to actions class and method names generated. Specifically if the id uses the underscore convention such as R.id.open_details, then the generated class and method will be camel-cased to OpenDetails (class) and openDetails (method). Bug: 79995048 Bug: 79642240 Test: ./gradlew :navigation:navigation-safe-args-generator:test Change-Id: Ie81ebf660c90663510ff33e6a0d045d2a2ed1261
We are not currently accepting new modules, features, or behavior changes.
NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.
Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:
repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master
Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):
repo sync -j8 -c
You will use this command to sync your checkout in the future - it’s similar to git fetch
Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!
If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.
If you see any warnings (red underlines) run Build > Clean Project.
You can do most of your work from Android Studio, however you can also build the full support library from command line:
cd path/to/checkout/frameworks/support/ ./gradlew createArchive
If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too
Run FooBarTestRun android.support.foobarSupport library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.
These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.
cd path/to/checkout/frameworks/support/ repo start my_branch_name . (make needed modifications) git commit -a repo upload --current-branch .
If you see the following prompt, choose always:
Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?