Google Git
Sign in
android / platform / frameworks / support / c644cff0f8261b75be6ea7860bc158a8d030e094
commitc644cff0f8261b75be6ea7860bc158a8d030e094[log] [tgz]
authorJeremy Woods <[email protected]>Fri Jul 15 15:15:47 2022 -0700
committerJeremy Woods <[email protected]>Fri Jul 15 15:26:30 2022 -0700
tree433a890c0b45c82ccaa161c89d538beef0f7f2c8
parent51284610f0ca80d9b07f4a8715c37c20a090f019 [diff]
Fix AndroidViewModelFactory back compat

Currently, if you create a custom AndroidViewModelFactory while using
Lifecycle 2.4+, and use the stateful constructor, the create() function
without extras will never get called. This means that you are forced to
override the create function that includes extras, which will break
people that are just converting. The create function should continue to
be called just like it was previously.

This change makes sure that when the create function function with
extras is called, if the the stateful constructor was used we properly
fall back to the create function without extras.

RelNote: "Custom implementations of `AndroidViewModelFactory` now
correctly call the `create(modelClass)` function when using the stateful
constructor with `Lifecycle` 2.4+"
Test: added test
Bug: 238011621

Change-Id: I5b315ae80d1498b92e412d9316a90e7fa0e9fb3a
2 files changed
tree: 433a890c0b45c82ccaa161c89d538beef0f7f2c8
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. annotation/
  6. appcompat/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. biometric/
  13. bluetooth/
  14. browser/
  15. buildSrc/
  16. buildSrc-tests/
  17. busytown/
  18. camera/
  19. car/
  20. cardview/
  21. collection/
  22. compose/
  23. concurrent/
  24. contentpager/
  25. coordinatorlayout/
  26. core/
  27. cursoradapter/
  28. customview/
  29. datastore/
  30. development/
  31. docs/
  32. docs-public/
  33. docs-tip-of-tree/
  34. documentfile/
  35. draganddrop/
  36. drawerlayout/
  37. dynamicanimation/
  38. emoji/
  39. emoji2/
  40. enterprise/
  41. exifinterface/
  42. external/
  43. fakeannotations/
  44. fragment/
  45. frameworks/
  46. glance/
  47. gradle/
  48. gridlayout/
  49. health/
  50. heifwriter/
  51. hilt/
  52. inspection/
  53. interpolator/
  54. leanback/
  55. lifecycle/
  56. lint-checks/
  57. loader/
  58. media/
  59. media2/
  60. mediarouter/
  61. metrics/
  62. navigation/
  63. paging/
  64. palette/
  65. percentlayout/
  66. placeholder-tests/
  67. playground-common/
  68. preference/
  69. print/
  70. profileinstaller/
  71. recommendation/
  72. recyclerview/
  73. remotecallback/
  74. resourceinspection/
  75. room/
  76. samples/
  77. savedstate/
  78. security/
  79. sharetarget/
  80. slice/
  81. slidingpanelayout/
  82. sqlite/
  83. startup/
  84. swiperefreshlayout/
  85. test/
  86. testutils/
  87. text/
  88. tracing/
  89. transition/
  90. tv/
  91. tvprovider/
  92. vectordrawable/
  93. versionedparcelable/
  94. viewpager/
  95. viewpager2/
  96. wear/
  97. webkit/
  98. window/
  99. work/
  100. .gitignore
  101. .mailmap
  102. build.gradle
  103. cleanBuild.sh
  104. code-review.md
  105. CONTRIBUTING.md
  106. gradle.properties
  107. gradlew
  108. include-composite-deps.gradle
  109. libraryversions.toml
  110. LICENSE.txt
  111. OWNERS
  112. PREUPLOAD.cfg
  113. README.md
  114. settings.gradle
  115. studiow
  116. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.