| commit | cec2ccf6f292cff881e8e3f65cbcef2141985670 | [log] [tgz] |
|---|---|---|
| author | Jasmine Chen <[email protected]> | Tue Dec 10 04:36:55 2024 -0800 |
| committer | Jasmine Chen <[email protected]> | Wed Dec 11 14:57:20 2024 -0800 |
| tree | f1cdb8c566a3fd5f4149caa5652c8d6db84711b9 | |
| parent | a820164509d49219443137f8618797f6e3869b41 [diff] |
Wait for capture session configuration if we've attempted one
In b/277675483, it was identified that on certain devices, if
CameraCaptureSession.close() isn't called explicitly,
CameraDevice.close() may block (stall) indefinitely. Consequently we
close the capture session explicitly before closing the camera device
based on previously accumulated heuristics.
There is however, an edge case that wasn't added as part of b/277675483:
When the following sequence of events occurs, we won't close the
capture session:
1. CaptureSessionState gets an opened CameraDevice
2. CaptureSessionState tries to create a capture session
3. Session has yet to be configured (we haven't received onConfigured)
4. CaptureSessionState is disconnected
In the aforementioned scenario, it is shown through lab results that, by
not closing this capture session that we've instructed the framework to
create, CameraDevice.close() actually can stall.
Here this CL adds a procedure to wait for the session to be configured
(or failed to be configured, or closed), so that we get a capture
session to close it in later sections.
Bug: 383354736
Test: VideoCaptureLifecycleStatusChangeStressTest 10/10 times on
affected devices, and CameraX lab tests.
Change-Id: I53c5fb3be95a7328045e85509e46029633826d06
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.
