Google Git
Sign in
android / platform / frameworks / support / ddc49c903f3d3e853ff6440720699de8f17ee1c9
commitddc49c903f3d3e853ff6440720699de8f17ee1c9[log] [tgz]
authorMelba Nuzen <[email protected]>Mon Jul 22 11:32:02 2024 -0700
committerMelba Nuzen <[email protected]>Tue Jul 23 15:36:18 2024 -0700
treecfc71fd7bc504b42f7aac21250e69aedb0dfb60c
parent4f08622bfe1f9801ecc97082d14f21dd6b75c10c [diff]
Don't return collapsedSemantics on unattached or deactivated nodes

This patch ensures that if a node is deactivated but not attached then `collapsedSemantics` are not returned (and `applySemantics` is not called). This addresses the exception thrown when `applySemantics` is called on an unattached node.

In returning null for deactivated nodes, the SemanticsNodeInteraction.assertIsDeactivated assert needs to be refactored. We need to surface deactivated nodes but cannot do so with testTags because testTags come from semantics config, which comes from modifier nodes. This patch rewrites all foundation tests using the `assertIsDeactivated` assert by instead saving the semantics ids of relevant nodes, then verifying that those nodes all are deactivated by checking `layoutInfo.isDeactivated`.

Test: manually verified Material catalog does not crash
Fixes: 353595612
Fixes: 353538515
RelNote: "New `semanticsId()` test API introduced."
Change-Id: Iee26db6343fbaa3689546256eac2bb0d9725adea
10 files changed
tree: cfc71fd7bc504b42f7aac21250e69aedb0dfb60c
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appcompat/
  6. appintegration/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. binarycompatibilityvalidator/
  13. biometric/
  14. bluetooth/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. contentpager/
  27. coordinatorlayout/
  28. core/
  29. credentials/
  30. cursoradapter/
  31. customview/
  32. datastore/
  33. development/
  34. docs/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. glance/
  48. gradle/
  49. graphics/
  50. gridlayout/
  51. health/
  52. heifwriter/
  53. hilt/
  54. ink/
  55. input/
  56. inspection/
  57. interpolator/
  58. javascriptengine/
  59. kruth/
  60. leanback/
  61. lifecycle/
  62. lint/
  63. lint-checks/
  64. loader/
  65. media/
  66. mediarouter/
  67. metrics/
  68. navigation/
  69. paging/
  70. palette/
  71. pdf/
  72. percentlayout/
  73. placeholder/
  74. placeholder-tests/
  75. playground-common/
  76. playground-projects/
  77. preference/
  78. print/
  79. privacysandbox/
  80. profileinstaller/
  81. recommendation/
  82. recyclerview/
  83. remotecallback/
  84. resourceinspection/
  85. room/
  86. safeparcel/
  87. samples/
  88. savedstate/
  89. security/
  90. sharetarget/
  91. slice/
  92. slidingpanelayout/
  93. sqlite/
  94. stableaidl/
  95. startup/
  96. swiperefreshlayout/
  97. test/
  98. testutils/
  99. tracing/
  100. transition/
  101. tv/
  102. tvprovider/
  103. vectordrawable/
  104. versionedparcelable/
  105. viewpager/
  106. viewpager2/
  107. wear/
  108. webkit/
  109. window/
  110. work/
  111. .gitignore
  112. build.gradle
  113. cleanBuild.sh
  114. code-review.md
  115. CONTRIBUTING.md
  116. gradle.properties
  117. gradlew
  118. libraryversions.toml
  119. LICENSE.txt
  120. OWNERS
  121. PREUPLOAD.cfg
  122. README.md
  123. settings.gradle
  124. studiow
  125. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.