commit 61ebb7ef8889bd0391b49c768df66d77be50e64f
author Kaiyi Li <kaiyili@google.com> Wed Sep 08 09:02:05 2021 -0700
committer Kaiyi Li <kaiyili@google.com> Wed Sep 08 09:02:05 2021 -0700
tree 89db752a6501732539a233be9c396f459a947415
parent 176c51a69edb5828e3efd7cb151c9fe797274c51

Fix resource leak in VirtioGpuTimelines

Remove the entry in mTaskIdToTask when a Task is destroyed.

Test: run the emulator
Change-Id: I936ee8796e7bae6d0f87ceb6478753fb4b70f3c7

stream-servers/VirtioGpuTimelines.cpp

diff --git a/stream-servers/VirtioGpuTimelines.cpp b/stream-servers/VirtioGpuTimelines.cpp
index 8ba729f..c4664d4 100644
--- a/stream-servers/VirtioGpuTimelines.cpp
+++ b/stream-servers/VirtioGpuTimelines.cpp
@@ -34,7 +34,10 @@
     AutoLock lock(mLock);
 
     TaskId id = mNextId++;
-    auto task = std::make_shared<Task>(id, ctxId);
+    std::shared_ptr<Task> task(new Task(id, ctxId), [this](Task *task) {
+        mTaskIdToTask.erase(task->mId);
+        delete task;
+    });
     mTaskIdToTask[id] = task;
     mTimelineQueues[ctxId].emplace_back(std::move(task));
     return id;