commit f610b6701c5e4999bcc2acceb1907ebe11b580fc
author Yilong Li <liyl@google.com> Tue Mar 09 15:08:34 2021 -0800
committer Yilong Li <liyl@google.com> Tue Mar 09 15:08:34 2021 -0800
tree a630ac32e8fc72e776aebea302f07fc6124c9c72
parent e041d3862e5e8bce80d8580ca9703d9a53347569

fuchsia: Create mutable-format sysmem external images.

If we create an image importing VMOs from BufferCollection, the formats
used in clients may be slightly different (e.g. R8G8B8A8_UNORM in
Flutter vs. R8G8B8A8_SRGB in Scenic), which caused graphical artifacts
on some platforms.

This change enforces all sysmem-backed images use flag
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT to explicitly support multiple
formats.

Fixed: fxbug.dev/70232
Change-Id: I40702f8d695feeab2329e4a47fd55560cb94fa37

system/vulkan_enc/ResourceTracker.cpp

diff --git a/system/vulkan_enc/ResourceTracker.cpp b/system/vulkan_enc/ResourceTracker.cpp
index 407d9a4..26bc76f 100644
--- a/system/vulkan_enc/ResourceTracker.cpp
+++ b/system/vulkan_enc/ResourceTracker.cpp
@@ -4008,6 +4008,10 @@
             }
             isSysmemBackedMemory = true;
         }
+
+        if (isSysmemBackedMemory) {
+            localCreateInfo.flags |= VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;
+        }
 #endif
 
         VkResult res;