commit fdecd454d17448934168e906cfb9633579a6322b
author Jason Macnak <natsu@google.com> Fri May 12 15:43:31 2023 -0700
committer Jason Macnak <natsu@google.com> Fri May 12 15:44:05 2023 -0700
tree bc78c40ae8eff357f6bd385bc398fd679664e659
parent 96de4eb27895c8df293b7ffb276e2c62cd97d922

Fix "copied for each invocation" warning

Bug: n/a
Test: cvd start --gpu_mode=gfxstream_guest_angle_host_swiftshader
Change-Id: I7dea81799eefd0c3a62ab22f95926a3a1bcd037e

stream-servers/VirtioGpuTimelines.cpp

diff --git a/stream-servers/VirtioGpuTimelines.cpp b/stream-servers/VirtioGpuTimelines.cpp
index 7f7427f..635aa81 100644
--- a/stream-servers/VirtioGpuTimelines.cpp
+++ b/stream-servers/VirtioGpuTimelines.cpp
@@ -49,7 +49,7 @@
                                       FenceCompletionCallback fenceCompletionCallback) {
     AutoLock lock(mLock);
 
-    auto fence = std::make_unique<Fence>(fenceId, fenceCompletionCallback);
+    auto fence = std::make_unique<Fence>(fenceId, std::move(fenceCompletionCallback));
     mTimelineQueues[ring].emplace_back(std::move(fence));
     if (mWithAsyncCallback) {
         poll_locked(ring);
@@ -106,7 +106,7 @@
         // item is an incompleted task.
         struct {
             bool operator()(std::unique_ptr<Fence> &fence) {
-                (*fence->mCompletionCallback)();
+                fence->mCompletionCallback();
                 return false;
             }
             bool operator()(std::shared_ptr<Task> &task) {