Fix klocwork issues
BZ: 77254
Check the return value of calloc. Fix NULL pointer dereference risk.
Signed-off-by: Elaine Wang <[email protected]>
Change-Id: Ie877bf092e366f59ffa05f39f0d51d5c5d0c2199
Reviewed-on: http://android.intel.com:8080/83994
Reviewed-by: Wang, Elaine <[email protected]>
Reviewed-by: Yuan, Shengquan <[email protected]>
Reviewed-by: Shi, PingX <[email protected]>
Tested-by: Shi, PingX <[email protected]>
Reviewed-by: cactus <[email protected]>
Tested-by: cactus <[email protected]>
diff --git a/src/wsbm_manager.c b/src/wsbm_manager.c
index a86b894..e95309d 100644
--- a/src/wsbm_manager.c
+++ b/src/wsbm_manager.c
@@ -1011,6 +1011,8 @@
struct _WsbmBufferList *list = calloc(sizeof(*list), 1);
int ret;
+ if (!list)
+ return NULL;
list->hasKernelBuffers = hasKernelBuffers;
if (hasKernelBuffers) {
ret = validateCreateList(target, &list->kernelBuffers, 0);
diff --git a/src/wsbm_userpool.c b/src/wsbm_userpool.c
index f7833b7..9c7b79a 100644
--- a/src/wsbm_userpool.c
+++ b/src/wsbm_userpool.c
@@ -339,7 +339,7 @@
vBuf->node =
wsbmMMGetBlock(vBuf->node, vBuf->size, vBuf->alignment);
- if (!err) {
+ if (!err && vBuf->node) {
vBuf->kBuf.placement = WSBM_PL_FLAG_VRAM;
vBuf->kBuf.gpuOffset = p->vramOffset + vBuf->node->start;
vBuf->map = (void *)(p->vramMap + vBuf->node->start);