commit 2ef2d71edf822f0462fb312342f89f80ff271564
author John Hoford <hoford@google.com> Mon Oct 15 16:52:53 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Mon Oct 15 16:52:53 2012 -0700
tree 86707d1325096f8ab4d599b5c6e7e56c4b99ab69
parent 06c349afaff1957f7bc7550f30b8b27ad05730df
parent 4035d297191bd43377714a2fd70c12f375d9a6b2

Merge "fix for the cache" into gb-ub-photos-arches

src/com/android/gallery3d/filtershow/cache/DirectPresetCache.java

diff --git a/src/com/android/gallery3d/filtershow/cache/DirectPresetCache.java b/src/com/android/gallery3d/filtershow/cache/DirectPresetCache.java
index 67bd49b..25d1db4 100644
--- a/src/com/android/gallery3d/filtershow/cache/DirectPresetCache.java
+++ b/src/com/android/gallery3d/filtershow/cache/DirectPresetCache.java
@@ -62,7 +62,7 @@
     private CachedPreset getCachedPreset(ImagePreset preset) {
         for (int i = 0; i < mCache.size(); i++) {
             CachedPreset cache = mCache.elementAt(i);
-            if (cache.mPreset == preset && !cache.mBusy) {
+            if (cache.mPreset == preset) {
                 return cache;
             }
         }
@@ -73,7 +73,7 @@
     public Bitmap get(ImagePreset preset) {
         // Log.v(LOGTAG, "get preset " + preset.name() + " : " + preset);
         CachedPreset cache = getCachedPreset(preset);
-        if (cache != null) {
+        if (cache != null && !cache.mBusy) {
             return cache.mBitmap;
         }
         // Log.v(LOGTAG, "didn't find preset " + preset.name() + " : " + preset
@@ -138,18 +138,21 @@
     public void prepare(ImagePreset preset) {
         // Log.v(LOGTAG, "prepare preset " + preset.name() + " : " + preset);
         CachedPreset cache = getCachedPreset(preset);
-        if (cache == null) {
-            if (mCache.size() < mCacheSize) {
-                cache = new CachedPreset();
-                mCache.add(cache);
-            } else {
-                cache = getOldestCachedPreset();
+        if (cache == null || (cache.mBitmap == null && !cache.mBusy)) {
+            if (cache == null) {
+                if (mCache.size() < mCacheSize) {
+                    cache = new CachedPreset();
+                    mCache.add(cache);
+                } else {
+                    cache = getOldestCachedPreset();
+                }
             }
             if (cache != null) {
                 cache.mPreset = preset;
+                willCompute(cache);
             }
         }
-        willCompute(cache);
+
     }
 
 }