Update the visibility of album art correctly
1. Make the album art visible when metadata is not null
2. Don't change the visibility of the ImageView when setting the drawable
Fixes: 140899776
Test: manual
Change-Id: Ibc219d9a74aea09c43da0cdb7e874f98584e528b
diff --git a/car-apps-common/src/com/android/car/apps/common/imaging/ImageViewBinder.java b/car-apps-common/src/com/android/car/apps/common/imaging/ImageViewBinder.java
index f346de0..9b13438 100644
--- a/car-apps-common/src/com/android/car/apps/common/imaging/ImageViewBinder.java
+++ b/car-apps-common/src/com/android/car/apps/common/imaging/ImageViewBinder.java
@@ -21,7 +21,6 @@
import android.graphics.drawable.BitmapDrawable;
import android.graphics.drawable.Drawable;
import android.util.Size;
-import android.view.View;
import android.widget.ImageView;
import com.android.car.apps.common.CommonFlags;
@@ -57,7 +56,6 @@
protected void setDrawable(@Nullable Drawable drawable) {
if (mImageView != null) {
mImageView.setImageDrawable(drawable);
- mImageView.setVisibility((drawable != null) ? View.VISIBLE : View.GONE);
if (mFlagBitmaps) {
CommonFlags flags = CommonFlags.getInstance(mImageView.getContext());
if (flags.shouldFlagImproperImageRefs()) {
diff --git a/car-media-common/src/com/android/car/media/common/MetadataController.java b/car-media-common/src/com/android/car/media/common/MetadataController.java
index 341c129..49e5a26 100644
--- a/car-media-common/src/com/android/car/media/common/MetadataController.java
+++ b/car-media-common/src/com/android/car/media/common/MetadataController.java
@@ -120,6 +120,8 @@
ViewUtils.setVisible(artist, !TextUtils.isEmpty(artistName));
}
+ ViewUtils.setVisible(albumArt, true);
+
mAlbumArtBinder.setImage(context, metadata.getArtworkKey());
});
