)]}' { "log": [ { "commit": "b3c9cdcef463064d7ac8f1e6b4b88e62433f9d5d", "tree": "febe3db56bf6f20af5f2f9ad7e6e3becb88a8a0c", "parents": [ "f534acf6cc48569ab51bde986fec1c931e26ee78" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Mon Nov 09 09:05:34 2015 -0800" }, "committer": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Mon Nov 09 09:17:31 2015 -0800" }, "message": "attestation: Unify logging location\n\nThis CL defaults attestation daemon logging to syslog.\nLogs can be forwared to stderr by passing the --log_to_stderr flag.\nAttestation_client now logs by default to stderr.\n\nBug: 25567627\nTEST\u003dNone\n\nChange-Id: If87ceffcc48651ff69a0bdd187b7365296ab33a9\n" }, { "commit": "f534acf6cc48569ab51bde986fec1c931e26ee78", "tree": "ff26e98398fa26514b9c659516cbd8aa95071016", "parents": [ "6f035c433ab3ed2992b2d187b35ef7715f80e9a6" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Wed Oct 28 11:58:48 2015 -0700" }, "committer": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Wed Oct 28 11:58:48 2015 -0700" }, "message": "attestation: Rename libchromeos -\u003e libbrillo\n\nBUG: 24872993\nChange-Id: I1c98b556d5a7ff244989569a2e00a7f285219068\n" }, { "commit": "6f035c433ab3ed2992b2d187b35ef7715f80e9a6", "tree": "81f1fcb96c263168c881c7fda7e7e885d8d47e41", "parents": [ "e270d8c69ab46b2ad2973d5b9395aae7c1f52bf6" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Fri Oct 16 16:36:53 2015 -0700" }, "committer": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Fri Oct 16 16:36:53 2015 -0700" }, "message": "attestation: Rename \"chromeos\" -\u003e \"brillo\" in include paths and namespaces\n\nlibchromeos is transitioning to libbrillo and chromeos namespaces\nand include directory is changing to brillo.\n\nBug: 24872993\nTEST\u003dbuilt for aosp and brillo, all unit tests pass on dragonboard\n\nChange-Id: I3d7f1eb480f9e211606d7ee0a990c4a1bec27ea8\n" }, { "commit": "e270d8c69ab46b2ad2973d5b9395aae7c1f52bf6", "tree": "086e70309fbb646ba7ea07aabd3af0dcdfc4dbb6", "parents": [ "23672a810694f5532c2b57bfa1e92ea9fc3b5568" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Tue Oct 13 10:27:01 2015 -0700" }, "committer": { "name": "Alex Vakulenko", "email": "avakulenko@google.com", "time": "Tue Oct 13 10:29:23 2015 -0700" }, "message": "attestation: Rename \"chromeos\" -\u003e \"brillo\" in include paths and namespaces\n\nlibchromeos is transitioning to libbrillo and chromeos namespaces\nand include directory is changing to brillo.\n\nBug: 24872993\nChange-Id: Id96f4f7c372afd328b56efe09aa02b59b5a6fd3a\n" }, { "commit": "23672a810694f5532c2b57bfa1e92ea9fc3b5568", "tree": "ddc41473e2166f4657d0c901206a626f85d7f35b", "parents": [ "3daa5a0d71ba8facd8be9370df54c20c23be6d8d" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Mon Sep 14 08:22:47 2015 -0700" }, "committer": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Mon Sep 14 08:42:40 2015 -0700" }, "message": "attestation: Build from AOSP\n\nThis CL allows for attestation to compile from its new source code\nlocation.\nThis CL also modifies the MODULE_LICENSE to apache2\n\nBug: 23901903\nTEST\u003demerge-link attestation\n\nChange-Id: Ib665bc2566add4acdd8c261182fc66c32b109ace\n" }, { "commit": "3daa5a0d71ba8facd8be9370df54c20c23be6d8d", "tree": "95be2d7be8f968b76cea600a0532ec20d7166139", "parents": [ "049177a4d5426a347efa908c7b7d4796dcd4d355" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Wed Sep 09 18:22:55 2015 -0700" }, "committer": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Wed Sep 09 18:30:00 2015 -0700" }, "message": "attestation: Relicense to Apache2\n\nBug: 23900830\nChange-Id: I17f34f1b84482cd19a96113178e1c619acf9b0f9\nTest: repo upload . --cbr\n" }, { "commit": "049177a4d5426a347efa908c7b7d4796dcd4d355", "tree": "129eaedc29e7b78b03efc99d5378ff9e4dc8e38f", "parents": [ "737a04bf31a6db17ee6172e8606d098fd0dba34e", "e363313244e3788159cda03237dd17b0776f7079" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Thu Sep 10 01:07:21 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Sep 10 01:07:21 2015 +0000" }, "message": "Merge \"attestation: Initial license file\"" }, { "commit": "737a04bf31a6db17ee6172e8606d098fd0dba34e", "tree": "13afafd7fa472eab428cd0752c2f6a0e9ddb7b73", "parents": [ "f7454530c3f02a5ce0412de8b7e7233d1aa3d041", "dc1bece1a950714048105175abc3cd73e06abfc2" ], "author": { "name": "Bill Yi", "email": "byi@google.com", "time": "Wed Sep 09 17:04:05 2015 -0700" }, "committer": { "name": "Bill Yi", "email": "byi@google.com", "time": "Wed Sep 09 17:04:05 2015 -0700" }, "message": "Merge branch \u0027rewrite-attestation\u0027 into merge-attestation\n" }, { "commit": "e363313244e3788159cda03237dd17b0776f7079", "tree": "b411fb9d4294f63aa12707a96cd55151db42fa1e", "parents": [ "f7454530c3f02a5ce0412de8b7e7233d1aa3d041" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Wed Sep 09 16:36:49 2015 -0700" }, "committer": { "name": "Utkarsh Sanghi", "email": "usanghi@google.com", "time": "Wed Sep 09 16:36:49 2015 -0700" }, "message": "attestation: Initial license file\n\nBug: 23900830\nChange-Id: I644506269fd52f1d16d589bbcfb2da518a1bb460\n" }, { "commit": "f7454530c3f02a5ce0412de8b7e7233d1aa3d041", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [], "author": { "name": "Bill Yi", "email": "byi@google.com", "time": "Wed Sep 09 10:14:32 2015 -0700" }, "committer": { "name": "Bill Yi", "email": "byi@google.com", "time": "Wed Sep 09 10:14:32 2015 -0700" }, "message": "Initial empty repository\n" }, { "commit": "dc1bece1a950714048105175abc3cd73e06abfc2", "tree": "13afafd7fa472eab428cd0752c2f6a0e9ddb7b73", "parents": [ "59ea81cf9e7b293ec3241e5d442092b0278a3643" ], "author": { "name": "Bertrand SIMONNET", "email": "bsimonnet@chromium.org", "time": "Thu Aug 13 14:27:05 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Aug 14 03:56:11 2015 +0000" }, "message": "minijail: Create a pkgconfig file for libminijail.\n\nThis allows us to change the import path of libminijail.h easily.\n\nBUG\u003dNone\nTEST\u003d`emerge-gizmo apmanager attestation cromo cros-disks debugd\nlibchromeos lorgnette minijail tpm_manager trunks webserver` works.\n\nCQ-DEPEND\u003dCL:293580\n\nChange-Id: I4b44174ae115a93fb9d4299ca24002f9ad37ba6c\nReviewed-on: https://chromium-review.googlesource.com/293483\nReviewed-by: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\nCommit-Queue: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\nTrybot-Ready: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\nTested-by: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\n" }, { "commit": "59ea81cf9e7b293ec3241e5d442092b0278a3643", "tree": "b10285138a332d899e08ad9ea960bca76451881c", "parents": [ "bcce91c18119c8ea98db7656b872df5f7f623749" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Fri Jun 05 11:09:45 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Jul 17 18:10:17 2015 +0000" }, "message": "attestation: Created proto printing code generator.\n\nThe generator is not integrated into the build. It\u0027s run manually and\nthe output is also committed here. All protos have been moved to\noptimize_for\u003dLITE_RUNTIME and calls to Message::DebugString have been\nmoved to calls to generated code.\n\nBUG\u003dbrillo:1194\nTEST\u003dunit, manually inspected output of attestation client\nCQ-DEPEND\u003dCL:*221897\n\nChange-Id: Ib326b46688ac478c848503e1554aaa08db9bdc34\nReviewed-on: https://chromium-review.googlesource.com/276186\nReviewed-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "bcce91c18119c8ea98db7656b872df5f7f623749", "tree": "a2905d9e69f6752914d4908b9ecadbc300ecaaa9", "parents": [ "c4c764b59281d9299ea22a91b4be0d807f4f11c8" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Mon Jun 15 12:53:22 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Wed Jun 17 17:34:39 2015 +0000" }, "message": "platform2: Fix issues with new version of libchrome\n\nlibchrome r334380 has the following breaking changes that need to be fixed:\n- base::JSONWriter::Write() and base::JSONWriter::WriteWithOptions() take\n \"const base::Value\u0026\" instead of \"const base::Value*\"\n- base::JSONReader::Read() and base::JSONReader::ReadAndReturnError()\n return a scoped_ptr\u003cbase::Value\u003e instead of base::Value*\n- base/safe_strerror_posix.h is moved to base/posix/safe_strerror.h\n- safe_strerror() is now in \"base\" namespace\n- StartsWithASCII(), EndsWith(), StringToUpperASCII(), LowerCaseEqualsASCII()\n are now in \"base\" namespace\n- ObserverList\u003cT\u003e is now in \"base\" namespace\n- base::PrintTo(base::FilePath) used in gtest is now moved to libchrome-test\n library and as such, unit test runners need to link to this library now.\n- crypto::RSAPrivateKey::CreateSensitive() is now removed from //crypto, so\n some of tests in chromeos-login that used that function had to be changed\n to use crypto::GenerateRSAKeyPairNSS() directly.\n- UnixDomanSocket class is now in \"base\" namespace\n- Pickle class is now in \"base\" namespace\n\nBUG\u003dchromium:496469\nTEST\u003d`./build_packages`\nCQ-DEPEND\u003dCL:277662\n\nChange-Id: I36e5fbf2e36a92068873ffbd44020c862a3ed9e3\nReviewed-on: https://chromium-review.googlesource.com/277671\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTrybot-Ready: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "c4c764b59281d9299ea22a91b4be0d807f4f11c8", "tree": "386502438b615e98ee987bbac6dd9e2d2ef2ff36", "parents": [ "62a38eae41f6dbced3454c2d8bcbbb8ca08e3851" ], "author": { "name": "Utkarsh Sanghi", "email": "usanghi@chromium.org", "time": "Wed May 27 10:23:58 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Wed Jun 03 21:01:27 2015 +0000" }, "message": "attestation: enable minijail sandboxing\n\nThis CL makes attestation daemon run inside a minijail\nsandbox, under the attestation user. This CL also defines the\nseccomp policy for amd64 architecture.\n\nBUG\u003dbrillo:913\nTEST\u003drun attestationd on a DUT\nTEST\u003dattestation_client create_and_certify \u0026\u0026 attestation_client sign\n\nChange-Id: I407b62f6e1e8719799d2fff61d4dbfba93fe39c8\nReviewed-on: https://chromium-review.googlesource.com/273592\nTrybot-Ready: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nTested-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nReviewed-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\n" }, { "commit": "62a38eae41f6dbced3454c2d8bcbbb8ca08e3851", "tree": "5cac21a200a4e976a34549f3c0a454050aeddeb3", "parents": [ "d4302a1c687b98c4b1f2eaa8980681cdd469ee84" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Tue Jun 02 18:36:20 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Wed Jun 03 05:07:33 2015 +0000" }, "message": "attestation: Fix startup dependencies.\n\nThis service needs to be started after tcsd.\n\nBUG\u003dnone\nTEST\u003dmanual\n\nChange-Id: I02d44923a64272472666493e162617cf74218dd5\nReviewed-on: https://chromium-review.googlesource.com/274923\nReviewed-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nReviewed-by: Daniel Colish \u003ccolish@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "d4302a1c687b98c4b1f2eaa8980681cdd469ee84", "tree": "ae235da79264299b0f6702c181825599c18a6125", "parents": [ "594849c7cf872d055575277b930f4f596bef1988" ], "author": { "name": "Dan Colish", "email": "colish@chromium.org", "time": "Wed May 13 16:05:14 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Mon May 18 22:38:12 2015 +0000" }, "message": "attestation: clarify dbus_proxy usage comment.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: If04221407ba979afcca52acf43a0ad4639afab24\nReviewed-on: https://chromium-review.googlesource.com/270807\nReviewed-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Daniel Colish \u003ccolish@chromium.org\u003e\nTested-by: Daniel Colish \u003ccolish@chromium.org\u003e\n" }, { "commit": "594849c7cf872d055575277b930f4f596bef1988", "tree": "3e22dc8d15829c1a21c80325b7a7c3dcf4ce3370", "parents": [ "ccf90703bb6989e659b12a6494e84fdb921008ed" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Fri May 08 14:03:24 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Tue May 12 20:54:43 2015 +0000" }, "message": "attestation: Implemented RegisterKeyWithChapsToken.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually using \u0027attestation_client register\u0027 and \u0027p11_replay\n--list_objects\u0027 as well as manually checking the chrome certificate\nmanager after registration.\n\nChange-Id: I147f52fea8b0cb1c3cccaad98cffca5c08d032e3\nReviewed-on: https://chromium-review.googlesource.com/270144\nReviewed-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "ccf90703bb6989e659b12a6494e84fdb921008ed", "tree": "d7edb6baedd79e69a8ae3b2eaf5633ae6725b738", "parents": [ "bc0c74963418442991072b2c87baec839eec9c20" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Thu May 07 09:41:10 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Tue May 12 20:54:27 2015 +0000" }, "message": "attestation: Implemented a Sign operation.\n\nKeys that were created with KEY_USAGE_SIGN usage can be used to sign\narbitrary data with the RSA-PKCS1v15-SHA256 mechanism.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using \u0027attestation_client sign\u0027 and\n\u0027attestation_client verify\u0027\n\nChange-Id: Iafaf938e3df9bc65f82e5b134ccf94fa7f56b6b1\nReviewed-on: https://chromium-review.googlesource.com/270008\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "bc0c74963418442991072b2c87baec839eec9c20", "tree": "93d00abd6fc2d05cb8b027abbf0288392521a8b2", "parents": [ "62c73fa5a343fbbf6a0b0176dd789352b85c44e5" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Mon May 04 19:00:38 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Thu May 07 23:38:55 2015 +0000" }, "message": "attestation: Implemented an asymmetric Decrypt operation.\n\nKeys that are created with a KEY_USAGE_DECRYPT usage can be used to\ndecrypt using this operation. The encrypted data must use the\nTPM_BOUND_DATA format and the TPM_ES_RSAESOAEP_SHA1_MGF1 mechanism.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using \u0027attestation_client decrypt\u0027 and\n\u0027attestation_client encrypt\u0027\n\nChange-Id: Iae8fe01abf0c635d853974518c9b5e918f7b88c1\nReviewed-on: https://chromium-review.googlesource.com/269777\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "62c73fa5a343fbbf6a0b0176dd789352b85c44e5", "tree": "15ac367b6bf68f8af0049a84f43f99867632d61f", "parents": [ "2e89ba764046e015ae90a1668f7cb3eb29cf509d" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Fri May 01 16:52:36 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Thu May 07 22:25:40 2015 +0000" }, "message": "attestation: Implemented CreateCertifiableKey.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using \u0027attestation_client create\u0027\n\nChange-Id: If03c240a42c2c4c5877ca3900ecfe2d794abe0ea\nReviewed-on: https://chromium-review.googlesource.com/268921\nReviewed-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "2e89ba764046e015ae90a1668f7cb3eb29cf509d", "tree": "c162648cba160b63f8c5c6f5bc0d4715d7ed2b92", "parents": [ "31e5b6be932079624ddc6e227c29812f455ff4cc" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Tue Apr 28 17:01:21 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Thu May 07 22:25:20 2015 +0000" }, "message": "attestation: Implemented attestation key activation.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual with \u0027attestation_client encrypt_for_activate\u0027\nand \u0027attestation_client activate\u0027\n\nChange-Id: Ice393b7a1f51889681d81749ffc29495c293590f\nReviewed-on: https://chromium-review.googlesource.com/268776\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "31e5b6be932079624ddc6e227c29812f455ff4cc", "tree": "6821822149f0d8363e148b02612e5afa337d6782", "parents": [ "745de272a4afde07cd3b3a7c376976bd0a972b36" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Tue May 05 16:19:00 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Thu May 07 19:37:47 2015 +0000" }, "message": "attestation: Export protobufs in libattestation.so.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually linked against the lib with a project outside of\nplatform2\n\nChange-Id: Ie8fdbc5f629fa06a44c109aef58b3a4dbf0231ed\nReviewed-on: https://chromium-review.googlesource.com/269525\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "745de272a4afde07cd3b3a7c376976bd0a972b36", "tree": "8944a70ccbba69f9c538966d4d2a1c282aa7b174", "parents": [ "91b43220439ab46096af0efc47f9b706abc3b108" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Fri May 01 09:51:58 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 23:06:08 2015 +0000" }, "message": "attestation: Moved utility classes to common/\n\nBUG\u003dbrillo:737\nTEST\u003dbuild, unit\n\nChange-Id: I519cf6e476773bee19b3656e04965fb36e064cf8\nReviewed-on: https://chromium-review.googlesource.com/268775\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nReviewed-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "91b43220439ab46096af0efc47f9b706abc3b108", "tree": "12a5d2a499d5e7ecdb31fa8849831d6ef3808f15", "parents": [ "566c836c403212d5c13428b02ed65e5ff6e49a6b" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Mon Apr 27 16:49:20 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 18:34:48 2015 +0000" }, "message": "attestation: Fix database initialization threading.\n\nPushed database initialization onto the worker thread, made that worker\nthread an IO thread, and added a ThreadChecker to DatabaseImpl.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually checked that a call from the wrong thread triggers\nthe DCHECK()\n\nChange-Id: I59f5a05fc7c924808cb70fbef316e8db69a29555\nReviewed-on: https://chromium-review.googlesource.com/267592\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "566c836c403212d5c13428b02ed65e5ff6e49a6b", "tree": "f93e6512f8725f5abbfecd195a6735380bbf529e", "parents": [ "cd5486df897619718b68223ebefc1322a1f5ab29" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Mon Apr 27 15:21:07 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 18:34:38 2015 +0000" }, "message": "attestation: Implemented GetAttestationKeyInfo.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using \u0027attestation_client attestation_key\u0027\n\nChange-Id: Ied8f8dc9bfe16e15fb30fa555e91dfec49cb9dd8\nReviewed-on: https://chromium-review.googlesource.com/267565\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "cd5486df897619718b68223ebefc1322a1f5ab29", "tree": "16b451ff58b2f95d14a42763ac28b69655e47ad3", "parents": [ "6222defa52eb13c0d90673f642f2647f7753478b" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Mon Apr 27 11:44:49 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 18:34:33 2015 +0000" }, "message": "attestation: Implemented GetEndorsementInfo\n\nIt is possible to call GetEndorsementInfo before the TPM is owned.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using \u0027attestation_client endorsement\u0027\n\nChange-Id: I9d1f3be5f030e28f7f4930d8ce6ebd9f7c94635b\nReviewed-on: https://chromium-review.googlesource.com/267571\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "6222defa52eb13c0d90673f642f2647f7753478b", "tree": "1bd6a808eb3970b19d789b0d7d00f4d5f2c3a517", "parents": [ "b48a50fc394b9c8a1059463c9eaba4c8d1985b9b" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Wed Apr 22 19:24:22 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 18:34:28 2015 +0000" }, "message": "attestation: Implemented GetKeyInfo.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual using attestation_client\n\nChange-Id: I52b23cfa9bed99f883b198acb724961e2877af0a\nReviewed-on: https://chromium-review.googlesource.com/267114\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTrybot-Ready: Darren Krahn \u003cdkrahn@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "b48a50fc394b9c8a1059463c9eaba4c8d1985b9b", "tree": "eb00f5d11083831057035f2ceb7a9ccfe98e4028", "parents": [ "59d7aa26782d3c6efd707e3b936d56c893a2555a" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Thu Apr 23 21:16:34 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 05:50:55 2015 +0000" }, "message": "attestation: Refactor interface to use protobufs directly.\n\nThis reduces boiler-plate and simplifies callback relays, response\nprinting, etc.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual with \u0027attestation_client create\u0027\n\nChange-Id: Id970e5078d34bce47dd99d991f3c0e9d9ecf527c\nReviewed-on: https://chromium-review.googlesource.com/267084\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "59d7aa26782d3c6efd707e3b936d56c893a2555a", "tree": "85a9c0726d51bae34b3cf4b4bd8a6408d3268a0b", "parents": [ "d7ae21ca48a717fec15836b62701da26d9ec519d" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Tue Apr 21 13:22:04 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 05:50:51 2015 +0000" }, "message": "attestation: Add default implementations of service dependencies.\n\nAlso fixed a bug in the proxy and disabled minijail until we get it\nworking (in another CL).\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually tested \u0027attestation_client create\u0027\n\nChange-Id: Ieb4a9ce39b64fa0f8312a3ac27e671841a0824db\nReviewed-on: https://chromium-review.googlesource.com/266941\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "d7ae21ca48a717fec15836b62701da26d9ec519d", "tree": "5c8580e33e754c33bf0fba13b9914194efd64eaa", "parents": [ "d569cf62b11f74b7ca2ff2db53414927f7e2d66a" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Mon Apr 20 15:24:52 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 05:50:47 2015 +0000" }, "message": "attestation: Implement a PKCS #11 key store.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually tested by creating a key for a logged in user\n\nChange-Id: I9fa71d00d069501fe6e6c1a7e5b4e5c43c74cafc\nReviewed-on: https://chromium-review.googlesource.com/266940\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "d569cf62b11f74b7ca2ff2db53414927f7e2d66a", "tree": "236df976e25bd9b288ec2a74fcc131a207312467", "parents": [ "08d544a489c1a2608b01ff240bddb26d4a92b277" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Sat Apr 18 12:06:06 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 05:50:44 2015 +0000" }, "message": "attestation: Implemented CryptoUtility.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manual test against a CA\n\nChange-Id: Id4928c6d05a6dd11d0b94a380828bbe623ffe095\nReviewed-on: https://chromium-review.googlesource.com/266919\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "08d544a489c1a2608b01ff240bddb26d4a92b277", "tree": "f26411e962d2cbc01c0bde434dae7f288dff0114", "parents": [ "9bb29b0861b022a9c89bff02401efbdfa884edd9" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Thu Apr 16 12:47:24 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri May 01 05:50:38 2015 +0000" }, "message": "attestation: Implemented TpmUtility for TPM 1.2\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually ran against a CA\n\nChange-Id: I4c97ae7ff17849cefa18df1d3c8f7035c1eab69a\nReviewed-on: https://chromium-review.googlesource.com/266918\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "9bb29b0861b022a9c89bff02401efbdfa884edd9", "tree": "330d997ed8b5c8978c066cbab11a8b256b75d826", "parents": [ "1235db3c0028d4e55223730c8775ac7d715e6bac" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Fri Apr 24 18:09:32 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Wed Apr 29 01:49:26 2015 +0000" }, "message": "libchromeos: Replace scoped_ptr with std::unique_ptr in D-Bus method handlers\n\nChanged callbacks to use std::unique_ptr in D-Bus method handlers instead of\nscoped_ptr, now that we can do this with base::Callback.\nThis eliminates the need to mix scoped_ptr and std::unique_ptr in the same\ntranslation unit.\n\nSweep the code in the rest of platform2 that used libchromeos\u0027s D-Bus framework.\n\nBUG\u003dNone\nTEST\u003d`FEATURES\u003dtest emerge-link libchromeos apmanager attestation buffet chromeos-dbus-bindings`\n\nChange-Id: I50289198ef9ab183d5bc7d0c8cc7a8f53085e5a4\nReviewed-on: https://chromium-review.googlesource.com/267337\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTrybot-Ready: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Christopher Wiley \u003cwiley@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "1235db3c0028d4e55223730c8775ac7d715e6bac", "tree": "a3fbf09805b058815314a4bf83852d2f93f8803a", "parents": [ "d66389850c33614ffbbbbc3f768621182fd853ba" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Sat Apr 18 12:18:50 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 24 02:47:42 2015 +0000" }, "message": "attestation: Check for errors when writing db files.\n\nBUG\u003dbrillo:737\nTEST\u003dunit\n\nChange-Id: I4185aa75cce271a4fb2178aa72996651948971ae\nReviewed-on: https://chromium-review.googlesource.com/266393\nReviewed-by: Thiemo Nagel \u003ctnagel@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "d66389850c33614ffbbbbc3f768621182fd853ba", "tree": "5962f4a63d0f60553075f5a927209fbaab8db1a4", "parents": [ "30a5bba00647d29e324111005deb76a0466f8c6b" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Fri Apr 03 09:12:44 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Sat Apr 18 21:23:16 2015 +0000" }, "message": "attestation: Implemented CreateGoogleAttestedKey.\n\nOnly mock dependencies currently exist so this code is limited to unit\ntests.\n\nBUG\u003dbrillo:737\nTEST\u003dunit\n\nChange-Id: Ia23d0b6afdde9d7ce70a1363d143d562236f2fff\nReviewed-on: https://chromium-review.googlesource.com/265866\nReviewed-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "30a5bba00647d29e324111005deb76a0466f8c6b", "tree": "7f1d65c0a5315c3e69897cc7c18e3255e35b01d2", "parents": [ "39f82d968e22cd3de567df5ddb2d00a923c0bb74" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Sat Apr 11 00:21:36 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 17 01:46:50 2015 +0000" }, "message": "attestation: Implement the attestation database.\n\nThis database format is compatible with the current database used by\ncryptohome. This CL does not include the TPM functions required to\ndecrypt an actual database so its testing is limited to unit tests.\n\nBUG\u003dbrillo:737\nTEST\u003dunit\n\nChange-Id: I97b3cbd60159a01e318aad738ce178af54505a71\nReviewed-on: https://chromium-review.googlesource.com/265551\nReviewed-by: Utkarsh Sanghi \u003cusanghi@chromium.org\u003e\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "39f82d968e22cd3de567df5ddb2d00a923c0bb74", "tree": "9fc4912a96bec9b005a030eeb2a82217481d26cf", "parents": [ "0752bd25ba9f45c07bc989d42bf5272133a85afa" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Thu Apr 09 19:00:33 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 10 20:48:42 2015 +0000" }, "message": "attestation: Lift restrictions on copying callbacks.\n\nAttestationInterface implementations should be free to copy callback\nobjects. Previously they were not because a scoped_ptr was curried in.\nThe change is to eliminate scoped_ptrs as callback parameters.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually ran attestation_client\n\nChange-Id: I69fee531b09229f40ebd620dfd393d85e9c0af27\nReviewed-on: https://chromium-review.googlesource.com/265123\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "0752bd25ba9f45c07bc989d42bf5272133a85afa", "tree": "1953fac5edd87ffafde7db759655fc1a4733ea1d", "parents": [ "b91fd4923f411705be97fbc5c0ada37481c0cd8d" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Wed Apr 08 11:40:00 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 10 20:48:38 2015 +0000" }, "message": "attestation: Make the attestation interface asynchronous.\n\nAlso moves to the D-Bus asynchronous methods for proxy / object.\n\nBUG\u003dbrillo:737\nTEST\u003dbuild, unit tests, manually ran \u0027attestation_client\u0027\n\nChange-Id: I7cf60edcb5bf7fa112592e5f129a2dcd6334ae22\nReviewed-on: https://chromium-review.googlesource.com/264932\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "b91fd4923f411705be97fbc5c0ada37481c0cd8d", "tree": "725281c6f7c0228c9ea8322fba737e2c582dd7bd", "parents": [ "3518664c4f5d8215aed7e0b92e6f4ea4a8902195" ], "author": { "name": "Darren Krahn", "email": "dkrahn@chromium.org", "time": "Tue Mar 31 12:52:10 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 03 19:50:35 2015 +0000" }, "message": "attestation: Create skeleton of new attestation service.\n\nBUG\u003dbrillo:737\nTEST\u003dunit, manually ran attestation_client\nCQ-DEPEND\u003dCL:263787\n\nChange-Id: I2757f0b7bf457ed9fa0a1d09ccf63dc0c437dacf\nReviewed-on: https://chromium-review.googlesource.com/263786\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Darren Krahn \u003cdkrahn@chromium.org\u003e\nTested-by: Darren Krahn \u003cdkrahn@chromium.org\u003e\n" }, { "commit": "3518664c4f5d8215aed7e0b92e6f4ea4a8902195", "tree": "cb319104a9cb44cca80d6ab29531895247d1824d", "parents": [ "dfb5aef5079b92bc4c107fb0d5c17b946541f0eb" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Thu Apr 02 14:31:10 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Fri Apr 03 18:33:17 2015 +0000" }, "message": "platform2: Explicitly use base:: namespace with CommandLine\n\nThe current revision of libchrome is removing CommandLine class\nfrom global namespace and only retain the one in base::.\n\nSweep the code to use the correct namespace in anticpation of\nlibchrome revision roll.\n\nBUG\u003dNone\nTEST\u003d./build_packages\n\nChange-Id: Ib7ca448dac1204c1e36ab053e775a5a5214997ac\nReviewed-on: https://chromium-review.googlesource.com/263785\nTrybot-Ready: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Alex Deymo \u003cdeymo@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "dfb5aef5079b92bc4c107fb0d5c17b946541f0eb", "tree": "50b27ae1a12f78afba1cd7cf2b32052d1a3ba011", "parents": [ "c5f87bfcc103907dfd84055e8a3688c7f97c6079" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Sun Nov 09 13:21:59 2014 -0800" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Tue Nov 11 00:10:37 2014 +0000" }, "message": "libchromeos: Fix DBus data serialization to work with custom types\n\nThe previous implementation suffered from C++ binding rules for\nnon-dependent names in templates. Template functions such as\nAppendValueToWriter and PopValueFromReader for template types such\nas std::vector\u003cT\u003e and std::map\u003cK,V\u003e are limited to the types defined\nin libchromeos because the implementations calling the inner overloads\nfor types such as T would only select functions defined before the\noverloads for vector and map are defined.\n\nThis forced the custom implementations of user-provided types to\nbe included before chromeos/dbus/data_serialization.h and having\nthe code depend on the order of includes is a very dangerous thing.\n\nTo make the problem worse, generic AppendValueToWriter\u003cT\u003e is always\na default fall-back for any unknown types and it simply fails at run-time\nwhich makes it very difficult to detect unintended problems.\n\nThe reason why the generic AppendValueToWriter\u003cT\u003e() was provided is to\nallow chromeos::Any to contain any C++ type but still be able to use\nwith D-Bus subset of types to implement the D-Bus\u0027s VARIANT type.\n\nThis change addresses the above problems as follows:\n\n- The template functionality depending on custom overloads of\n AppendValueToWriter and PopValueFromReader now call them indirectly\n through DBusType\u003cT\u003e::Write and DBusType\u003cT\u003e::Read helpers that delay\n binding to the correct overload of Append... and Pop... until the\n template instantiation.\n- Marked the generic AppendValueToWriter\u003cT\u003e and PopValueFromReader\u003cT\u003e\n as \"deleted\" functions so the compilation would break as soon as\n these functions are called with an unsupported types.\n- Provided IsTypeSupported\u003cT...\u003e type trait to help specialize the\n implementation for only supported D-Bus types. This allows, for\n example, specialization of vector\u003cT\u003e to work for supported types\n T and fail immediately for T that are not supported by D-Bus.\n- Used IsTypeSupported\u003cT\u003e in chromeos::Any to disable calls to\n AppendValueToWriter at compile time for unsupported types.\n- Made AppendValueToWriter() a void function. Now it doesn\u0027t fail.\n The internal implementation inside chromeos::Any uses CHECK() to\n ensure the contained class which will abort as soon as Any,\n containing datat of an unsupported type, is being written to\n D-Bus message buffer.\n\nBUG\u003dchromium:431744\nTEST\u003dFEATURES\u003dtest emerge-link libchromeos attestation buffet peerd\n\nChange-Id: I13431f74797b8b92082f172a067ea1515a7aa73e\nReviewed-on: https://chromium-review.googlesource.com/228731\nReviewed-by: Christopher Wiley \u003cwiley@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "c5f87bfcc103907dfd84055e8a3688c7f97c6079", "tree": "61b80f7157365c64165de549d5dc1de59b3d64a3", "parents": [ "da5dd42c581f324bcfa96b0e4f3513cc6e331d67" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Thu Oct 30 16:28:38 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Thu Nov 06 06:32:38 2014 +0000" }, "message": "libchromeos: Add support for async D-Bus method handlers\n\nChanged DBusObject implementation infrastructure in libchromeos\nto add support for registering asynchronous D-Bus method handlers.\n\nAlso changed the simple synchronous method handler signature to\neliminate the confusion when a handler returning a value throws\nan error.\n\nCurrently, there are four kinds of D-Bus method handlers:\n- SimpleMethodHandler - has one of the following signatures:\n\n RetVal Handler(Args... args)\n void Handler(Args... args)\n\n The first one takes only input parameters (by value or const\n reference) and returns a single value as a function return.\n The second handler can mix both input (value/const reference)\n and output (pointer) values.\n\n This handler is synchronous (response is sent as soon as the\n handler returns) and does not provide any error returns\n (it always succeeds).\n\n- SimpleMethodHanderWithError\n This is similar to SimpleMethodHandler but provides a way\n to return an error. The handler signature is as follows:\n\n bool Handler(ErrorPtr* error, Args... args)\n\n The parameters can include both IN and OUT arguments.\n\n If the handler succeeds, it must return true. On failures,\n it returns false and provides error details in |error|.\n\n- MethodHandler - a generic (possibly asynchronous) handler\n that has the following signature:\n\n void Handler(scoped_ptr\u003cDBusMethodResponse\u003e response,\n Args... args)\n\n The parameters include only IN arguments and the method\n sends back any return values using the |response| object.\n\n The handler owns the |response| so it can start an\n asynchronous operation (that holds on to the response) and\n exit immediately. The D-Bus method response is sent only\n when the handler provides the reply using the response\n object.\n\n- RawMethodHandler\n This is the low-level method handler that does not go through\n any of the parameter/return value parsing. It is provided\n with the raw method call D-Bus message and is expected to\n provide the response manually. The handler signtaure is:\n\n void Handler(dbus::MethodCall* method_call,\n ResponseSender sender)\n\n This type of handler is useful to implement D-Bus methods\n with variable number of parameters or those which\n can accept a number of different types of arguments.\n\nBUG\u003dchromium:428390\nTEST\u003dFEATURES\u003dtest emerge-link libchromeos peerd buffet attestation\nCQ-DEPEND\u003dCL:227281\n\nChange-Id: I1dde6b279ada9d350a4d0e6743c56d3b12cc38cf\nReviewed-on: https://chromium-review.googlesource.com/226666\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "da5dd42c581f324bcfa96b0e4f3513cc6e331d67", "tree": "0d74b948d523f9846a61834fbd8f107c9f7a21be", "parents": [ "bed05922cab865817f615565f3702e3549e776bf" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Wed Sep 10 11:32:16 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Wed Oct 08 02:51:24 2014 +0000" }, "message": "attestation: Use chromeos::DBusServiceDaemon to implement the daemon\n\nSwitched attestationd to use the base D-Bus service daemon helper\nclass to simplify the daemon\u0027s implementation. The base class also\nhandles SIGTERM, SIGINT, and SIGHUP signals correctly.\n\nSince attestationd runs in a sandbox, I had to allow it to use\nrt_sigprocmask and signalfd4 sys calls to watch for incoming signals.\n\nFinally, fixed an issue introduced with a previous change.\nAutomatic serialization of D-Bus data doesn\u0027t pick up derived types\nwhen serializing data. It is not enough to provide serialization\nfor, say, google::protobuf::MessageLite and have it work with\nattestation::StatsResponse which derives from MessageLite.\n\nIt is important to specialize those functions for actual types\nsince to implicit type conversions are performed (we don\u0027t want\nto succeed serializing a char (which is not supported by D-Bus)\nand have it automatically converted to an int).\n\nBUG\u003dNone\nTEST\u003dUSE\u003dattestation emerge-link platform2\n Also tested on actual devices: link (x86-64), spring (ARM), lumpy (x86)\n\nChange-Id: I9e6e9ccc12f9976ff9748b3d06ad1caeb36264ca\nReviewed-on: https://chromium-review.googlesource.com/217419\nReviewed-by: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "bed05922cab865817f615565f3702e3549e776bf", "tree": "1bad4bcbced13be0b72d3fd8ae8a38f2b840f14e", "parents": [ "45fc1234b4f1a1c1cfdd44774350a70b26b9b630" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Tue Sep 16 10:59:16 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Thu Sep 18 03:04:04 2014 +0000" }, "message": "libchromeos: Fixed D-Bus method call error handling\n\nExtracted portions of ExtractMethodCallResults into a separate\nset of functions (ExtractMessageParametersAsTuple and\nExtractMessageParameters) to help with reading data from\nD-Bus message buffers.\n\nAlso changed ExtractMethodCallResults to accespt generic\ndbus::Message instead of dbus::Response. This way we can\ndeserialize parameters from other message types, such as\ndbus::Signal.\n\nFinally, since dbus::ObjectProxy::CallMethodAndBlock()\ndoes not return any error information when a D-Bus method\ncall failed, it returns a nullptr response instead of\nexpected dbus::ErrorResponse. Therefore the intended\nimplementation of chromeos::dbus_utils::CallMethodAndBlock()\nand chromeos::dbus_utils::ExtractMethodCallResults()\nfunctions were not treating the failures correctly.\nAs a step towards fixing the issue, added error parameter\nto chromeos::dbus_utils::CallMethodAndBlock() and\nupdated code that called it to check for nullptr return\nvalues. The second step would be to add a new method\ndbus::ObjectProxy::CallMethodAndBlockWithError() to\nChrome and switch chromeos::dbus_utils::CallMethodAndBlock()\nto use that method instead and retrieve the error information\ncorrectly.\n\nBUG\u003dchromium:414838\nTEST\u003dUSE\u003dattestation FEATURES\u003dtest emerge-link libchromeos buffet peerd platform2\n\nChange-Id: Ia5d6999afb50c0b3c9ab1c5057a9fc805a528ab5\nReviewed-on: https://chromium-review.googlesource.com/218468\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "45fc1234b4f1a1c1cfdd44774350a70b26b9b630", "tree": "5797c03fa70e0faf03792174dacca075d2929bdc", "parents": [ "4252ad9e67103cadbf98f97ce0441b060d397950" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Fri Aug 29 14:39:02 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Wed Sep 03 09:23:53 2014 +0000" }, "message": "attestation: Use DBusObject to implement the attestation service\n\nSwitch Attestation serivce to use chromeos::dbus_utils::DBusObject\nto implement its D-Bus object and use CallMethodAndBlock and\nExtractMethodCallResults from libchromeos to invoke a method\nfrom the client.\n\nBUG\u003dNone\nTEST\u003dUSE\u003dattestation emerge-link platform2\n\nChange-Id: Icbd9f5fdc31ee72f142acdaa17325b6e572ab032\nReviewed-on: https://chromium-review.googlesource.com/215685\nReviewed-by: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "4252ad9e67103cadbf98f97ce0441b060d397950", "tree": "4a0337c7a67c3ab17da02e36aa2ec0f245b41ad6", "parents": [ "75efc6369766ea0bef1b0f78fbc76e927d94d589" ], "author": { "name": "Ben Chan", "email": "benchan@chromium.org", "time": "Sat Aug 16 11:00:01 2014 -0700" }, "committer": { "name": "Ben Chan", "email": "benchan@chromium.org", "time": "Sat Aug 16 21:45:38 2014 +0000" }, "message": "attestation: Add OWNERS file.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I9be69fbc2b00db8c3e764ec10097c003b3325165\nReviewed-on: https://chromium-review.googlesource.com/212813\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Ben Chan \u003cbenchan@chromium.org\u003e\nTested-by: Ben Chan \u003cbenchan@chromium.org\u003e\n" }, { "commit": "75efc6369766ea0bef1b0f78fbc76e927d94d589", "tree": "a34dfc678625df88494c741438a05fc1343cc7fb", "parents": [ "ab0cddda9971f97781fc9f6cbc76095ba7542abf" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Fri Aug 08 09:36:48 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri Aug 08 22:04:54 2014 +0000" }, "message": "platform2: move --std\u003dgnu++11 flag to common-mk/common.gypi\n\nA number of platform2 projects enabled C++11 features individually\nin their .GYP files. Removed this flag from each of the projects\nand added it to common.gypi for everyone to share.\n\nBUG\u003dNone\nTEST\u003dCompile various platform2 targets to make sure they still compile.\n\nChange-Id: I4136573ec5dcc988df2826056c8dae8847725504\nReviewed-on: https://chromium-review.googlesource.com/211534\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "ab0cddda9971f97781fc9f6cbc76095ba7542abf", "tree": "c64ad366b67f8f52bafd874e3a7e3ef3deb42565", "parents": [ "e79254e7ee3f3b99f422a69cb1d08dd0500e575b" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Wed Jul 30 13:19:05 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri Aug 01 04:18:41 2014 +0000" }, "message": "attestation: fix linter issues\n\nFixed various issues reported by cpplint.py when run on\nsrc/platform2/attestation.\n\nBUG\u003dNone\nTEST\u003dcpplint.py `find attestation/* | grep \"\\.cc\\|\\.h\"`\n USE\u003dattestation FEATURES\u003dtest emerge-link platform2\n\nChange-Id: Ie779616f4b8e0fda9c7646776540bc83c0c1a193\nReviewed-on: https://chromium-review.googlesource.com/210524\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Alex Deymo \u003cdeymo@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "e79254e7ee3f3b99f422a69cb1d08dd0500e575b", "tree": "aaae0e2eb761117312b9cadb3f026d21df9ac865", "parents": [ "c0cb8cf4e0b6f48293a8739efc565a59a4819915" ], "author": { "name": "Bertrand SIMONNET", "email": "bsimonnet@chromium.org", "time": "Wed Jun 18 14:48:39 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Sat Jun 21 02:23:01 2014 +0000" }, "message": "Create a standalone ebuild for system_api\n\nsystem_api is required by a lot of platform2 packages. We need it to be in a\nstandalone ebuild in order for other packages to depend on it.\n\nThis package installs the common headers and compiles the protobufs into static\nlibraries.\n\nBUG\u003dchromium:386223\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic platform2.\nTEST\u003dtrybot run on daisy, link, duck, x86-mario.\nTEST\u003dtrybot run on lumpy-incremental-release.\n\nCQ-DEPEND\u003dCL:204594\n\nChange-Id: I39e7c7e4bd03b9b5980e08c5e4fa7bc79e268880\nReviewed-on: https://chromium-review.googlesource.com/204606\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\nCommit-Queue: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\n" }, { "commit": "c0cb8cf4e0b6f48293a8739efc565a59a4819915", "tree": "1d1af4da38570eb14a584a1894b128a67252c8a7", "parents": [ "78ea5ef6568f404ec69972e6823a0ec8cd4c5886" ], "author": { "name": "Bertrand SIMONNET", "email": "bsimonnet@chromium.org", "time": "Thu Jun 19 14:01:58 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri Jun 20 03:51:18 2014 +0000" }, "message": "Update trunks, attestation, feedback to depend on libchromeos\n\nLibchromeos is now a standalone package. packages should depend on it with the\ndeps variable mechanism instead of depending on the gyp target.\n\nBUG\u003dchromium:381372\nTEST\u003dUSE\u003d\"attestation\" emerge-amd64-generic platform2 works.\n\nChange-Id: Idbe2e730c9f33e32f5154553d7e3f32ad4c04de9\nReviewed-on: https://chromium-review.googlesource.com/204688\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\nTested-by: Bertrand Simonnet \u003cbsimonnet@chromium.org\u003e\n" }, { "commit": "78ea5ef6568f404ec69972e6823a0ec8cd4c5886", "tree": "162cbf08c9734b86c78ec731809b4ffd6927c72c", "parents": [ "1906acf23d16ab6ff86e1f9a30836b312e41d1df" ], "author": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Fri Apr 18 13:33:36 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Sat Apr 19 03:36:31 2014 +0000" }, "message": "attestation: Add seccomp policies\n\nBUG\u003dchromium:357290\nTEST\u003dOn each supported platform (x86, x86_64, arm), make sure that\n /usr/bin/attestation returns some uptime number.\nCQ-DEPEND\u003dCL:195622\n\nChange-Id: Ibf2f5f79cb7d96ac749c682a6feb01b8b23d5eff\nReviewed-on: https://chromium-review.googlesource.com/195595\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nCommit-Queue: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\nTested-by: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\n" }, { "commit": "1906acf23d16ab6ff86e1f9a30836b312e41d1df", "tree": "9d112c26423eed63c1ab819bf256eac0e948a0af", "parents": [ "ebdd63947943f6f07001439042654e8d352b3165" ], "author": { "name": "Alex Vakulenko", "email": "avakulenko@chromium.org", "time": "Mon Apr 14 15:17:25 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Tue Apr 15 03:49:16 2014 +0000" }, "message": "Updated buffet and attestation to use platform2.gyp\n\nWhen building platform2, platform2-9999.ebuild used to invoke\nplatform2.py from src/platform/common-mk/ which caused some issues\nfor native platform targets such as platform2/attestation and\nplatform2/buffet.\nNow that all the necessary platform2 build files are moved into\nsrc/platform2/common-mk/, platform2.gyp, plaform2.py and\nplatform2-9999.ebuild have been updated to treat platform2 as the\ncorrect root dir for platform2 target, with additional component\nsource files pulled from src/platform (e.g. shill, chaps,...)\nWhen platform2.py invokes \u0027gyp\u0027 it now passes \u0027chromeos/src\u0027 as the\nroot dir through --depth parameter, so that both src/platform and\nsrc/platfotm2 targets can be referenced as equals.\n\nBUG\u003dchromium:358237\nTEST\u003dcros_workon_make chromeos-base/platform2 --test\n build_packages\n emerge-link platform2\n USE\u003dbuffet emerge-link platform2\nCQ-DEPEND\u003dCL:193681\n\nChange-Id: I84a6cbc118582628bbb6a4ff157d37a66b804b40\nReviewed-on: https://chromium-review.googlesource.com/194116\nReviewed-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n" }, { "commit": "ebdd63947943f6f07001439042654e8d352b3165", "tree": "4edb1dbf25cd92b736c28e2eafbc3d4f08da1614", "parents": [ "ae7abc441486435039bed09238f1e6e53d632efd" ], "author": { "name": "Ben Chan", "email": "benchan@chromium.org", "time": "Fri Apr 11 19:44:09 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Sun Apr 13 11:42:12 2014 +0000" }, "message": "platform2: Update to build against libchrome-242728 by default\n\nMake platform2 to build against libchrome-242728 by default and remove\nthe libbase_ver override in gyp files.\n\nBUG\u003dchromium:331128,chromium:361748\nCQ-DEPEND\u003dCL:194475\nTEST\u003dTested the following:\n1. `FEATURES\u003dtest emerge-$BOARD platform2`\n2. `FEATURES\u003dtest USE\u003d\u0027attestation\u0027 emerge-$BOARD platform2`\n2. `FEATURES\u003dtest USE\u003d\u0027buffet\u0027 emerge-$BOARD platform2`\n2. `FEATURES\u003dtest USE\u003d\u0027wimax gdmwimax\u0027 emerge-$BOARD platform2`\n3. `FEATURES\u003dtest USE\u003d\u0027asan clang\u0027 emerge-$BOARD platform2`\n4. Trybot runs on paladin, release and chromiumos-sdk builders.\n\nChange-Id: I7b49ca84dbddfd5c0e7111aba757f2c005196cdc\nReviewed-on: https://chromium-review.googlesource.com/194494\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Ben Chan \u003cbenchan@chromium.org\u003e\nTested-by: Ben Chan \u003cbenchan@chromium.org\u003e\n" }, { "commit": "ae7abc441486435039bed09238f1e6e53d632efd", "tree": "25ff4bf4089364d46e12ec788ccd37ab60cf6ed7", "parents": [ "4d6fbca65a6c6e77eeee12142ed702564d8a3792" ], "author": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Wed Mar 26 14:35:10 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Sun Apr 06 04:14:11 2014 +0000" }, "message": "attestation: Drop root, change to `attestation` user/group\n\nBUG\u003dchromium:348650\nTEST\u003dCreate attestation user, and attestation group.\nTEST\u003dMake sure ps shows attestationd is running as attestation user.\nTEST\u003dKill attestationd, make sure upstart will restart it.\nTEST\u003dRemove attestation user or group.\nTEST\u003dMake sure upstart fail to launch attestationd.\n\nChange-Id: I4dde29845b9928ca8d135c6e48dd1f179497f4d3\nReviewed-on: https://chromium-review.googlesource.com/191727\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nTested-by: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\nCommit-Queue: Nam Nguyen \u003cnamnguyen@chromium.org\u003e\n" }, { "commit": "4d6fbca65a6c6e77eeee12142ed702564d8a3792", "tree": "d22cb51fb95f70f2c1be1906c78663aa927fbf67", "parents": [ "6bead48129845a2bc0d6ff347f3d7e232004d590" ], "author": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Tue Mar 25 11:04:37 2014 -0700" }, "committer": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Tue Mar 25 11:09:07 2014 -0700" }, "message": "attestation: Fix include directories\n\nAssume (for now) that `src/platform2` will be copied by emerge into a temp\n`platform2-9999` directory. So we\u0027ll have a structure like this::\n\n platform2-9999\n chaps\n common-mk\n ...\n platform2\n attestation\n buffet\n ...\n\nWhen current repositories in `src/platform` are migrated to `src/platform2`,\nwe need to fix this again.\n\nBUG\u003dchromium:345099\nTEST\u003dSee CL:188254\nChange-Id: Iac212b1803b04ba3a40971d4530d4ba99cae6f3d\n" }, { "commit": "6bead48129845a2bc0d6ff347f3d7e232004d590", "tree": "d8e8a023925acb3fcb6e7b09414292a5bf3e009c", "parents": [], "author": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Thu Feb 27 15:18:55 2014 -0800" }, "committer": { "name": "Nam T. Nguyen", "email": "namnguyen@chromium.org", "time": "Tue Mar 11 13:15:05 2014 -0700" }, "message": "attestation: Add a skeleton daemon and client\n\nBUG\u003dchromium:345099\nTEST\u003dSee CL:188254\n\nChange-Id: Icb9d12e410e8c3137278969aa314b39eb38afdf3\n" } ] }