Temporarily remove Smaps() call in ProcessRecord
This change removes the Smaps() call in ProcessRecord initialization
because it leads to swap_offsets_ not being populated. This can be
undone once Smaps() is reworked to collect swap_offsets_.
This leads to a large regression in procrank/librank (~0.8s -> ~4.2s)
and bugreport_procdump (~1.2s -> ~4.8s) due to additional map reads.
This may not be fully recovered once Smaps() is corrected.
Test: Run procrank and bugreport_procdump and verify that the procrank
output contains populated PSwap/USwap/ZSwap columns.
Bug: 279070595
(cherry picked from https://android-review.googlesource.com/q/commit:51aec949281996500e6463392c72c55c7ce8b1d8)
Merged-In: I8d74d949b6b839df00ed25ad70eae4f9cb05bd47
Change-Id: I8d74d949b6b839df00ed25ad70eae4f9cb05bd47
diff --git a/libsmapinfo/processrecord.cpp b/libsmapinfo/processrecord.cpp
index e859310..615cfb8 100644
--- a/libsmapinfo/processrecord.cpp
+++ b/libsmapinfo/processrecord.cpp
@@ -93,7 +93,13 @@
// We want to use Smaps() to populate procmem_'s maps before calling Wss() or Usage(), as
// these will fall back on the slower ReadMaps().
- procmem_.Smaps("", true);
+ //
+ // This Smaps() call is temporarily disabled because it results in
+ // procmem_'s swap_offsets_ not being populated, causing procrank to not
+ // report PSwap/USwap/ZSwap. Wss() and Usage() both fall back to ReadMaps(),
+ // which will populate swap_offsets_.
+ //
+ // procmem_.Smaps("", true);
usage_or_wss_ = get_wss ? procmem_.Wss() : procmem_.Usage();
swap_offsets_ = procmem_.SwapOffsets();
pid_ = pid;
