commit 5c6bb1d8f89b87e782e26fe74789b6f510704394
author Chih-Hung Hsieh <chh@google.com> Wed Jul 27 13:33:15 2016 -0700
committer Treehugger Robot <treehugger-gerrit@google.com> Thu Jul 28 17:32:42 2016 +0000
tree 9c177ad062ca0a25ea872e369d7e43fbd46afbed
parent 87792ea818a63f2d246bbba2b7429b85ee8d669f

Fix clang-tidy performance warnings in update_engine.

* Use const reference type for parameters, local variables,
  and for-loop index variables to avoid unnecessary copy.
* Convert some for-loops to for-rang loops.

Bug: 30407689
Bug: 30413223
Bug: 30413862
Change-Id: I78996b3f799639fc57ced45e110807625be7dcce
Test: build with WITH_TIDY=1

common/fake_hardware.h

diff --git a/common/fake_hardware.h b/common/fake_hardware.h
index f7c0286..5d0fca3 100644
--- a/common/fake_hardware.h
+++ b/common/fake_hardware.h
@@ -109,15 +109,15 @@
     is_oobe_complete_ = false;
   }
 
-  void SetHardwareClass(std::string hardware_class) {
+  void SetHardwareClass(const std::string& hardware_class) {
     hardware_class_ = hardware_class;
   }
 
-  void SetFirmwareVersion(std::string firmware_version) {
+  void SetFirmwareVersion(const std::string& firmware_version) {
     firmware_version_ = firmware_version;
   }
 
-  void SetECVersion(std::string ec_version) {
+  void SetECVersion(const std::string& ec_version) {
     ec_version_ = ec_version;
   }