Google Git
Sign in
android / platform / system / update_engine / ec39a220c4122305f92dbede8e7f0154bfe4c7b1
commitec39a220c4122305f92dbede8e7f0154bfe4c7b1[log] [tgz]
authorKeigo Oka <[email protected]>Thu Jun 27 13:51:07 2019 +0900
committerchrome-bot <[email protected]>Sat Jun 29 02:54:33 2019 -0700
tree018504ae2de9fffd36a952c0a7e9eafc4220197a
parent165d4b4eac9691108ee3425b16f30e4b2456bca9 [diff]
update_engine: fix heap-buffer-overflow

ASAN error happens depending on library ordering in compile flags (crbug/887845).
This change updates BUILD.gn so that correct library ordering is generated.

BUG=chromium:976843
TEST=setup_board --board=amd64-generic --profile=asan
TEST=./build_packages --board=amd64-generic update_engine
TEST=FEATURES=test emerge-amd64-generic update_engine  # Some test fail, but they also fail without ASAN and this modification.

Change-Id: I40bb72f25e7012105eecac5c53d01662d68bf3d7
Reviewed-on: https://chromium-review.googlesource.com/1679810
Tested-by: Manoj Gupta <[email protected]>
Commit-Ready: Manoj Gupta <[email protected]>
Legacy-Commit-Queue: Commit Bot <[email protected]>
Reviewed-by: Amin Hassani <[email protected]>
1 file changed
tree: 018504ae2de9fffd36a952c0a7e9eafc4220197a
  1. binder_bindings/
  2. client-headers/
  3. client_library/
  4. common/
  5. dbus_bindings/
  6. fuzz/
  7. init/
  8. payload_consumer/
  9. payload_generator/
  10. sample_images/
  11. scripts/
  12. update_engine/
  13. update_manager/
  14. update_payload_key/
  15. .clang-format
  16. .gitignore
  17. Android.bp
  18. binder_service_android.cc
  19. binder_service_android.h
  20. boot_control_android.cc
  21. boot_control_android.h
  22. boot_control_android_unittest.cc
  23. boot_control_chromeos.cc
  24. boot_control_chromeos.h
  25. boot_control_chromeos_unittest.cc
  26. BUILD.gn
  27. certificate_checker.cc
  28. certificate_checker.h
  29. certificate_checker_unittest.cc
  30. chrome_browser_proxy_resolver.cc
  31. chrome_browser_proxy_resolver.h
  32. COMMIT-QUEUE.ini
  33. common_service.cc
  34. common_service.h
  35. common_service_unittest.cc
  36. connection_manager.cc
  37. connection_manager.h
  38. connection_manager_android.cc
  39. connection_manager_android.h
  40. connection_manager_interface.h
  41. connection_manager_unittest.cc
  42. connection_utils.cc
  43. connection_utils.h
  44. CPPLINT.cfg
  45. daemon_android.cc
  46. daemon_android.h
  47. daemon_base.h
  48. daemon_chromeos.cc
  49. daemon_chromeos.h
  50. daemon_state_android.cc
  51. daemon_state_android.h
  52. daemon_state_interface.h
  53. dbus_connection.cc
  54. dbus_connection.h
  55. dbus_service.cc
  56. dbus_service.h
  57. dbus_test_utils.h
  58. dlcservice_chromeos.cc
  59. dlcservice_chromeos.h
  60. dynamic_partition_control_android.cc
  61. dynamic_partition_control_android.h
  62. dynamic_partition_control_interface.h
  63. fake_file_writer.h
  64. fake_p2p_manager.h
  65. fake_p2p_manager_configuration.h
  66. fake_shill_proxy.cc
  67. fake_shill_proxy.h
  68. fake_system_state.cc
  69. fake_system_state.h
  70. generate_pc_file.sh
  71. hardware_android.cc
  72. hardware_android.h
  73. hardware_chromeos.cc
  74. hardware_chromeos.h
  75. hardware_chromeos_unittest.cc
  76. image_properties.h
  77. image_properties_android.cc
  78. image_properties_android_unittest.cc
  79. image_properties_chromeos.cc
  80. image_properties_chromeos_unittest.cc
  81. libcurl_http_fetcher.cc
  82. libcurl_http_fetcher.h
  83. local_coverage_rate
  84. main.cc
  85. metrics_constants.h
  86. metrics_reporter_android.cc
  87. metrics_reporter_android.h
  88. metrics_reporter_interface.h
  89. metrics_reporter_omaha.cc
  90. metrics_reporter_omaha.h
  91. metrics_reporter_omaha_unittest.cc
  92. metrics_reporter_stub.cc
  93. metrics_reporter_stub.h
  94. metrics_utils.cc
  95. metrics_utils.h
  96. metrics_utils_unittest.cc
  97. mock_boot_control_hal.h
  98. mock_certificate_checker.h
  99. mock_connection_manager.h
  100. mock_dynamic_partition_control.h
  101. mock_file_writer.h
  102. mock_metrics_reporter.h
  103. mock_omaha_request_params.h
  104. mock_p2p_manager.h
  105. mock_payload_state.h
  106. mock_power_manager.h
  107. mock_service_observer.h
  108. mock_update_attempter.h
  109. MODULE_LICENSE_APACHE2
  110. network_selector.h
  111. network_selector_android.cc
  112. network_selector_android.h
  113. network_selector_interface.h
  114. network_selector_stub.cc
  115. network_selector_stub.h
  116. NOTICE
  117. omaha_request_action.cc
  118. omaha_request_action.h
  119. omaha_request_action_fuzzer.cc
  120. omaha_request_action_unittest.cc
  121. omaha_request_builder_xml.cc
  122. omaha_request_builder_xml.h
  123. omaha_request_builder_xml_unittest.cc
  124. omaha_request_params.cc
  125. omaha_request_params.h
  126. omaha_request_params_unittest.cc
  127. omaha_response.h
  128. omaha_response_handler_action.cc
  129. omaha_response_handler_action.h
  130. omaha_response_handler_action_unittest.cc
  131. omaha_utils.cc
  132. omaha_utils.h
  133. omaha_utils_unittest.cc
  134. OWNERS
  135. p2p_manager.cc
  136. p2p_manager.h
  137. p2p_manager_unittest.cc
  138. payload_state.cc
  139. payload_state.h
  140. payload_state_interface.h
  141. payload_state_unittest.cc
  142. power_manager_android.cc
  143. power_manager_android.h
  144. power_manager_chromeos.cc
  145. power_manager_chromeos.h
  146. power_manager_interface.h
  147. PRESUBMIT.cfg
  148. PREUPLOAD.cfg
  149. pylintrc
  150. real_system_state.cc
  151. real_system_state.h
  152. run_unittests
  153. sample_omaha_v3_response.xml
  154. service_delegate_android_interface.h
  155. service_observer_interface.h
  156. shill_proxy.cc
  157. shill_proxy.h
  158. shill_proxy_interface.h
  159. sideload_main.cc
  160. system_state.h
  161. tar_bunzip2.gni
  162. test_http_server.cc
  163. test_subprocess.cc
  164. testrunner.cc
  165. unittest_key.pem
  166. unittest_key2.pem
  167. update_attempter.cc
  168. update_attempter.h
  169. update_attempter_android.cc
  170. update_attempter_android.h
  171. update_attempter_android_unittest.cc
  172. update_attempter_unittest.cc
  173. update_boot_flags_action.cc
  174. update_boot_flags_action.h
  175. update_boot_flags_action_unittest.cc
  176. update_engine.conf
  177. update_engine.rc
  178. update_engine_client.cc
  179. update_engine_client_android.cc
  180. update_metadata.proto
  181. update_status_utils.cc
  182. update_status_utils.h
  183. UpdateEngine.conf