update_payload: Fix most of lint styling issues. This patch fixes a lot of pylint issues in the update_engine scripts. Majority of this changes are based on recommendation found in: https://www.chromium.org/chromium-os/python-style-guidelines It is a good idea to do these changes now, because if there are many pylint errors when performing 'repo upload', serious problems can be overshadowed by a lot of noise and eventually cause problems. These fixes include: - Fixing executable shebangs to /usr/bin/python2. - Fixing import-error problems by disabiling them. - Removing pylint disables that are not valid anymore. - Changing all imports to proper absolute import format. - Change the import of PayloadError from update_payload.PayloadError for simplicity. - Add pydoc strings for functions and classes that were missing. The remaining unchanged pylint problmes include: - The header files of these scripts are in CrOS copyright format, but the the cros lint hook is configured to AoSP copyright format. - The test* functions in unittests are not compatible with CamelCase format. BUG=chromium:796338 TEST=unittests pass TEST=start_devserver TEST=cros flash TEST=scripts/paycheck.py Change-Id: I7eed4d1625eb7c510c7949fada120de5a6a26c7b Reviewed-on: https://chromium-review.googlesource.com/834875 Commit-Ready: Amin Hassani <[email protected]> Tested-by: Amin Hassani <[email protected]> Reviewed-by: Ben Chan <[email protected]> Reviewed-by: Sen Jiang <[email protected]>
diff --git a/scripts/update_payload/common.py b/scripts/update_payload/common.py index eaf0611..231c504 100644 --- a/scripts/update_payload/common.py +++ b/scripts/update_payload/common.py
@@ -6,8 +6,8 @@ from __future__ import print_function -from error import PayloadError -import update_metadata_pb2 +from update_payload import update_metadata_pb2 +from update_payload.error import PayloadError # @@ -35,7 +35,6 @@ class OpType(object): """Container for operation type constants.""" _CLASS = update_metadata_pb2.InstallOperation - # pylint: disable=E1101 REPLACE = _CLASS.REPLACE REPLACE_BZ = _CLASS.REPLACE_BZ MOVE = _CLASS.MOVE